Merge pull request #12747 from ethereum/konopkja-patch-2

Updating wallet listing criteria

Author: corwintines

.github/ISSUE_TEMPLATE/suggest_wallet.yaml

@@ -6,7 +6,7 @@ body:
   - type: markdown
     attributes:
       value: |
-        Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-wallets/). Only continue with the issue if the wallet meets the criteria listed there.
+        Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-wallets/). Only continue with the issue if the wallet meets the criteria listed there. For any required questions, please answer N/A for any questions not applicable to your wallet.
   - type: markdown
     id: project_info
     attributes:
@@ -18,6 +18,16 @@ body:
       description: Please provide the official name of the wallet.
     validations:
       required: true
+  - type: dropdown
+    id: wallet_type
+    attributes:
+      label: What type of wallet?
+      options:
+        - "EOA"
+        - "Account Abstraction"
+        - "Smart contract"
+    validations:
+      required: true
   - type: textarea
     id: wallet_description
     attributes:
@@ -55,6 +65,13 @@ body:
       description: Please provide a date when the wallet was usable by the public
     validations:
       required: true
+  - type: textarea
+    id: wallet_user_fees
+    attributes:
+      label: What are the fees users may be paying for using your wallet product?
+      description: eg) 1% service fee for swapping, bridging functionality, flat fee for all transactions
+    validations:
+      required: true
   - type: input
     id: wallet_active_development_team
     attributes:
@@ -69,11 +86,13 @@ body:
       description: Please list any KYC requirements or geographic limitations of the wallet, if any exist.
     validations:
       required: true
-  - type: input
+  - type: textarea
     id: wallet_languages
     attributes:
       label: Is the wallet available in multiple languages?
       description: Please list languages that the wallet actively supports.
+    validations:
+      required: true
   - type: textarea
     id: wallet_socials
     attributes:
@@ -90,35 +109,50 @@ body:
     attributes:
       label: Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?
       description: Please provide app store links for the operating systems supported.
+    validations:
+      required: true
   - type: textarea
     id: wallets_desktop
     attributes:
       label: Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?
       description: Please provide links and information for the desktop operating systems supported.
+    validations:
+      required: true
   - type: textarea
     id: wallets_browser
     attributes:
       label: Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?
       description: Please provide links and information for the browsers that are supported.
+    validations:
+      required: true
   - type: textarea
     id: wallets_hardware
     attributes:
       label: Is it a hardware wallet?
       description: How does it broadcast signed transactions (e.g. USB, Bluetooth, QR code)?
+    validations:
+      required: true
   - type: markdown
     id: security
     attributes:
       value: "## Security"
-  - type: input
+  - type: dropdown
     id: wallet_source_code
     attributes:
-      label: Is the source code for the wallet fully open-source?
-      description: If yes, please provide a direct link to the repository.
+      label: What is the availability of your source code?
+      options:
+        - "Open source"
+        - "Source available"
+        - "Closed source"
+    validations:
+      required: true
   - type: input
     id: wallet_license
     attributes:
       label: What license is the wallet software released under?
       description: Please provide information on the software license used for the wallet.
+    validations:
+      required: true
   - type: textarea
     id: wallet_custodial
     attributes:
@@ -133,43 +167,51 @@ body:
     attributes:
       label: Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible
       description: Please provide a link to any security audits, code reports, and bug bounties. If you haven't been audited but think the wallet should be listed anyway, explain here.
+    validations:
+      required: true
   - type: input
     id: wallet_smart_contract_audit
     attributes:
       label: Has the wallet's smart contract code or security modules been audited?
       description: If yes, provide a link to any audits.
+    validations:
+      required: true
   - type: input
     id: wallet_security_team
     attributes:
       label: Does the wallet have an internal security team?
       description: If yes, please provide details.
+    validations:
+      required: true
   - type: textarea
     id: wallet_security_testing
     attributes:
       label: Any other security testing that should be noted?
       description: Please note any other security precautions taken.
+    validations:
+      required: true
   - type: textarea
     id: wallet_scam_protection
     attributes:
       label: Scam protection?
       description: Does the wallet employ any practices to warn users against potential scams (e.g. when interacting with suspicious accounts/contracts)?
+    validations:
+      required: true
   - type: markdown
     id: features
     attributes:
       value: "## Features"
-  - type: dropdown
-    id: wallet_hardware_support
+  - type: input
+    id: wallet_dapp_support
     attributes:
-      label: Does the wallet support connecting to a hardware wallet?
-      options:
-        - "Yes"
-        - "No"
+      label: Does the wallet support connecting to Ethereum applications?
+      description: Please provide documentation for how users connect to applications. List examples (ie. WalletConnect, connect wallet to dapp directly, in wallet browser, etc.)
     validations:
       required: true
   - type: dropdown
-    id: wallet_walletconnect
+    id: wallet_hardware_support
     attributes:
-      label: Does the wallet support WalletConnect?
+      label: Does the wallet support connecting to a hardware wallet?
       options:
         - "Yes"
         - "No"
@@ -180,6 +222,8 @@ body:
     attributes:
       label: Does the wallet support importing Ethereum RPC endpoints?
       description: Please provide documentation on how a user can import an Ethereum RPC into the wallet.
+    validations:
+      required: true
   - type: dropdown
     id: wallet_nft_viewing
     attributes:
@@ -189,51 +233,76 @@ body:
         - "No"
     validations:
       required: true
-  - type: input
-    id: wallet_dapp_support
-    attributes:
-      label: Does the wallet support connecting to Ethereum applications?
-      description: Please provide documentation for how users connect to applications. List examples (ie. connect wallet to dapp, in wallet browser, etc.)
   - type: input
     id: wallet_direct_staking
     attributes:
       label: Does the wallet support staking directly?
       description: Please provide documentation on direct staking this wallet supports.
+    validations:
+      required: true
   - type: input
     id: wallet_swaps
     attributes:
       label: Does the wallet support swaps directly?
       description: Please provide documentation on swaps.
+    validations:
+      required: true
+  - type: input
+    id: wallet_bridging
+    attributes:
+      label: Does the wallet support bridging directly?
+      description: Please provide documentation on bridging.
+    validations:
+      required: true
   - type: input
     id: wallet_multi_chain_support
     attributes:
       label: Does the wallet support multi-chain networks?
       description: Please provide documentation on multi-chain networks this wallet supports.
+    validations:
+      required: true
   - type: input
     id: wallet_l2_support
     attributes:
       label: Does the wallet support Ethereum layer 2 networks?
       description: Please provide documentation on Ethereum layer 2 networks this wallet supports.
+    validations:
+      required: true
   - type: input
     id: wallet_customize_gas_fees
     attributes:
       label: Does the wallet allow the user to customize gas fees?
       description: Please provide documentation on how users can customize gas fees for transactions.
+    validations:
+      required: true
   - type: input
     id: wallet_ens_support
     attributes:
       label: Does the wallet support sending transactions to ENS addresses?
       description: Please provide information on ENS support.
+    validations:
+      required: true
   - type: input
     id: wallet_erc_20_support
     attributes:
       label: Does the wallet support importing or automatically querying and displaying ERC-20 tokens?
       description: Please provide documentation on how to import tokens into the wallet.
+    validations:
+      required: true
   - type: input
     id: wallet_eip_1559_support
     attributes:
       label: Does the wallet support EIP-1559 (type 2) transactions?
       description: Please provide information on the type of transactions this wallet supports.
+    validations:
+      required: true
+  - type: textarea
+    id: wallet_recovery_options
+    attributes:
+      label: Does the wallet have any recovery options?
+      description: Please provide any information on any recovery options for your wallet
+    validations:
+      required: true
   - type: markdown
     id: finance
     attributes:
@@ -243,11 +312,15 @@ body:
     attributes:
       label: Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?
       description: Please provide documentation on how a user is able to onboard and purchase crypto in the wallet.
+    validations:
+      required: true
   - type: input
     id: wallet_fiat_withdrawals
     attributes:
       label: Does the wallet support withdrawals to fiat?
       description: an a user cash out their crypto assets directly to a card or bank account? Please provide documentation.
+    validations:
+      required: true
   - type: markdown
     id: smart_contract
     attributes:
@@ -262,6 +335,13 @@ body:
     attributes:
       label: Does the wallet support social recovery?
       description: Please provide documentation on how users set up guardians and use social recovery for the wallet.
+  - type: input
+    id: wallet_bundled_transactions
+    attributes:
+      label: Does the wallet support bundled transactions?
+      description: Please provide any documentation on bundled transactions
+    validations:
+      required: true
   - type: markdown
     id: support
     attributes:
@@ -273,18 +353,24 @@ body:
       description: |
         If possible, provide a Telegram, Discord, or Twitter username.
         Please note that as a result of any future dispute the wallet may be temporarily removed from ethereum.org. Having a contact person allows lets us avoid this situation and resolve issues more quickly.
+    validations:
+      required: true
   - type: textarea
     id: wallet_support_team
     attributes:
       label: Does the wallet have a dedicated support team?
       description: |
         Where should we send users that are having issues?
         How fast is the support?
+    validations:
+      required: true
   - type: textarea
     id: wallet_educational_resources
     attributes:
       label: What educational resources/documentation do you provide to users?
       description: Please provide links to developer documentation, user documentation, and/or educational resources.
+    validations:
+      required: true
   - type: markdown
     id: extra
     attributes:
@@ -305,3 +391,7 @@ body:
           required: false
     validations:
       required: true
+  - type: markdown
+    id: removal
+    attributes:
+      value: "### A note on product removal \n Wallet providers are responsible for resubmitting their wallet information every 6 months to ensure validity and relavance of provided information (even if there are no changes to their product). If the product team fails to do so, ethereum.org reserves the right to remove the project from the page."

public/content/contributing/adding-wallets/index.md

@@ -13,7 +13,6 @@ Anyone is free to suggest adding a wallet on ethereum.org. If there's a wallet t
 Wallets are currently listed on:
 
 - [ethereum.org/wallets/find-wallet/](/wallets/find-wallet/)
-- [ethereum.org/wallets/](/wallets/)
 
 Wallets are rapidly changing in Ethereum. We've tried to create a fair framework for consideration on ethereum.org but the listing criteria will change and evolve over time.
 
@@ -26,6 +25,12 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework
 - **Worked on by an active team** - this helps to ensure quality and that a user will get support for their queries.
 - **Honest and accurate listing information** - it is expected that any suggested listings from projects come with honest and accurate information. Products that falsify listing information, such as declaring your product is “open source” when it is not, will be removed.
 - **Point of contact** - A point of contact for the wallet will greatly help us get accurate information when changes are made. This will keep updating ethereum.org manageable when gathering future information.
+- **EIP-1559 (type 2) transactions** - your wallet must support EIP-1559 (type 2) transactions.
+- **Good user experience** - While UX is subjective, if several core team members test the product and find it difficult to use, we reserve the right to reject the wallet and will instead provide useful suggestions to improve. This is done to protect our user base that is mostly comprised of beginners. 
+
+### Product removals {#product-removals}
+
+- **Updated information** - Wallet providers are responsible for resubmitting their wallet information every 6 months to ensure validity and relevance of provided information (even if there are no changes to their product). If the product team fails to do so, ethereum.org may remove the project from the page. 
 
 ### Other criteria: the nice-to-haves {#the-nice-to-haves}
 
@@ -45,7 +50,6 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework
 - **Customize gas fees** - your wallet allows users to customize their transaction gas fees (base fee, priority fee, max fee).
 - **ENS support** - your wallet allows users to send transactions to ENS names.
 - **ERC-20 support** - your wallet allows users to import ERC-20 token contracts, or automatically queries and displays ERC-20 tokens.
-- **EIP-1559 (type 2) transactions** - your wallet supports EIP-1559 (type 2) transactions.
 - **Buy crypto** - your wallet supports users directly purchasing and onboarding to crypto.
 - **Sell for fiat** - your wallet supports users selling and withdrawing to fiat directly to card or a bank account.
 - **Multisig** - your wallet supports multiple signatures to sign a transaction.