Skip to content

Commit b7f0154

Browse files
TylerAPfleddererTylerAPfledderer
committed
style: declare secondary styling for outline buttons in "primary/secondary" button pairs
1 parent bf62e40 commit b7f0154

File tree

7 files changed

+25
-9
lines changed

7 files changed

+25
-9
lines changed

‎src/components/PageHero.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ const PageHero: React.FC<IProps> = ({
100100
// global styles in `src/@chakra-ui/gatsby-plugin/styles.ts`
101101
<Wrap spacing={2} overflow="visible" sx={{ ul: { m: 0 } }}>
102102
{buttons.map((button, idx) => {
103+
const isSecondary = idx !== 0
103104
if (isButtonLink(button)) {
104105
return (
105106
<WrapItem key={idx}>
@@ -113,6 +114,7 @@ const PageHero: React.FC<IProps> = ({
113114
eventName: button.matomo.eventName,
114115
})
115116
}
117+
isSecondary={isSecondary}
116118
>
117119
{button.content}
118120
</ButtonLink>
@@ -133,6 +135,7 @@ const PageHero: React.FC<IProps> = ({
133135
eventName: button.matomo.eventName,
134136
})
135137
}
138+
isSecondary={isSecondary}
136139
>
137140
{button.content}
138141
</Button>

‎src/pages-conditional/what-is-ethereum.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ const WhatIsEthereumPage = ({
651651
<ButtonLink to="/smart-contracts/">
652652
<Translation id="page-what-is-ethereum-more-on-smart-contracts" />
653653
</ButtonLink>
654-
<ButtonLink to="/dapps/" variant="outline">
654+
<ButtonLink to="/dapps/" variant="outline" isSecondary>
655655
<Translation id="page-what-is-ethereum-explore-dapps" />
656656
</ButtonLink>
657657
</ButtonRow>
@@ -678,7 +678,7 @@ const WhatIsEthereumPage = ({
678678
<ButtonLink to="/eth/">
679679
<Translation id="page-what-is-ethereum-what-is-ether" />
680680
</ButtonLink>
681-
<ButtonLink to="/get-eth/" variant="outline">
681+
<ButtonLink to="/get-eth/" variant="outline" isSecondary>
682682
<Translation id="page-what-is-ethereum-get-eth" />
683683
</ButtonLink>
684684
</ButtonRow>
@@ -705,7 +705,7 @@ const WhatIsEthereumPage = ({
705705
<ButtonLink to="/energy-consumption/">
706706
<Translation id="page-what-is-ethereum-more-on-energy-consumption" />
707707
</ButtonLink>
708-
<ButtonLink to="/roadmap/merge/" variant="outline">
708+
<ButtonLink to="/roadmap/merge/" variant="outline" isSecondary>
709709
<Translation id="page-what-is-ethereum-the-merge-update" />
710710
</ButtonLink>
711711
</ButtonRow>

‎src/pages/bug-bounty.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ const BugBountiesPage = ({
460460
<StyledButton to="https://forms.gle/Gnh4gzGh66Yc3V7G8">
461461
<Translation id="page-upgrades-bug-bounty-submit" />
462462
</StyledButton>
463-
<StyledButton variant="outline" to="#rules">
463+
<StyledButton variant="outline" to="#rules" isSecondary>
464464
<Translation id="page-upgrades-bug-bounty-rules" />
465465
</StyledButton>
466466
</ButtonRow>

‎src/pages/community.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,11 @@ const CommunityPage = ({
324324
<ButtonLink to="/community/get-involved/#ethereum-jobs/">
325325
<Translation id="page-community-find-a-job" />
326326
</ButtonLink>
327-
<StyledButtonLink variant="outline" to="/community/grants/">
327+
<StyledButtonLink
328+
variant="outline"
329+
to="/community/grants/"
330+
isSecondary
331+
>
328332
<Translation id="page-community-explore-grants" />
329333
</StyledButtonLink>
330334
</ButtonRow>
@@ -370,6 +374,7 @@ const CommunityPage = ({
370374
<StyledButtonLink
371375
variant="outline"
372376
to="https://github.com/ethereum/ethereum-org-website/"
377+
isSecondary
373378
>
374379
<Translation id="page-community-contribute-secondary-button" />
375380
</StyledButtonLink>

‎src/pages/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ const HomePage = ({
359359
<ButtonLink to="/what-is-ethereum/">
360360
<Translation id="page-index-what-is-ethereum-button" />
361361
</ButtonLink>
362-
<ButtonLink to="/eth/" variant="outline">
362+
<ButtonLink to="/eth/" variant="outline" isSecondary>
363363
<Translation id="page-index-what-is-ethereum-secondary-button" />
364364
</ButtonLink>
365365
</ButtonLinkRow>
@@ -438,7 +438,7 @@ const HomePage = ({
438438
<ButtonLink to="/dapps/?category=technology">
439439
<Translation id="page-index-internet-button" />
440440
</ButtonLink>
441-
<ButtonLink to="/wallets/" variant="outline">
441+
<ButtonLink to="/wallets/" variant="outline" isSecondary>
442442
<Translation id="page-index-internet-secondary-button" />
443443
</ButtonLink>
444444
</ButtonLinkRow>
@@ -570,6 +570,7 @@ const HomePage = ({
570570
to="https://github.com/ethereum/ethereum-org-website"
571571
leftIcon={<Icon as={FaGithub} fontSize="2xl" />}
572572
variant="outline"
573+
isSecondary
573574
>
574575
GitHub
575576
</ButtonLink>

‎src/pages/run-a-node.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ const RunANodePage = ({ data }: PageProps<Queries.RunANodePageQuery>) => {
809809
>
810810
<Translation id="page-run-a-node-community-link-1" />
811811
</ButtonLink>
812-
<ButtonLink to="/community/online/" variant="outline">
812+
<ButtonLink to="/community/online/" variant="outline" isSecondary>
813813
<Translation id="page-run-a-node-community-link-2" />
814814
</ButtonLink>
815815
</ButtonContainer>

‎src/pages/stablecoins.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,7 @@ const StablecoinsPage = ({ data }: PageProps<Queries.StablecoinsPageQuery>) => {
505505
<ButtonLink
506506
variant="outline"
507507
to="https://kb.oasis.app/help/what-is-dai"
508+
isSecondary
508509
>
509510
<Translation id="page-stablecoins-dai-banner-learn-button" />
510511
</ButtonLink>
@@ -556,6 +557,7 @@ const StablecoinsPage = ({ data }: PageProps<Queries.StablecoinsPageQuery>) => {
556557
<ButtonLink
557558
variant="outline"
558559
to="https://www.coinbase.com/usdc"
560+
isSecondary
559561
>
560562
<Translation id="page-stablecoins-usdc-banner-learn-button" />
561563
</ButtonLink>
@@ -627,7 +629,12 @@ const StablecoinsPage = ({ data }: PageProps<Queries.StablecoinsPageQuery>) => {
627629
<ButtonLink to="/dapps/">
628630
<Translation id="page-stablecoins-explore-dapps" />
629631
</ButtonLink>
630-
<ButtonLink variant="outline" to="/defi/" whiteSpace="normal">
632+
<ButtonLink
633+
variant="outline"
634+
to="/defi/"
635+
whiteSpace="normal"
636+
isSecondary
637+
>
631638
<Translation id="page-stablecoins-more-defi-button" />
632639
</ButtonLink>
633640
</Flex>

0 commit comments

Comments
 (0)