Skip to content

Commit b8236bc

Browse files
committed
Merge branch 'dev' into ashiskumar-dev
2 parents e3d5e0f + 18b97ac commit b8236bc

File tree

15 files changed

+564
-114
lines changed

15 files changed

+564
-114
lines changed

.all-contributorsrc

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12015,6 +12015,24 @@
1201512015
"contributions": [
1201612016
"content"
1201712017
]
12018+
},
12019+
{
12020+
"login": "raxhvl",
12021+
"name": "rahul",
12022+
"avatar_url": "https://avatars.githubusercontent.com/u/10168946?v=4",
12023+
"profile": "https://github.com/raxhvl",
12024+
"contributions": [
12025+
"content"
12026+
]
12027+
},
12028+
{
12029+
"login": "professorabhay",
12030+
"name": "Abhay Gupta ",
12031+
"avatar_url": "https://avatars.githubusercontent.com/u/76243309?v=4",
12032+
"profile": "https://abhayporwals.live/",
12033+
"contributions": [
12034+
"content"
12035+
]
1201812036
}
1201912037
],
1202012038
"contributorsPerLine": 7,
Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
name: Check for non-English updates outside of Crowdin
2+
3+
on:
4+
pull_request:
5+
paths:
6+
- "public/content/translations/**/*.md"
7+
- "src/intl/**/*.json"
8+
- "!src/intl/en/**
9+
10+
jobs:
11+
check_branch_name:
12+
runs-on: ubuntu-latest
13+
steps:
14+
- name: Exit early if branch name contains 'crowdin'
15+
run: |
16+
if [[ "${{ github.head_ref }}" == *crowdin* ]]; then
17+
echo "Branch name contains 'crowdin', stopping workflow"
18+
exit 1
19+
fi
20+
21+
check_changes:
22+
needs: check_branch_name
23+
runs-on: ubuntu-latest
24+
outputs:
25+
all_changes_include_href: ${{ steps.check.outputs.all_changes_include_href }}
26+
steps:
27+
- name: Checkout code
28+
uses: actions/checkout@v2
29+
- name: Check changes
30+
id: check
31+
run: |
32+
git fetch origin ${{ github.base_ref }}
33+
DIFF=$(git diff --no-ext-diff --unified=0 origin/${{ github.base_ref }}..${{ github.head_ref }} -- 'public/content/translations/**/*.md' 'src/intl/**/*.json' '!src/intl/en/**' | grep -E -v '^[-+]href=')
34+
if [[ -z "$DIFF" ]]; then
35+
echo "ALL_CHANGES_INCLUDE_HREF=true" >> $GITHUB_ENV
36+
else
37+
echo "ALL_CHANGES_INCLUDE_HREF=false" >> $GITHUB_ENV
38+
fi
39+
echo "::set-output name=all_changes_include_href::$ALL_CHANGES_INCLUDE_HREF"
40+
41+
add_label_and_comment:
42+
needs: check_changes
43+
runs-on: ubuntu-latest
44+
steps:
45+
- name: Add label and comment
46+
uses: actions/github-script@v5
47+
with:
48+
github-token: ${{secrets.GITHUB_TOKEN}}
49+
script: |
50+
const prNumber = context.issue.number;
51+
const repo = context.repo;
52+
const prAuthor = context.payload.pull_request.user.login;
53+
const allChangesIncludeHref = '${{ needs.check_changes.outputs.all_changes_include_href }}' === 'true';
54+
const status = allChangesIncludeHref ? 'question ❓' : 'blocked 🛑';
55+
await github.rest.issues.addLabels({
56+
...repo,
57+
issue_number: prNumber,
58+
labels: [status, 'non-crowdin translation updates']
59+
});
60+
const commentWithoutHrefs = `This pull request contains changes to non-English content, which must also be handled through the Crowdin platform instead of only on GitHub.`
61+
const commentWithHrefs = `This pull request contains changes to non-English content files, which may also need to be handled through the Crowdin platform instead of only on GitHub.
62+
await github.rest.issues.createComment({
63+
...repo,
64+
issue_number: prNumber,
65+
body: `
66+
Thank you for your contribution, @${prAuthor}!
67+
68+
${allChangesIncludeHref ? commentWithHrefs : commentWithoutHrefs}
69+
70+
We value your suggestion, and for any non-English content updates we request that you check out [how to help us translate](https://ethereum.org/en/contributing/translation-program/#help-us-translate), and suggest these updates directly in [our Crowdin project](https://crowdin.com/project/ethereum-org) if possible, where they can be properly reviewed.
71+
72+
Please post here or join [our Discord](https://ethereum.org/discord) if you have questions!
73+
`
74+
});

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1840,6 +1840,10 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
18401840
<td align="center" valign="top" width="14.28%"><a href="https://github.com/ksdumont"><img src="https://avatars.githubusercontent.com/u/51958351?v=4?s=100" width="100px;" alt="Keith Dumont"/><br /><sub><b>Keith Dumont</b></sub></a><br /><a href="#content-ksdumont" title="Content">🖋</a></td>
18411841
<td align="center" valign="top" width="14.28%"><a href="https://github.com/ecabras"><img src="https://avatars.githubusercontent.com/u/126670074?v=4?s=100" width="100px;" alt="ecabras"/><br /><sub><b>ecabras</b></sub></a><br /><a href="#content-ecabras" title="Content">🖋</a></td>
18421842
</tr>
1843+
<tr>
1844+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/raxhvl"><img src="https://avatars.githubusercontent.com/u/10168946?v=4?s=100" width="100px;" alt="rahul"/><br /><sub><b>rahul</b></sub></a><br /><a href="#content-raxhvl" title="Content">🖋</a></td>
1845+
<td align="center" valign="top" width="14.28%"><a href="https://abhayporwals.live/"><img src="https://avatars.githubusercontent.com/u/76243309?v=4?s=100" width="100px;" alt="Abhay Gupta "/><br /><sub><b>Abhay Gupta </b></sub></a><br /><a href="#content-professorabhay" title="Content">🖋</a></td>
1846+
</tr>
18431847
</tbody>
18441848
</table>
18451849

public/content/community/language-resources/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ If you are bilingual and want to help us reach more people, you can also get inv
3232
- [Cointelegraph](http://cointelegraph.com.br/category/analysis) - Brazilian version of Cointelegraph, a major cryptocurrency news outlet
3333
- [Livecoins](http://www.livecoins.com.br/ethereum) - cryptocurrency news and tools
3434
- [Seudinheiro](http://www.seudinheiro.com/criptomoedas/) - cryptocurrency news and reports
35+
- [Modular Crypto](https://modularcrypto.xyz/) - cryptocurrency news and educational articles
3536

3637
**Education**
3738

public/content/developers/docs/evm/index.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@ description: An introduction to the Ethereum virtual machine and how it relates
44
lang: en
55
---
66

7-
The EVM’s physical instantiation can’t be described in the same way that one might point to a cloud or an ocean wave, but it does _exist_ as one single entity maintained by thousands of connected computers running an Ethereum client.
8-
9-
The Ethereum protocol itself exists solely for the purpose of keeping the continuous, uninterrupted, and immutable operation of this special state machine. It's the environment in which all Ethereum accounts and smart contracts live. At any given block in the chain, Ethereum has one and only one 'canonical' state, and the EVM is what defines the rules for computing a new valid state from block to block.
7+
The Ethereum Virtual Machine (EVM) is a decentralized virtual environment that executes code consistently and securely across all Ethereum nodes. Nodes run the EVM to execute smart contracts, using "[gas](/gas/)" to measure the computational effort required for [operations](/developers/docs/evm/opcodes/), ensuring efficient resource allocation and network security.
108

119
## Prerequisites {#prerequisites}
1210

public/content/developers/docs/standards/tokens/erc-4626/index.md

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ To better understand this page, we recommend you first read about [token standar
2727
#### asset {#asset}
2828

2929
```solidity
30-
function asset() public view returns (address)
30+
function asset() public view returns (address assetTokenAddress)
3131
```
3232

3333
This function returns the address of the underlying token used for the vault for accounting, depositing, withdrawing.
@@ -59,15 +59,15 @@ This function returns the amount of `assets` that would be exchanged by the vaul
5959
#### maxDeposit {#maxdeposit}
6060

6161
```solidity
62-
function maxDeposit(address receiver) public view returns (uint256)
62+
function maxDeposit(address receiver) public view returns (uint256 maxAssets)
6363
```
6464

6565
This function returns the maximum amount of underlying assets that can be deposited in a single [`deposit`](#deposit) call by the `receiver`.
6666

6767
#### previewDeposit {#previewdeposit}
6868

6969
```solidity
70-
function previewDeposit(uint256 assets) public view returns (uint256)
70+
function previewDeposit(uint256 assets) public view returns (uint256 shares)
7171
```
7272

7373
This function allows users to simulate the effects of their deposit at the current block.
@@ -83,15 +83,15 @@ This function deposits `assets` of underlying tokens into the vault and grants o
8383
#### maxMint {#maxmint}
8484

8585
```solidity
86-
function maxMint(address receiver) public view returns (uint256)
86+
function maxMint(address receiver) public view returns (uint256 maxShares)
8787
```
8888

8989
This function returns the maximum amount of shares that can be minted in a single [`mint`](#mint) call by the `receiver`.
9090

9191
#### previewMint {#previewmint}
9292

9393
```solidity
94-
function previewMint(uint256 shares) public view returns (uint256)
94+
function previewMint(uint256 shares) public view returns (uint256 assets)
9595
```
9696

9797
This function allows users to simulate the effects of their mint at the current block.
@@ -107,15 +107,15 @@ This function mints exactly `shares` vault shares to `receiver` by depositing `a
107107
#### maxWithdraw {#maxwithdraw}
108108

109109
```solidity
110-
function maxWithdraw(address owner) public view returns (uint256)
110+
function maxWithdraw(address owner) public view returns (uint256 maxAssets)
111111
```
112112

113113
This function returns the maximum amount of underlying assets that can be withdrawn from the `owner` balance with a single [`withdraw`](#withdraw) call.
114114

115115
#### previewWithdraw {#previewwithdraw}
116116

117117
```solidity
118-
function previewWithdraw(uint256 assets) public view returns (uint256)
118+
function previewWithdraw(uint256 assets) public view returns (uint256 shares)
119119
```
120120

121121
This function allows users to simulate the effects of their withdrawal at the current block.
@@ -131,15 +131,15 @@ This function burns `shares` from `owner` and send exactly `assets` token from t
131131
#### maxRedeem {#maxredeem}
132132

133133
```solidity
134-
function maxRedeem(address owner) public view returns (uint256)
134+
function maxRedeem(address owner) public view returns (uint256 maxShares)
135135
```
136136

137137
This function returns the maximum amount of shares that can be redeemed from the `owner` balance through a [`redeem`](#redeem) call.
138138

139139
#### previewRedeem {#previewredeem}
140140

141141
```solidity
142-
function previewRedeem(uint256 shares) public view returns (uint256)
142+
function previewRedeem(uint256 shares) public view returns (uint256 assets)
143143
```
144144

145145
This function allows users to simulate the effects of their redemption at the current block.
@@ -168,6 +168,10 @@ function balanceOf(address owner) public view returns (uint256)
168168

169169
Returns the total amount of vault shares the `owner` currently has.
170170

171+
### Map of the interface {#mapOfTheInterface}
172+
173+
![Map of the ERC-4626 interface](./map-of-erc-4626.png)
174+
171175
### Events {#events}
172176

173177
#### Deposit Event
70.4 KB
Loading

public/content/enterprise/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ Some collaborative efforts to make Ethereum enterprise friendly have been made b
7171
- [Infura](https://infura.io/) - _scalable API access to the Ethereum and IPFS networks_
7272
- [Kaleido](https://kaleido.io/) - _an enterprise-focused development platform that offers simplified blockchain and digital asset applications_
7373
- [NodeReal](https://nodereal.io/) - _provides scalable blockchain infrastructure and API services provider for the Web3 ecosystem_
74+
- [Moralis](http://moralis.io/) - _enterprise grade APIs and Nodes with a SOC2 type 2 certification_
7475
- [Provide](https://provide.services/) - _enterprise zero-knowledge middleware_
7576
- [QuickNode](https://www.quicknode.com/) - _provides reliable and fast nodes with high-level APIs like NFT API, Token API, etc., while delivering a unified product suite and enterprise-grade solutions_
7677
- [Tenderly](https://tenderly.co) - _a Web3 development platform that provides debugging, observability, and infrastructure building blocks for developing, testing, monitoring, and operating smart contracts_

src/components/Buttons/ButtonLink.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const ButtonLink = ({ customEventOptions, ...props }: ButtonLinkProps) => {
1212
const handleClick = () => {
1313
customEventOptions && trackCustomEvent(customEventOptions)
1414
}
15+
1516
return (
1617
<Button as={BaseLink} activeStyle={{}} {...props} onClick={handleClick} />
1718
)

src/components/FindWallet/WalletTable/index.tsx

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -330,14 +330,6 @@ const WalletTable = ({
330330
})
331331
}
332332

333-
const handleWalletWebsiteClick = (walletName: string) => {
334-
trackCustomEvent({
335-
eventCategory: "WalletExternalLinkList",
336-
eventAction: "Tap main button",
337-
eventName: `${walletName}`,
338-
})
339-
}
340-
341333
return (
342334
<WalletContainer
343335
key={wallet.key}
@@ -350,10 +342,7 @@ const WalletTable = ({
350342
}}
351343
onClick={(e) => {
352344
// Prevent expanding the wallet more info section when clicking on the "Visit website" button
353-
if (
354-
(e.target as HTMLElement).matches("a, a svg")
355-
)
356-
return
345+
if ((e.target as HTMLElement).matches("a, a svg")) return
357346
showMoreInfo(wallet)
358347
}}
359348
>
@@ -393,7 +382,11 @@ const WalletTable = ({
393382
{hasPersonasLabels && (
394383
<Flex gap={1.5} wrap="wrap">
395384
{walletPersonas.map((persona) => (
396-
<Tag key={persona} label={t(persona)} variant="highContrast" />
385+
<Tag
386+
key={persona}
387+
label={t(persona)}
388+
variant="highContrast"
389+
/>
397390
))}
398391
</Flex>
399392
)}
@@ -445,9 +438,11 @@ const WalletTable = ({
445438
w="auto"
446439
isExternal
447440
size="sm"
448-
onClick={() =>
449-
handleWalletWebsiteClick(wallet.name)
450-
}
441+
customEventOptions={{
442+
eventCategory: "WalletExternalLinkList",
443+
eventAction: "Tap main button",
444+
eventName: `${wallet.name}`,
445+
}}
451446
>
452447
{t("page-find-wallet-visit-website")}
453448
</ButtonLink>
@@ -474,7 +469,11 @@ const WalletTable = ({
474469
w="100%"
475470
isExternal
476471
size="sm"
477-
onClick={() => handleWalletWebsiteClick(wallet.name)}
472+
customEventOptions={{
473+
eventCategory: "WalletExternalLinkList",
474+
eventAction: "Tap main button",
475+
eventName: `${wallet.name}`,
476+
}}
478477
>
479478
{t("page-find-wallet-visit-website")}
480479
</ButtonLink>

0 commit comments

Comments
 (0)