Skip to content

Commit d0c4fae

Browse files
nhsznhsz
authored
Merge pull request #11333 from TylerAPfledderer/style/secondary-style-outline-in-groups
style: declare secondary styling for outline buttons in "primary/secondary" button pairs
2 parents 7067254 + 8d32733 commit d0c4fae

File tree

7 files changed

+25
-9
lines changed

7 files changed

+25
-9
lines changed

‎src/components/PageHero.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ const PageHero = ({
9999
{buttons && (
100100
<Wrap spacing={2} overflow="visible" sx={{ ul: { m: 0 } }}>
101101
{buttons.map((button, idx) => {
102+
const isSecondary = idx !== 0
102103
if (isButtonLink(button)) {
103104
return (
104105
<WrapItem key={idx}>
@@ -112,6 +113,7 @@ const PageHero = ({
112113
eventName: button.matomo.eventName,
113114
})
114115
}
116+
isSecondary={isSecondary}
115117
>
116118
{button.content}
117119
</ButtonLink>
@@ -132,6 +134,7 @@ const PageHero = ({
132134
eventName: button.matomo.eventName,
133135
})
134136
}
137+
isSecondary={isSecondary}
135138
>
136139
{button.content}
137140
</Button>

‎src/pages/bug-bounty.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@ const BugBountiesPage = () => {
470470
<StyledButton to="https://forms.gle/Gnh4gzGh66Yc3V7G8">
471471
{t("page-upgrades-bug-bounty-submit")}
472472
</StyledButton>
473-
<StyledButton variant="outline" to="#rules">
473+
<StyledButton variant="outline" to="#rules" isSecondary>
474474
{t("page-upgrades-bug-bounty-rules")}
475475
</StyledButton>
476476
</ButtonRow>

‎src/pages/community.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,11 @@ const CommunityPage = () => {
338338
<ButtonLink to="/community/get-involved/#ethereum-jobs/">
339339
{t("page-community-find-a-job")}
340340
</ButtonLink>
341-
<StyledButtonLink variant="outline" to="/community/grants/">
341+
<StyledButtonLink
342+
variant="outline"
343+
to="/community/grants/"
344+
isSecondary
345+
>
342346
{t("page-community-explore-grants")}
343347
</StyledButtonLink>
344348
</ButtonRow>
@@ -382,6 +386,7 @@ const CommunityPage = () => {
382386
<StyledButtonLink
383387
variant="outline"
384388
to="https://github.com/ethereum/ethereum-org-website/"
389+
isSecondary
385390
>
386391
{t("page-community-contribute-secondary-button")}
387392
</StyledButtonLink>

‎src/pages/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ const HomePage = ({
412412
<ButtonLink to="/what-is-ethereum/">
413413
<Translation id="page-index:page-index-what-is-ethereum-button" />
414414
</ButtonLink>
415-
<ButtonLink to="/eth/" variant="outline">
415+
<ButtonLink to="/eth/" variant="outline" isSecondary>
416416
<Translation id="page-index:page-index-what-is-ethereum-secondary-button" />
417417
</ButtonLink>
418418
</ButtonLinkRow>
@@ -491,7 +491,7 @@ const HomePage = ({
491491
<ButtonLink to="/dapps/?category=technology">
492492
<Translation id="page-index:page-index-internet-button" />
493493
</ButtonLink>
494-
<ButtonLink to="/wallets/" variant="outline">
494+
<ButtonLink to="/wallets/" variant="outline" isSecondary>
495495
<Translation id="page-index:page-index-internet-secondary-button" />
496496
</ButtonLink>
497497
</ButtonLinkRow>
@@ -626,6 +626,7 @@ const HomePage = ({
626626
to="https://github.com/ethereum/ethereum-org-website"
627627
leftIcon={<Icon as={FaGithub} fontSize="2xl" />}
628628
variant="outline"
629+
isSecondary
629630
>
630631
GitHub
631632
</ButtonLink>

‎src/pages/run-a-node.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,7 @@ const RunANodePage = () => {
802802
>
803803
{t("page-run-a-node-community-link-1")}
804804
</ButtonLink>
805-
<ButtonLink to="/community/online/" variant="outline">
805+
<ButtonLink to="/community/online/" variant="outline" isSecondary>
806806
{t("page-run-a-node-community-link-2")}
807807
</ButtonLink>
808808
</ButtonContainer>

‎src/pages/stablecoins.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,7 @@ const StablecoinsPage = ({ markets, marketsHasError }) => {
522522
<ButtonLink
523523
variant="outline"
524524
to="https://kb.oasis.app/help/what-is-dai"
525+
isSecondary
525526
>
526527
{t("page-stablecoins-dai-banner-learn-button")}
527528
</ButtonLink>
@@ -572,6 +573,7 @@ const StablecoinsPage = ({ markets, marketsHasError }) => {
572573
<ButtonLink
573574
variant="outline"
574575
to="https://www.coinbase.com/usdc"
576+
isSecondary
575577
>
576578
{t("page-stablecoins-usdc-banner-learn-button")}
577579
</ButtonLink>
@@ -640,7 +642,12 @@ const StablecoinsPage = ({ markets, marketsHasError }) => {
640642
<ButtonLink to="/dapps/">
641643
{t("page-stablecoins-explore-dapps")}
642644
</ButtonLink>
643-
<ButtonLink variant="outline" to="/defi/" whiteSpace="normal">
645+
<ButtonLink
646+
variant="outline"
647+
to="/defi/"
648+
whiteSpace="normal"
649+
isSecondary
650+
>
644651
{t("page-stablecoins-more-defi-button")}
645652
</ButtonLink>
646653
</Flex>

‎src/pages/what-is-ethereum.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ const WhatIsEthereumPage = ({
624624
<ButtonLink to="/smart-contracts/">
625625
{t("page-what-is-ethereum-more-on-smart-contracts")}
626626
</ButtonLink>
627-
<ButtonLink to="/dapps/" variant="outline">
627+
<ButtonLink to="/dapps/" variant="outline" isSecondary>
628628
{t("page-what-is-ethereum-explore-dapps")}
629629
</ButtonLink>
630630
</ButtonRow>
@@ -645,7 +645,7 @@ const WhatIsEthereumPage = ({
645645
<ButtonLink to="/eth/">
646646
{t("page-what-is-ethereum-what-is-ether")}
647647
</ButtonLink>
648-
<ButtonLink to="/get-eth/" variant="outline">
648+
<ButtonLink to="/get-eth/" variant="outline" isSecondary>
649649
{t("page-what-is-ethereum-get-eth")}
650650
</ButtonLink>
651651
</ButtonRow>
@@ -668,7 +668,7 @@ const WhatIsEthereumPage = ({
668668
<ButtonLink to="/energy-consumption/">
669669
{t("page-what-is-ethereum-more-on-energy-consumption")}
670670
</ButtonLink>
671-
<ButtonLink to="/roadmap/merge/" variant="outline">
671+
<ButtonLink to="/roadmap/merge/" variant="outline" isSecondary>
672672
{t("page-what-is-ethereum-the-merge-update")}
673673
</ButtonLink>
674674
</ButtonRow>

0 commit comments

Comments
 (0)