fix: use github history for last app page edit

make date required for last commit from github data; 0 date fallback from crowdin contributor data

Author: wackerow

app/[locale]/get-eth/page.tsx

@@ -10,7 +10,7 @@ import type { CommitHistory, Lang } from "@/lib/types"
 import I18nProvider from "@/components/I18nProvider"
 
 import { getAppPageContributorInfo } from "@/lib/utils/contributors"
-import { getLastModifiedDateByPath } from "@/lib/utils/gh"
+import { getLastGitCommitDateByPath } from "@/lib/utils/gh"
 import { getMetadata } from "@/lib/utils/metadata"
 import { getRequiredNamespacesForPage } from "@/lib/utils/translations"
 
@@ -27,7 +27,7 @@ export default async function Page({
 
   setRequestLocale(locale)
 
-  const lastDataUpdateDate = getLastModifiedDateByPath(
+  const lastDataUpdateDate = getLastGitCommitDateByPath(
     "src/data/exchangesByCountry.ts"
   )
 

src/layouts/stories/ContentLayout.stories.tsx

@@ -63,8 +63,18 @@ export const ContentLayout: StoryObj<typeof meta> = {
     },
     maxDepth: 2,
     contributors: [
-      { login: "github", avatar_url: "/", html_url: "https://github.com" },
-      { login: "crowdin", avatar_url: "/", html_url: "https://crowdin.com" },
+      {
+        login: "github",
+        avatar_url: "/",
+        html_url: "https://github.com",
+        date: "2025-04-20T12:00:00.000Z",
+      },
+      {
+        login: "crowdin",
+        avatar_url: "/",
+        html_url: "https://crowdin.com",
+        date: "2025-04-20T12:00:00.000Z",
+      },
     ],
     lastEditLocaleTimestamp: "MM DD, YY",
     heroSection: (

src/lib/types.ts

@@ -395,7 +395,7 @@ export type FileContributor = {
   login: string
   avatar_url: string
   html_url: string
-  date?: string
+  date: string
 }
 
 type FilePath = string

src/lib/utils/contributors.ts

@@ -89,7 +89,7 @@ export const getAppPageContributorInfo = async (
       index === self.findIndex((t) => t.login === contributor.login)
   )
 
-  const latestCommitDate = getAppPageLastCommitDate(pagePath)
+  const latestCommitDate = getAppPageLastCommitDate(gitHubContributors)
   const lastEditLocaleTimestamp = getLocaleTimestamp(locale, latestCommitDate)
 
   if (!uniqueGitHubContributors.length || !lastEditLocaleTimestamp) {

src/lib/utils/crowdin.ts

@@ -30,4 +30,5 @@ export const convertToFileContributorFromCrowdin = (
     login: username,
     avatar_url: avatarUrl,
     html_url: `https://crowdin.com/profile/${username}`,
+    date: new Date(0).toString(),
   }))

src/lib/utils/gh.ts

@@ -4,6 +4,8 @@ import { join } from "path"
 
 import { CONTENT_DIR, DEFAULT_LOCALE, TRANSLATIONS_DIR } from "@/lib/constants"
 
+import { FileContributor } from "../types"
+
 const getGitLogFromPath = (path: string): string => {
   // git command to show file last commit info
   const gitCommand = `git log -1 -- ${path}`
@@ -25,17 +27,20 @@ const extractDateFromGitLogInfo = (logInfo: string): string => {
   }
 }
 
-export const getAppPageLastCommitDate = (slug: string): string => {
-  const appPagePaths = [
-    join("app/[locale]", slug, "page.tsx"),
-    join("app/[locale]", slug, "_components", `${slug.split("/").pop()}.tsx`),
-  ]
-  const logs = appPagePaths.map(getGitLogFromPath)
-  const dates = logs.map(extractDateFromGitLogInfo)
-  const latestCommitDate = dates.reduce((a, b) =>
-    new Date(a) > new Date(b) ? a : b
-  )
-  return latestCommitDate
+export const getAppPageLastCommitDate = (
+  gitHubContributors: FileContributor[]
+) =>
+  gitHubContributors
+    .reduce((latest, contributor) => {
+      const commitDate = new Date(contributor.date)
+      return commitDate > latest ? commitDate : latest
+    }, new Date(0))
+    .toString()
+
+export const getLastGitCommitDateByPath = (path: string): string => {
+  if (!fs.existsSync(path)) throw new Error(`File not found: ${path}`)
+  const logInfo = getGitLogFromPath(path)
+  return extractDateFromGitLogInfo(logInfo)
 }
 
 // This util filters the git log to get the file last commit info, and then the commit date (last update)
@@ -55,14 +60,7 @@ export const getMarkdownLastCommitDate = (
     filePath = join(TRANSLATIONS_DIR, locale, slug, "index.md")
   }
 
-  const logInfo = getGitLogFromPath(filePath)
-  return extractDateFromGitLogInfo(logInfo)
-}
-
-export const getLastModifiedDateByPath = (path: string): string => {
-  if (!fs.existsSync(path)) throw new Error(`File not found: ${path}`)
-  const logInfo = getGitLogFromPath(path)
-  return extractDateFromGitLogInfo(logInfo)
+  return getLastGitCommitDateByPath(filePath)
 }
 
 const LABELS_TO_SEARCH = [