apply suggestions from code review

fix missing i18n string for Bug Bounty breadcrumb text

Author: wackerow

src/components/Breadcrumbs/index.tsx

@@ -38,7 +38,7 @@ const Breadcrumbs = ({
   startDepth = 0,
   ...props
 }: BreadcrumbsProps) => {
-  const { t } = useTranslation("page-index")
+  const { t } = useTranslation(["common", "page-index"])
   const { locale, asPath } = useRouter()
 
   const hasHome = asPath !== "/"
@@ -57,12 +57,10 @@ const Breadcrumbs = ({
         ]
       : []),
     ,
-    ...sliced.map((path, idx) => {
-      return {
-        fullPath: slugChunk.slice(0, idx + 2).join("/") + "/",
-        text: t(path), // TODO: fix i18n strings for path breadcrumbs
-      }
-    }),
+    ...sliced.map((path, idx) => ({
+      fullPath: slugChunk.slice(0, idx + 2).join("/") + "/",
+      text: t(path),
+    })),
   ]
     .filter((item): item is Crumb => !!item)
     .slice(startDepth)

src/components/Leaderboard.tsx

@@ -14,7 +14,7 @@ import {
 import Emoji from "@/components/Emoji"
 import { BaseLink } from "@/components/Link"
 
-import { GITHUB_ROOT } from "@/lib/constants"
+import { GITHUB_URL } from "@/lib/constants"
 
 import { useRtlFlip } from "@/hooks/useRtlFlip"
 
@@ -60,7 +60,7 @@ const Leaderboard = ({ content, limit = 100 }: LeaderboardProps) => {
         .map(({ name, username, score }, idx) => {
           const hasGitHub = !!username
           const avatarImg =
-            GITHUB_ROOT + (username || "random") + ".png?size=40"
+            GITHUB_URL + (username || "random") + ".png?size=40"
           const avatarAlt = hasGitHub ? `${username} GitHub avatar` : ""
 
           let emoji: string | null = null
@@ -104,7 +104,7 @@ const Leaderboard = ({ content, limit = 100 }: LeaderboardProps) => {
                 <Flex flex="1 1 75%" direction="column" me={8}>
                   <LinkOverlay
                     as={BaseLink}
-                    href={hasGitHub ? `${GITHUB_ROOT}${username}` : "#"}
+                    href={hasGitHub ? `${GITHUB_URL}${username}` : "#"}
                     textDecor="none"
                     color="text"
                     hideArrow

src/intl/en/common.json

@@ -15,6 +15,7 @@
   "aria-toggle-menu-button": "Toggle menu button",
   "beacon-chain": "Beacon Chain",
   "bridges": "Blockchain bridges",
+  "bug-bounty": "Bug bounty",
   "clear": "Clear",
   "close": "Close",
   "community": "Community",

src/lib/constants.ts

@@ -25,7 +25,7 @@ export const CONTENT_IMAGES_MAX_WIDTH = 800
 export const GITHUB_BASE_API =
   "https://api.github.com/repos/ethereum/ethereum-org-website"
 export const GITHUB_COMMITS_URL = GITHUB_BASE_API + "/commits"
-export const GITHUB_ROOT = `https://github.com/`
+export const GITHUB_URL = `https://github.com/`
 
 // Quiz Hub
 export const PROGRESS_BAR_GAP = "4px"