fix: clean up paths and id logic

Author: wackerow

.github/workflows/crowdin-ci.yml

@@ -44,17 +44,16 @@ jobs:
       # Build translations
       - name: Build Crowdin project
         id: build-crowdin
-        run: npx ts-node -O '{"module":"commonjs"}' ./src/scripts/crowdin/translations/triggerBuild.ts
-
-      - name: Load buildId
-        run: echo "BUILD_ID=$(cat output.env | grep buildId | cut -d'=' -f2)" >> $GITHUB_ENV
+        run: |
+          npx ts-node -O '{"module":"commonjs"}' ./src/scripts/crowdin/translations/triggerBuild.ts;
+          grep BUILD_ID output.env >> $GITHUB_ENV;
 
       - name: Await latest build to finish
         run: npx ts-node -O '{"module":"commonjs"}' ./src/scripts/crowdin/translations/awaitLatestBuild.ts
 
       - name: Check build success
         run: |
-          if [ "$(grep BUILD_SUCCESS output.env | cut -d'=' -f2)" = "false" ]; then
+          if [ $(grep BUILD_SUCCESS output.env | cut -d'=' -f2) = false ]; then
             echo "Build timed out, exiting"
             exit 1
           fi

src/scripts/crowdin/translations/constants.ts

@@ -1,15 +1,15 @@
-import { resolve } from "path"
+import { join } from "path"
 
 export const DOT_CROWDIN = ".crowdin"
 
 export const CROWDIN_DATA_DIR = "src/data/crowdin"
 export const SAVE_FILE = "download.zip"
-export const FILE_PATH = resolve(CROWDIN_DATA_DIR, SAVE_FILE)
+export const FILE_PATH = join(CROWDIN_DATA_DIR, SAVE_FILE)
 
 export const SUMMARY_SAVE_FILE = "import-summary.json"
-export const SUMMARY_PATH = resolve(CROWDIN_DATA_DIR, SUMMARY_SAVE_FILE)
+export const SUMMARY_PATH = join(CROWDIN_DATA_DIR, SUMMARY_SAVE_FILE)
 
 export const BUCKETS_IMPORTED_FILE = "buckets-imported.json"
-export const BUCKETS_PATH = resolve(CROWDIN_DATA_DIR, BUCKETS_IMPORTED_FILE)
+export const BUCKETS_PATH = join(CROWDIN_DATA_DIR, BUCKETS_IMPORTED_FILE)
 
 export const APPROVAL_THRESHOLD = 100

src/scripts/crowdin/translations/triggerBuild.ts

@@ -16,7 +16,7 @@ async function triggerBuild() {
       `Build ${isAlreadyFinished ? "already finished" : "triggered"} id:`,
       id
     )
-    writeFileSync(OUTPUT_PATH, `buildId=${id}\n`, { flag: "a" })
+    writeFileSync(OUTPUT_PATH, `BUILD_ID=${id}\n`, { flag: "a" })
   } catch (error: unknown) {
     console.error((error as Error).message)
   }