Skip to content

Commit fe11d72

Browse files
authored
Merge pull request #14614 from paschaldev/dev
Fix broken SVG assets icons path by using absolute URL from origin
2 parents 55e72c8 + 2058b25 commit fe11d72

File tree

1 file changed

+30
-25
lines changed

1 file changed

+30
-25
lines changed

src/pages/assets.tsx

Lines changed: 30 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,11 @@ export const getStaticProps = (async ({ locale }) => {
117117
}) satisfies GetStaticProps<BasePageProps>
118118

119119
const AssetsPage = () => {
120+
// Ignore locale in the URL for SVG path in public directory to fix broken link
121+
// SVG path changes from /en/images => /images
122+
const svgPathFromOrigin =
123+
typeof window !== `undefined` ? window.location.origin : ""
124+
120125
const { t } = useTranslation("page-assets")
121126
const assetPageHeroImage = useColorModeValue(
122127
ethDiamondBlack,
@@ -364,73 +369,73 @@ const AssetsPage = () => {
364369
title={t("page-assets-eth-diamond-glyph")}
365370
alt={t("page-assets-eth-diamond-glyph")}
366371
image={ethDiamondGlyph}
367-
svgUrl="/images/assets/svgs/eth-diamond-glyph.svg"
372+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-glyph.svg`}
368373
/>
369374
<AssetDownload
370375
title={t("page-assets-eth-diamond-gray")}
371376
alt={t("page-assets-eth-diamond-gray")}
372377
image={ethDiamondBlack}
373-
svgUrl="/images/assets/svgs/eth-diamond-black.svg"
378+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-black.svg`}
374379
/>
375380
<AssetDownload
376381
title={t("page-assets-eth-diamond-color")}
377382
alt={t("page-assets-eth-diamond-color")}
378383
image={ethDiamondColor}
379-
svgUrl="/images/assets/svgs/eth-diamond-rainbow.svg"
384+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-rainbow.svg`}
380385
/>
381386
</Row>
382387
<Row>
383388
<AssetDownload
384389
title={t("page-assets-eth-diamond-purple")}
385390
alt={t("page-assets-eth-diamond-purple")}
386391
image={ethDiamondPurple}
387-
svgUrl="/images/assets/svgs/eth-diamond-purple.svg"
392+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-purple.svg`}
388393
/>
389394
<AssetDownload
390395
title={t("page-assets-eth-diamond-colored")}
391396
alt={t("page-assets-eth-diamond-colored")}
392397
image={ethGlyphColored}
393-
svgUrl="/images/assets/svgs/eth-glyph-colored.svg"
398+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-glyph-colored.svg`}
394399
/>
395400
</Row>
396401
<Row>
397402
<AssetDownload
398403
title={t("page-assets-eth-logo-portrait-gray")}
399404
alt={t("page-assets-eth-logo-portrait-gray")}
400405
image={ethPortraitBlack}
401-
svgUrl="/images/assets/svgs/ethereum-logo-portrait-black.svg "
406+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-portrait-black.svg `}
402407
/>
403408
<AssetDownload
404409
title={t("page-assets-eth-logo-landscape-gray")}
405410
alt={t("page-assets-eth-logo-landscape-gray")}
406411
image={ethLandscapeBlack}
407-
svgUrl="/images/assets/svgs/ethereum-logo-landscape-black.svg"
412+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-landscape-black.svg`}
408413
/>
409414
<AssetDownload
410415
title={t("page-assets-eth-wordmark-gray")}
411416
alt={t("page-assets-eth-wordmark-gray")}
412417
image={ethWordmarkBlack}
413-
svgUrl="/images/assets/svgs/ethereum-wordmark-black.svg"
418+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-wordmark-black.svg`}
414419
/>
415420
</Row>
416421
<Row>
417422
<AssetDownload
418423
title={t("page-assets-eth-logo-portrait-purple")}
419424
alt={t("page-assets-eth-logo-portrait-purple")}
420425
image={ethPortraitPurple}
421-
svgUrl="/images/assets/svgs/ethereum-logo-portrait-purple.svg"
426+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-portrait-purple.svg`}
422427
/>
423428
<AssetDownload
424429
title={t("page-assets-eth-logo-landscape-purple")}
425430
alt={t("page-assets-eth-logo-landscape-purple")}
426431
image={ethLandscapePurple}
427-
svgUrl="/images/assets/svgs/ethereum-logo-landscape-purple.svg"
432+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-landscape-purple.svg`}
428433
/>
429434
<AssetDownload
430435
title={t("page-assets-eth-wordmark-purple")}
431436
alt={t("page-assets-eth-wordmark-purple")}
432437
image={ethWordmarkPurple}
433-
svgUrl="/images/assets/svgs/ethereum-wordmark-purple-purple.svg"
438+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-wordmark-purple-purple.svg`}
434439
/>
435440
</Row>
436441
<H3>{t("page-assets-page-assets-solid-background")}</H3>
@@ -439,19 +444,19 @@ const AssetsPage = () => {
439444
title={t("page-assets-eth-diamond-white")}
440445
alt={t("page-assets-eth-diamond-white")}
441446
image={ethDiamondBlackWhite}
442-
svgUrl="/images/assets/svgs/eth-diamond-black-white.svg"
447+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-black-white.svg`}
443448
/>
444449
<AssetDownload
445450
title={t("page-assets-eth-diamond-gray")}
446451
alt={t("page-assets-eth-diamond-gray")}
447452
image={ethDiamondBlackGray}
448-
svgUrl="/images/assets/svgs/eth-diamond-black-gray.svg"
453+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-black-gray.svg`}
449454
/>
450455
<AssetDownload
451456
title={t("page-assets-eth-diamond-purple")}
452457
alt={t("page-assets-eth-diamond-purple")}
453458
image={ethDiamondPurplePurple}
454-
svgUrl="/images/assets/svgs/eth-diamond-purple-purple.svg"
459+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-purple-purple.svg`}
455460
/>
456461
</Row>
457462

@@ -460,67 +465,67 @@ const AssetsPage = () => {
460465
title={t("page-assets-eth-diamond-white")}
461466
alt={t("page-assets-eth-diamond-white")}
462467
image={ethDiamondPurpleWhite}
463-
svgUrl="/images/assets/svgs/eth-diamond-purple-white.svg"
468+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-purple-white.svg`}
464469
/>
465470
<AssetDownload
466471
title={t("page-assets-eth-diamond-white")}
467472
alt={t("page-assets-eth-diamond-white")}
468473
image={ethDiamondPurpleWhite}
469-
svgUrl="/images/assets/svgs/eth-diamond-purple-white.svg"
474+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/eth-diamond-purple-white.svg`}
470475
/>
471476
</Row>
472477
<Row>
473478
<AssetDownload
474479
title={t("page-assets-eth-logo-portrait-gray")}
475480
alt={t("page-assets-eth-logo-portrait-gray")}
476481
image={ethPortraitBlackGray}
477-
svgUrl="/images/assets/svgs/ethereum-logo-portrait-black-gray.svg"
482+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-portrait-black-gray.svg`}
478483
/>
479484
<AssetDownload
480485
title={t("page-assets-eth-logo-landscape-gray")}
481486
alt={t("page-assets-eth-logo-landscape-gray")}
482487
image={ethLandscapeBlackGray}
483-
svgUrl="/images/assets/svgs/ethereum-logo-landscape-black-gray.svg"
488+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-landscape-black-gray.svg`}
484489
/>
485490
<AssetDownload
486491
title={t("page-assets-eth-wordmark-gray")}
487492
alt={t("page-assets-eth-wordmark-gray")}
488493
image={ethWordmarkBlackGray}
489-
svgUrl="/images/assets/svgs/ethereum-wordmark-black-gray.svg"
494+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-wordmark-black-gray.svg`}
490495
/>
491496
</Row>
492497
<Row>
493498
<AssetDownload
494499
title={t("page-assets-eth-logo-portrait-purple")}
495500
alt={t("page-assets-eth-logo-portrait-purple")}
496501
image={ethPortraitPurplePurple}
497-
svgUrl="/images/assets/svgs/ethereum-logo-portrait-purple-purple.svg"
502+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-portrait-purple-purple.svg`}
498503
/>
499504
<AssetDownload
500505
title={t("page-assets-eth-logo-landscape-purple")}
501506
alt={t("page-assets-eth-logo-landscape-purple")}
502507
image={ethLandscapePurplePurple}
503-
svgUrl="/images/assets/svgs/ethereum-logo-landscape-purple-purple.svg"
508+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-landscape-purple-purple.svg`}
504509
/>
505510
<AssetDownload
506511
title={t("page-assets-eth-wordmark-purple")}
507512
alt={t("page-assets-eth-wordmark-purple")}
508513
image={ethWordmarkPurplePurple}
509-
svgUrl="/images/assets/svgs/ethereum-wordmark-purple-purple.svg"
514+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-wordmark-purple-purple.svg`}
510515
/>
511516
</Row>
512517
<Row>
513518
<AssetDownload
514519
title={t("page-assets-eth-logo-landscape-white")}
515520
alt={t("page-assets-eth-logo-landscape-white")}
516521
image={ethLandscapePurpleWhite}
517-
svgUrl="/images/assets/svgs/ethereum-logo-landscape-purple-white.svg"
522+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-logo-landscape-purple-white.svg`}
518523
/>
519524
<AssetDownload
520525
title={t("page-assets-eth-wordmark-white")}
521526
alt={t("page-assets-eth-wordmark-white")}
522527
image={ethWordmarkPurpleWhite}
523-
svgUrl="/images/assets/svgs/ethereum-wordmark-purple-white.svg"
528+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/ethereum-wordmark-purple-white.svg`}
524529
/>
525530
</Row>
526531
<H2 id="historical-illustrations">{t("page-assets-illustrations")}</H2>
@@ -534,7 +539,7 @@ const AssetsPage = () => {
534539
title={t("page-assets-merge-panda")}
535540
alt={t("page-assets-merge-panda")}
536541
image={mergePanda}
537-
svgUrl="/images/assets/svgs/merge-panda.svg"
542+
svgUrl={`${svgPathFromOrigin}/images/assets/svgs/merge-panda.svg`}
538543
/>
539544
</Row>
540545
</MainArticle>

0 commit comments

Comments
 (0)