Skip to content

feat: upload dev tools images to s3 on trigger task#17723

Merged
pettinarip merged 1 commit intodevfrom
dev-tools-images
Mar 6, 2026
Merged

feat: upload dev tools images to s3 on trigger task#17723
pettinarip merged 1 commit intodevfrom
dev-tools-images

Conversation

@wackerow
Copy link
Member

@wackerow wackerow commented Mar 6, 2026

Summary

  • Upload developer tool images (thumbnails and banners) to S3 during the trigger.dev fetch task
  • Follows the same pattern already used by fetchEvents for event images
  • Prevents hotlinking external image sources by re-hosting on our S3 bucket

Test plan

  • Ran fetch-developer-tools trigger task locally -- all 226 tools processed
  • Confirmed S3 uploads for both tools/thumbnails/ and tools/banners/ prefixes
  • Verified deduplication works on re-run (only previously failed uploads were retried)

Todo

        { protocol: "https", hostname: "storage.googleapis.com" },
        { protocol: "https", hostname: "cdn.charmverse.io" },
        { protocol: "https", hostname: "ethwingman.com" },
        { protocol: "https", hostname: "eth-mcp.dev" },

(Non-blocking todo)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link

netlify bot commented Mar 6, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 881c772
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69aa21cf0c0b8300089dd75f
😎 Deploy Preview https://deploy-preview-17723.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 59 (🔴 down 1 from production)
Accessibility: 94 (🟢 up 1 from production)
Best Practices: 100 (no change from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pettinarip pettinarip merged commit 31a81de into dev Mar 6, 2026
8 checks passed
@pettinarip pettinarip deleted the dev-tools-images branch March 6, 2026 16:04
@wackerow wackerow restored the dev-tools-images branch March 6, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants