execution-apis: Add EIP-7594 (PeerDAS) related changes #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x00101010
commented
Feb 19, 2025
0x00101010
commented
Feb 19, 2025
fradamt
reviewed
Feb 20, 2025
fradamt
reviewed
Feb 20, 2025
Co-authored-by: fradamt <[email protected]>
Co-authored-by: fradamt <[email protected]>
This was referenced Feb 28, 2025
ImTei
reviewed
Mar 4, 2025
Contributor
ImTei
left a comment
ImTei
left a comment
There was a problem hiding this comment.
I’ve added a few suggestions to slightly improve readability and clarity—mostly minor points for precision. None of them are strictly necessary, so please feel free to accept or ignore them based on your preference!
Co-authored-by: Tei Im <[email protected]>
Co-authored-by: Tei Im <[email protected]>
twistedshit4realsaga
approved these changes
Mar 5, 2025
g11tech
reviewed
Mar 11, 2025
fix camel case and other small changes
Rjected
reviewed
Mar 14, 2025
Contributor
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
have a question / request for clarification on the eth_sendRawTransaction semantics
flcl42
approved these changes
Apr 8, 2025
g11tech
reviewed
Apr 10, 2025
matthewkeil
pushed a commit
to ChainSafe/lodestar
that referenced
this pull request
Apr 14, 2025
**Motivation** add `engine_getBlobsV2` to the execution API in preparation for implementation of [distributed blob publishing](https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#distributed-blob-publishing-using-blobs-retrieved-from-local-execution-layer-client) @dguenther and I wanted to get early feedback on the API change before moving forward with the rest of the implementation **Description** upcoming spec changes will add `engine_getBlobsV2` to the execution API to fetch blobs and cell proofs from the execution layer (ethereum/execution-apis#630) * add `engine_getBlobsV2` to execution API * add type definition for `BlobAndProofV2` **Not included** We'll follow up with additional PR(s) for these as we move forward with distributed blob publishing: * fetch blobs from the EL in two places: on first seen block input gossip and on unknown blocks during syncing * reconstruct blobs from cell proofs * publish data column sidecars on subscribed topics after Relates to #7638 --------- Co-authored-by: Derek Guenther <[email protected]>
2 tasks
0x00101010
changed the title
mkalinin
reviewed
Apr 17, 2025
mkalinin
reviewed
Apr 18, 2025
mkalinin
reviewed
Apr 19, 2025
mkalinin
approved these changes
Apr 21, 2025
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
From the spec point of view the PR looks good to me, great work!
If any detail will be updated or re-shaped, it can be via other PRs
4 tasks
mergify bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
May 26, 2025
…7505) Update `engine_getBlobsV2` response type to `Option<Vec<BlobsAndProofV2>>`. See recent spec change [here](ethereum/execution-apis#630). Added some tests to cover basic fetch blob scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces updates to rpc and engine API definitions for EIP-7594, changes defined in ethereum/EIPs#9378
Notes for reviewers
This PR introduces backward incompatible changes to
engine_getPayloadV4, that returns newBlobsBundleV2with cell proofs instead of blob proofs