Skip to content

Fix invalid eth_simulate schema #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lightclient merged 6 commits into from
Jul 22, 2025
Merged

Fix invalid eth_simulate schema #675

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f3b589f
eth: fix invalid eth simulate schema
lightclient Jul 16, 2025
b6d9c44
eth: add back err message for call status
lightclient Jul 16, 2025
c56ee82
schemas: fixup based on pr comments
lightclient Jul 21, 2025
0b60e60
schema: rename 'multi' to 'eth_simulate'
lightclient Jul 22, 2025
d330c9b
schemas: use errors field for eth_simulate
lightclient Jul 22, 2025
e141324
move eth_simulate errors to method definition
lightclient Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/schemas/block.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Block:
- size
- transactions
- uncles
additionalProperties: false
properties:
hash:
title: Hash
Expand Down
33 changes: 22 additions & 11 deletions src/schemas/execute.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
EthSimulatePayload:
title: Arguments for multi call
required:
- blockStateCalls
properties:
blockStateCalls:
title: Block State Calls
Expand Down Expand Up @@ -149,7 +147,7 @@ Withdrawals:
description: This array can have a maximum length of 16.
type: array
items:
- $ref: '#/components/schemas/Withdrawal'
$ref: '#/components/schemas/Withdrawal'
Withdrawal:
title: A withdrawal made by a validator
type: object
Expand All @@ -168,7 +166,7 @@ Withdrawal:
$ref: '#/components/schemas/uint64'
EthSimulateResult:
title: Full results of multi call
type: object
type: array
oneOf:
- $ref: '#/components/schemas/EthSimulateBlockResultInvalid'
- $ref: '#/components/schemas/EthSimulateBlockResultSuccess'
Expand All @@ -180,9 +178,11 @@ EthSimulateBlockResultSuccess:
EthSimulateBlockResultSingleSuccess:
title: Result of eth_simulate block-level, with array of calls
type: object
unevaluatedProperties: false
allOf:
- $ref: '#/components/schemas/Block'
- title: Eth Simulate call results
- type: object
title: Eth Simulate call results
required:
- calls
properties:
Expand Down Expand Up @@ -240,7 +240,7 @@ CallResults:
title: Results of multi call within block
type: array
items:
oneOf:
anyOf:
- $ref: '#/components/schemas/CallResultFailure'
- $ref: '#/components/schemas/CallResultSuccess'
CallResultFailure:
Expand All @@ -265,10 +265,21 @@ CallResultFailure:
$ref: '#/components/schemas/uint64'
error:
oneOf:
- code: -32000
message: 'Execution reverted'
- code: -32015
message: 'VM execution error'
- type: object
properties:
code:
const: -32000
message:
type: string
pattern: "^execution reverted.*"
required: [code, message]
- type: object
properties:
code:
const: -32015
message:
type: string
pattern: "^vm execution error.*"
CallResultSuccess:
title: Result of call success
type: object
Expand Down Expand Up @@ -298,7 +309,7 @@ CallResultLog:
type: object
required:
- logIndex
- blockhash
- blockHash
- blockNumber
- transactionHash
- transactionIndex
Expand Down