From 5ff2efedd0925db5e3219a2b713e849686038a58 Mon Sep 17 00:00:00 2001 From: Shane Jonas Date: Tue, 18 Nov 2025 13:44:17 -0500 Subject: [PATCH 1/5] fix: add net_version fixes #540 --- src/eth/client.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/eth/client.yaml b/src/eth/client.yaml index 416df4c0a..6a3d3d3a8 100644 --- a/src/eth/client.yaml +++ b/src/eth/client.yaml @@ -70,3 +70,16 @@ result: name: Block number value: '0x2377' +- name: net_version + summary: Returns the current network ID. + params: [] + result: + name: Network ID + schema: + type: string + examples: + - name: net_version example + params: [] + result: + name: Network ID + value: '1' From 1a0df6ea42e81b18fbde4f29f1681bd5153aeae6 Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Fri, 28 Nov 2025 12:40:02 +0100 Subject: [PATCH 2/5] explain networkID is usually equal to chainID --- src/eth/client.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/eth/client.yaml b/src/eth/client.yaml index 6a3d3d3a8..f4a0578d3 100644 --- a/src/eth/client.yaml +++ b/src/eth/client.yaml @@ -71,7 +71,7 @@ name: Block number value: '0x2377' - name: net_version - summary: Returns the current network ID. + summary: Returns the current network ID. This is usually equivalent to the chainID, but may differ from it for some legacy networks or special testnets. params: [] result: name: Network ID From b72c9e0ca41b087019aaa152adaaaaf36a823ebd Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Fri, 5 Dec 2025 01:01:33 +0100 Subject: [PATCH 3/5] tests: add test for net_version --- tests/net_version/get-network-id.io | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tests/net_version/get-network-id.io diff --git a/tests/net_version/get-network-id.io b/tests/net_version/get-network-id.io new file mode 100644 index 000000000..03cab5e8b --- /dev/null +++ b/tests/net_version/get-network-id.io @@ -0,0 +1,3 @@ +// Calls net_version to retrieve the network ID, which is expected to be equal to the chainID of the test chain. +>> {"jsonrpc":"2.0","id":1,"method":"net_version"} +<< {"jsonrpc":"2.0","id":1,"result":"3503995874084926"} From f921c530041e17d4dc26a5e287a020613f44bfc7 Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Fri, 5 Dec 2025 01:07:57 +0100 Subject: [PATCH 4/5] schemas: add uintDecimal --- src/schemas/base-types.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/schemas/base-types.yaml b/src/schemas/base-types.yaml index 500d6c358..42d91b440 100644 --- a/src/schemas/base-types.yaml +++ b/src/schemas/base-types.yaml @@ -60,6 +60,10 @@ uint256: title: hex encoded 256 bit unsigned integer type: string pattern: ^0x(0|[1-9a-f][0-9a-f]{0,63})$ +uintDecimal: + title: decimal unsigned integer string + type: string + pattern: ^[1-9][0-9]*$ hash32: title: 32 byte hex value type: string From 5455dd3a0a9ed683d5a8541a66fe3faeb4935c31 Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Fri, 5 Dec 2025 01:08:06 +0100 Subject: [PATCH 5/5] eth: improve return type of net_version --- src/eth/client.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/eth/client.yaml b/src/eth/client.yaml index f4a0578d3..f3a9cca0f 100644 --- a/src/eth/client.yaml +++ b/src/eth/client.yaml @@ -76,7 +76,7 @@ result: name: Network ID schema: - type: string + $ref: '#/components/schemas/uintDecimal' examples: - name: net_version example params: []