fix(github/coverage): Fix coverage script on PRs that do not convert tests (#1661)

* fix(plugins/ported_from): Fix and add `--ported-from-output-file` parameter

* fix(github/coverage): Use `--ported-from-output-file`

* changelog

Author: marioevz

.github/workflows/coverage.yaml

@@ -120,10 +120,9 @@ jobs:
           new_sources=$(echo "$CHANGED_TEST_FILES" | tr ',' '\n')
           echo "Changed or new test files: $new_sources"
 
-          # uv run returns an error code if no tests detected in changed files. ignore it by setting || true.
-          files=$(uv run fill $new_sources --show-ported-from --clean --quiet --links-as-filled | grep .json || true)
+          uv run fill $new_sources --show-ported-from --clean --quiet --links-as-filled --ported-from-output-file ported_from_files.txt
+          files=$(cat ported_from_files.txt)
           echo "Extracted converted tests: $files"
-
           if [[ -z "$files" ]]; then
               echo "No ported fillers found, check updates instead:"
               echo "converted_skip=true" >> $GITHUB_ENV

docs/CHANGELOG.md

@@ -45,6 +45,7 @@ Users can select any of the artifacts depending on their testing needs for their
 - ✨ Added a new `eest` sub-command, `eest info`, to easily print a cloned EEST repository's version and the versions of relevant tools, e.g., `python`, `uv` ([#1621](https://github.com/ethereum/execution-spec-tests/pull/1621)).
 - ✨ Add `CONTRIBUTING.md` for execution-spec-tests and improve coding standards documentation ([#1604](https://github.com/ethereum/execution-spec-tests/pull/1604)).
 - 🔀 Updated from pytest 7 to [pytest 8](https://docs.pytest.org/en/stable/changelog.html#features-and-improvements), benefits include improved type hinting and hook typing, stricter mark handling, and clearer error messages for plugin and metadata development [#1433](https://github.com/ethereum/execution-spec-tests/pull/1433).
+- 🐞 Fix bug in ported-from plugin and coverage script that made PRs fail with modified tests that contained no ported tests ([#1661](https://github.com/ethereum/execution-spec-tests/pull/1661)).
 
 ### 🧪 Test Cases
 

src/pytest_plugins/filler/ported_tests.py

@@ -30,7 +30,7 @@
 """
 
 import re
-from typing import Set
+from typing import List, Set
 from urllib.parse import urlparse
 
 import pytest
@@ -72,6 +72,13 @@ def pytest_addoption(parser: pytest.Parser):
             "Use '--show-ported-from=prs' to show PR URLs."
         ),
     )
+    ported_from_group.addoption(
+        "--ported-from-output-file",
+        action="store",
+        dest="ported_from_output_file",
+        default=None,
+        help="Output file for ported_from information.",
+    )
     ported_from_group.addoption(
         "--links-as-filled",
         action="store_true",
@@ -99,9 +106,15 @@ def __init__(self, config) -> None:
         self.config = config
         self.show_mode = config.getoption("show_ported_from")
         self.links_as_filled = config.getoption("links_as_filled")
+        self.ported_from_output_file = config.getoption("ported_from_output_file")
 
     @pytest.hookimpl(hookwrapper=True, trylast=True)
-    def pytest_collection_modifyitems(self, session, config, items):
+    def pytest_collection_modifyitems(
+        self,
+        session: pytest.Session,
+        config: pytest.Config,
+        items: List[pytest.Item],
+    ):
         """Extract ported_from information from collected test items."""
         yield
 
@@ -133,25 +146,27 @@ def pytest_collection_modifyitems(self, session, config, items):
 
         # Output results based on mode
         if self.show_mode == "prs":
-            output = sorted(prs)
+            outputs = sorted(prs)
         else:  # default to "paths"
-            output = sorted(paths)
-
+            outputs = sorted(paths)
+        output_lines: List[str] = []
         if self.links_as_filled:
-            all_files: list = []
-            for item in output:
-                converted_link = convert_to_filled(item)
-                if converted_link is not None:
-                    all_files.append(converted_link)
-            print(" ".join(all_files))
+            for output in outputs:
+                converted_link_output = convert_to_filled(output)
+                if converted_link_output is not None:
+                    output_lines.append(converted_link_output)
+        else:
+            output_lines.extend(outputs)
+        if self.ported_from_output_file:
+            with open(self.ported_from_output_file, "w") as f:
+                f.write("\n".join(output_lines))
         else:
-            for item in output:
-                print(item)
+            for line in output_lines:
+                print(line)
 
     @pytest.hookimpl(tryfirst=True)
     def pytest_runtestloop(self, session):
         """Skip test execution, only show ported_from information."""
-        session.testscollected = 0
         return True
 
     def pytest_terminal_summary(self, terminalreporter, exitstatus, config):