Skip to content

Commit 0fe4295

Browse files
authored
fix(tests): fix invalid log opcode keyword 7702 fails (#1856)
* fix(tests): fix invalid kwarg fails in 7702 `test_set_code_to_log` * docs: update and fix changelog
1 parent 0f77f07 commit 0fe4295

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

docs/CHANGELOG.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@ Users can select any of the artifacts depending on their testing needs for their
2727

2828
### 🛠️ Framework
2929

30-
#### 🔀 Refactoring
31-
32-
- 🔀 Move `TransactionType` enum from test file to proper module location in `ethereum_test_types.transaction_types` for better code organization and reusability.
33-
- ✨ Opcode classes now validate keyword arguments and raise `ValueError` with clear error messages.
34-
3530
#### `fill`
3631

3732
- ✨ Add the `ported_from` test marker to track Python test cases that were converted from static fillers in [ethereum/tests](https://github.com/ethereum/tests) repository ([#1590](https://github.com/ethereum/execution-spec-tests/pull/1590)).
@@ -80,6 +75,8 @@ Users can select any of the artifacts depending on their testing needs for their
8075
- 🔀 Refactor and clean up of exceptions including EOF exceptions within client specific mappers [#1803](https://github.com/ethereum/execution-spec-tests/pull/1803).
8176
- 🔀 Rename `tests/zkevm/` to `tests/benchmark/` and replace the `zkevm` pytest mark with `benchmark` [#1804](https://github.com/ethereum/execution-spec-tests/pull/1804).
8277
- 🔀 Add fixture comparison check to optimize coverage workflow in CI ([#1833](https://github.com/ethereum/execution-spec-tests/pull/1833)).
78+
- 🔀 Move `TransactionType` enum from test file to proper module location in `ethereum_test_types.transaction_types` for better code organization and reusability ([#1763](https://github.com/ethereum/execution-spec-tests/pull/1673)).
79+
- ✨ Opcode classes now validate keyword arguments and raise `ValueError` with clear error messages ([#1739](https://github.com/ethereum/execution-spec-tests/pull/1739), [#1856](https://github.com/ethereum/execution-spec-tests/pull/1856)).
8380

8481
### 🧪 Test Cases
8582

tests/prague/eip7702_set_code_tx/test_set_code_txs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2496,9 +2496,9 @@ def test_set_code_to_log(
24962496
sender = pre.fund_eoa()
24972497

24982498
log_kwargs = {}
2499-
if "topic_1" not in log_opcode.kwargs:
2499+
if "topic_1" in log_opcode.kwargs:
25002500
log_kwargs["topic_1"] = 1
2501-
if "topic_2" not in log_opcode.kwargs:
2501+
if "topic_2" in log_opcode.kwargs:
25022502
log_kwargs["topic_2"] = 2
25032503
if "topic_3" in log_opcode.kwargs:
25042504
log_kwargs["topic_3"] = 3

0 commit comments

Comments
 (0)