docs(tests): update porting ethereum/tests instructions (#1872)

Co-authored-by: danceratopz <[email protected]>

Author: winsvega

CONTRIBUTING.md

@@ -99,7 +99,7 @@ We welcome contributions via pull requests! This section will guide you through
 
 7. **For EVM Tests**: Review the cases in the [EIP checklist template](./docs/writing_tests/checklist_templates/eip_testing_checklist_template.md).
 
-8. **For Porting Tests**: If you're porting tests from ethereum/tests, see the [porting guide](https://eest.ethereum.org/main/dev/porting_legacy_tests) for coverage analysis and using `--skip-coverage-missed-reason` when needed.
+8. **For Porting Tests**: If you're porting tests from ethereum/tests, see the [porting guide](https://eest.ethereum.org/main/writing_tests/porting_legacy_tests) for coverage analysis and using `--skip-coverage-missed-reason` when needed.
 
 9. **Verify your changes** by running the appropriate checks:
 

docs/dev/index.md

@@ -9,7 +9,6 @@ This documentation is aimed at `execution-spec-tests` developers:
 - [Logging](./logging.md): Documentation on using the custom logging system with enhanced features.
 - [Enabling pre-commit checks](./precommit.md): A guide for setting up pre-commit hooks to enforce code quality before commits.
 - [Running github actions locally](./test_actions_locally.md): Instructions for testing GitHub Actions workflows on your local machine to streamline development and debugging.
-- [Porting tests](./porting_legacy_tests.md): A guide to porting legacy ethereum tests to EEST.
 
 These sections are primarily aimed at `execution-spec-tests` maintainers:
 

docs/navigation.md

@@ -26,6 +26,7 @@
           * [EIP Execution Layer Testing Checklist Template](writing_tests/checklist_templates/eip_testing_checklist_template.md)
       * [Post-mortems](writing_tests/post_mortems.md)
       * [Tutorial: Adding a State Test](writing_tests/tutorials/state_transition.md)
+      * [Porting Legacy Tests](writing_tests/porting_legacy_tests.md)
   * [Filling Tests](filling_tests/index.md)
       * [Getting Started](filling_tests/getting_started.md)
       * [Filling Tests at a Prompt](filling_tests/filling_tests_command_line.md)
@@ -70,7 +71,6 @@
       * [Logging](dev/logging.md)
       * [Enabling Precommit Checks](dev/precommit.md)
       * [Running Github Actions Locally](dev/test_actions_locally.md)
-      * [Porting Legacy Tests](dev/porting_legacy_tests.md)
   * [Changelog](CHANGELOG.md)
   * [Library Reference](library/index.md)
       * [EEST CLI Tools](library/cli/index.md)

docs/writing_tests/index.md

@@ -25,5 +25,6 @@ For help deciding which test format to select, see [Types of Tests](./types_of_t
 - [Adding a New Test](./adding_a_new_test.md) - Step-by-step guide to adding new tests
 - [Writing a New Test](./writing_a_new_test.md) - Detailed guide on writing different test types
 - [Using and Extending Fork Methods](./fork_methods.md) - How to use fork methods to write fork-adaptive tests
+- [Porting tests](./porting_legacy_tests.md): A guide to porting @ethereum/tests to EEST.
 
 Please check that your code adheres to the repo's coding standards and read the other pages in this section for more background and an explanation of how to implement state transition and blockchain tests.

docs/dev/porting_legacy_tests.md renamed to docs/writing_tests/porting_legacy_tests.md

@@ -15,14 +15,35 @@ While automating the conversion of the remaining YAML (or JSON) test cases to Py
 
 ## Porting an original test
 
-1. Select one or more YAML test cases from ethereum/tests to port and create an issue in this repository AND comment on [this tracker issue.](https://github.com/ethereum/execution-spec-tests/issues/972)
+1. Select one or more test cases from `./tests/static/state_tests/` to port and create an issue in this repository AND comment on [this tracker issue.](https://github.com/ethereum/execution-spec-tests/issues/972)
 
 2. [Add a new test](../writing_tests/index.md) in the appropriate fork folder, following the guidelines for [choosing a test type.](../writing_tests/types_of_tests.md#deciding-on-a-test-type)
 
 3. Submit a PR with the ported tests:
 
-     1. Add the list of ported YAML files to [`converted-ethereum-tests.txt`](https://github.com/ethereum/execution-spec-tests/blob/1b30c336eae6b0746ea4db441ac74406f2fb2322/converted-ethereum-tests.txt).
-     2. Open a PR to remove the ported tests from the _original tests_ repository.
+     1. Add the list of ported files using python marker to the head of your python test.
+
+        Example:
+
+        ```python
+         @pytest.mark.ported_from(
+        [
+            "https://github.com/ethereum/tests/blob/v13.3/src/GeneralStateTestsFiller/stCreateTest/CREATE_ContractSuicideDuringInit_ThenStoreThenReturnFiller.json",
+            "https://github.com/ethereum/tests/blob/v13.3/src/GeneralStateTestsFiller/stCreateTest/CREATE_ContractSuicideDuringInit_WithValueFiller.json",
+        ],
+        pr=["https://github.com/ethereum/execution-spec-tests/pull/1871"],
+        # coverage_missed_reason="Converting solidity code result in following opcode not being used:",
+        ```
+
+        Replace test names with your chosen tests and PR number.
+
+        Uncomment coverage_missed_reason when all the missed coverage lines are approved, usually some opcodes end up not used after translating test logic from lllc, yul.
+
+        But sometimes missed coverage line could hint that you forgot to account important test logic.
+
+        If no coverage is missed, you are good!
+
+     2. Remove the ported files from .tests/static/state_tests in your PR
 
 > See also: 📄 [Getting started with EEST.](../getting_started/repository_overview.md)
 
@@ -46,7 +67,7 @@ By default, EVM logs are stored in the `logs` folder at the repository root. You
 
 It's crucial that ported tests maintain coverage parity with _original tests_. This ensures that no critical functions are left untested and prevents the introduction of bugs. A CI workflow automatically checks for coverage.
 
-If coverage action fails (See: 📄 [An example of a failing test coverage](https://github.com/ethereum/execution-spec-tests/actions/runs/13037332959/job/36370897481)), it's recommended to run the coverage action locally (see: 📄 [How to run GitHub actions locally](./test_actions_locally.md)), which should generate a `evmtest_coverage` directory:
+If coverage action fails (See: 📄 [An example of a failing test coverage](https://github.com/ethereum/execution-spec-tests/actions/runs/13037332959/job/36370897481)), it's recommended to run the coverage action locally (see: 📄 [How to run GitHub actions locally](../dev/test_actions_locally.md)), which should generate a `evmtest_coverage` directory:
 
 ```console
 ❯ tree evmtest_coverage  -L 2