refactor(tests,tw): EOF - Top-level container must not be truncated (#613)

* feat(tests,tw): Top-level EOF container must not be truncated

We are changing the EOF validation API (e.g. eofparse, EOF validation
tests): the top-level EOF container must not have truncated/missing
data section. This is how you would validate "genesis" EOF containers
and is also less confusing for EOF tool users.

This change introduces new error kind: `TOPLEVEL_CONTAINER_TRUNCATED`
and matches the recent change in evmone.

* Update tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_example_valid_invalid.py

---------

Co-authored-by: Mario Vega <[email protected]>

Author: chfast

src/ethereum_test_tools/exceptions/evmone_exceptions.py

@@ -70,6 +70,9 @@ class EvmoneExceptionMapper:
         ExceptionMessage(EOFException.INVALID_MAX_STACK_HEIGHT, "err: invalid_max_stack_height"),
         ExceptionMessage(EOFException.INVALID_DATALOADN_INDEX, "err: invalid_dataloadn_index"),
         ExceptionMessage(EOFException.TRUNCATED_INSTRUCTION, "err: truncated_instruction"),
+        ExceptionMessage(
+            EOFException.TOPLEVEL_CONTAINER_TRUNCATED, "err: toplevel_container_truncated"
+        ),
     )
 
     def __init__(self) -> None:

src/ethereum_test_tools/exceptions/exceptions.py

@@ -684,6 +684,10 @@ class EOFException(ExceptionBase):
     """
     EOF container's code section has truncated instruction.
     """
+    TOPLEVEL_CONTAINER_TRUNCATED = auto()
+    """
+    Top-level EOF container has data section truncated
+    """
 
 
 """

tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py

@@ -27,23 +27,6 @@
             Section.Data(data="0x00"),
         ],
     ),
-    Container(
-        # EOF allows truncated data section
-        name="no_data_section_contents",
-        sections=[
-            Section.Code(Op.STOP),
-            Section.Data(data="0x", custom_size=1),
-        ],
-        code="ef0001 010004 0200010001 040001 00 00800000 00",
-    ),
-    Container(
-        # EOF allows truncated data section
-        name="data_section_contents_incomplete",
-        sections=[
-            Section.Code(Op.STOP),
-            Section.Data(data="0xAABBCC", custom_size=4),
-        ],
-    ),
     Container(
         name="max_code_sections",
         sections=[
@@ -331,6 +314,23 @@
         # TODO the exception must be about code section EOFException.INVALID_CODE_SECTION,
         validity_error=EOFException.ZERO_SECTION_SIZE,
     ),
+    Container(
+        name="no_data_section_contents",
+        sections=[
+            Section.Code(Op.STOP),
+            Section.Data(data="0x", custom_size=1),
+        ],
+        code="ef0001 010004 0200010001 040001 00 00800000 00",
+        validity_error=EOFException.TOPLEVEL_CONTAINER_TRUNCATED,
+    ),
+    Container(
+        name="data_section_contents_incomplete",
+        sections=[
+            Section.Code(Op.STOP),
+            Section.Data(data="0xAABBCC", custom_size=4),
+        ],
+        validity_error=EOFException.TOPLEVEL_CONTAINER_TRUNCATED,
+    ),
     Container(
         name="data_section_preceding_code_section",
         auto_data_section=False,

tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_example_valid_invalid.py

@@ -49,8 +49,8 @@
                 ],
             ),
             "ef0001010004020001000304000400008000013050000bad",
-            None,
-            id="undersize_data_ok",
+            EOFException.TOPLEVEL_CONTAINER_TRUNCATED,
+            id="undersize_data_not_ok_on_toplevel_container",
         ),
         pytest.param(
             # Check that EOF1 with too many or too few bytes fails

whitelist.txt

@@ -343,6 +343,7 @@ time15k
 timestamp
 todo
 toml
+toplevel
 tox
 Tox
 traceback