new(tests): test for CALLF to non-returning section (#1126)

This adds tests for previously uncovered EOF validation error of CALLF
to nonreturning sections.

Co-authored-by: pdobacz <[email protected]>

Author: chfast

converted-ethereum-tests.txt

@@ -14,6 +14,7 @@ EOFTests/EIP3540/validInvalid.json
 
 EOFTests/EIP3670/validInvalid.json
 EOFTests/EIP4200/validInvalid.json
+EOFTests/efValidation/callf_into_nonreturning_.json
 EOFTests/efValidation/EOF1_embedded_container_.json
 EOFTests/efValidation/EOF1_eofcreate_valid_.json
 EOFTests/efValidation/EOF1_callf_truncated_.json

src/ethereum_clis/clis/evmone.py

@@ -184,4 +184,7 @@ def _mapping_data(self):
             ExceptionMessage(
                 EOFException.INVALID_CODE_SECTION_INDEX, "err: invalid_code_section_index"
             ),
+            ExceptionMessage(
+                EOFException.CALLF_TO_NON_RETURNING, "err: callf_to_non_returning_function"
+            ),
         ]

src/ethereum_test_exceptions/exceptions.py

@@ -754,6 +754,10 @@ class EOFException(ExceptionBase):
     """
     Header parsing encounterd a section kind it wasn't expecting
     """
+    CALLF_TO_NON_RETURNING = auto()
+    """
+    CALLF instruction targeting a non-returning code section
+    """
 
 
 """

tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_nonreturning_validation.py

@@ -138,3 +138,71 @@ def test_jumpf_in_nonreturning(eof_test: EOFTestFiller, first: bool, code_prefix
             validity_error=EOFException.INVALID_NON_RETURNING_FLAG,
         )
     )
+
+
+@pytest.mark.parametrize(
+    "container",
+    [
+        Container(
+            name="0_to_1",
+            sections=[
+                Section.Code(
+                    Op.CALLF[1],
+                ),
+                Section.Code(
+                    Op.STOP,
+                ),
+            ],
+        ),
+        Container(
+            name="self_0",
+            sections=[
+                Section.Code(
+                    Op.CALLF[0] + Op.STOP,
+                )
+            ],
+        ),
+        Container(
+            name="self_1",
+            sections=[
+                Section.Code(
+                    Op.JUMPF[1],
+                ),
+                Section.Code(
+                    Op.CALLF[1] + Op.STOP,
+                ),
+            ],
+        ),
+        Container(
+            name="1_to_0",
+            sections=[
+                Section.Code(
+                    Op.CALLF[1] + Op.STOP,
+                ),
+                Section.Code(
+                    Op.CALLF[0] + Op.RETF,
+                    code_outputs=0,
+                ),
+            ],
+        ),
+        Container(
+            name="1_to_2",
+            sections=[
+                Section.Code(
+                    Op.CALLF[1] + Op.STOP,
+                ),
+                Section.Code(
+                    Op.CALLF[2] + Op.RETF,
+                    code_outputs=0,
+                ),
+                Section.Code(
+                    Op.INVALID,
+                ),
+            ],
+        ),
+    ],
+    ids=lambda x: x.name,
+)
+def test_callf_to_nonreturning(eof_test: EOFTestFiller, container: Container):
+    """Test EOF validation failing due to CALLF to non-returning section."""
+    eof_test(data=container, expect_exception=EOFException.CALLF_TO_NON_RETURNING)

tests/osaka/eip7692_eof_v1/eof_tracker.md

@@ -334,7 +334,7 @@
 
 - [x] Zero section returning ([`tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_nonreturning_validation.py::test_first_section_returning`](./eip6206_jumpf/test_nonreturning_validation/test_first_section_returning.md), ethereum/tests: ./src/EOFTestsFiller/efExample/validInvalidFiller.yml src/EOFTestsFiller/EIP4750/validInvalidFiller.yml)
 - [x] Zero section declared non-returning but ends with RETF ([`tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_nonreturning_validation.py::test_retf_in_nonreturning`](./eip6206_jumpf/test_nonreturning_validation/test_retf_in_nonreturning.md), ethereum/tests: src/EOFTestsFiller/EIP4750/validInvalidFiller.yml)
-- [ ] CALLF into non-returning function (ethereum/tests: src/EOFTestsFiller/efValidation/callf_into_nonreturning_Copier.json)
+- [x] CALLF into non-returning function ([`tests/osaka/eip7692_eof_v1/eip6206_jumpf/test_nonreturning_validation.py::test_callf_to_nonreturning`](./eip6206_jumpf/test_nonreturning_validation/test_callf_to_nonreturning.md))
 - [ ] Valid JUMPF into sections with equal number of outputs (ethereum/tests: src/EOFTestsFiller/efValidation/jumpf_equal_outputs_Copier.json)
 - [ ] Valid JUMPF into sections with different but compatible number of outputs (ethereum/tests: src/EOFTestsFiller/efValidation/jumpf_compatible_outputs_Copier.json)
 - [ ] JUMPF into sections with incompatible outputs (ethereum/tests: src/EOFTestsFiller/efValidation/jumpf_incompatible_outputs_Copier.json)