Skip to content

Commit 626ac78

Browse files
committed
refactor(forks): move BAL tests to Amsterdam
- chore(cleanup): Remove reference to told BlockAccessLists fork - refactor(fork): ``Amsterdam`` above old EOF fork.
1 parent 9626bd8 commit 626ac78

File tree

5 files changed

+14
-31
lines changed

5 files changed

+14
-31
lines changed

src/ethereum_test_forks/forks/forks.py

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1437,11 +1437,6 @@ def engine_forkchoice_updated_version(
14371437
class Osaka(Prague, solc_name="cancun"):
14381438
"""Osaka fork."""
14391439

1440-
@classmethod
1441-
def header_bal_hash_required(cls, block_number: int = 0, timestamp: int = 0) -> bool:
1442-
"""Hash of the block access list is required starting from Osaka fork."""
1443-
return True
1444-
14451440
# update some blob constants
14461441
BLOB_CONSTANTS = {
14471442
**Prague.BLOB_CONSTANTS, # same base constants as prague
@@ -1646,6 +1641,15 @@ def max_blobs_per_block(cls, block_number: int = 0, timestamp: int = 0) -> int:
16461641
return 21
16471642

16481643

1644+
class Amsterdam(Osaka):
1645+
"""Amsterdam fork."""
1646+
1647+
@classmethod
1648+
def is_deployed(cls) -> bool:
1649+
"""Return True if this fork is deployed."""
1650+
return False
1651+
1652+
16491653
class EOFv1(Prague, solc_name="cancun"):
16501654
"""EOF fork."""
16511655

@@ -1675,21 +1679,3 @@ def is_deployed(cls) -> bool:
16751679
development.
16761680
"""
16771681
return False
1678-
1679-
1680-
class Amsterdam(Osaka):
1681-
"""Amsterdam fork."""
1682-
1683-
@classmethod
1684-
def is_deployed(cls) -> bool:
1685-
"""Return True if this fork is deployed."""
1686-
return False
1687-
1688-
1689-
class BlockAccessLists(Prague):
1690-
"""A development fork for Block Access Lists."""
1691-
1692-
@classmethod
1693-
def header_bal_hash_required(cls, block_number: int = 0, timestamp: int = 0) -> bool:
1694-
"""Hash of the block access list is required starting from this fork."""
1695-
return True
File renamed without changes.

tests/osaka/eip7928_block_level_access_lists/spec.py renamed to tests/amsterdam/eip7928_block_level_access_lists/spec.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
from dataclasses import dataclass
44

5-
# ACTIVATION_FORK_NAME = "BlockAccessLists"
6-
# """The fork name for EIP-7928 activation."""
7-
85

96
@dataclass(frozen=True)
107
class ReferenceSpec:

tests/osaka/eip7928_block_level_access_lists/test_block_access_lists.py renamed to tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
REFERENCE_SPEC_VERSION = ref_spec_7928.version
2828

2929

30-
@pytest.mark.valid_from("Osaka")
30+
@pytest.mark.valid_from("Amsterdam")
3131
def test_bal_nonce_changes(
3232
pre: Alloc,
3333
blockchain_test: BlockchainTestFiller,
@@ -62,7 +62,7 @@ def test_bal_nonce_changes(
6262
)
6363

6464

65-
@pytest.mark.valid_from("Osaka")
65+
@pytest.mark.valid_from("Amsterdam")
6666
def test_bal_balance_changes(
6767
pre: Alloc,
6868
blockchain_test: BlockchainTestFiller,
@@ -122,7 +122,7 @@ def test_bal_balance_changes(
122122
)
123123

124124

125-
@pytest.mark.valid_from("Osaka")
125+
@pytest.mark.valid_from("Amsterdam")
126126
def test_bal_storage_writes(
127127
pre: Alloc,
128128
blockchain_test: BlockchainTestFiller,
@@ -162,7 +162,7 @@ def test_bal_storage_writes(
162162
)
163163

164164

165-
@pytest.mark.valid_from("Osaka")
165+
@pytest.mark.valid_from("Amsterdam")
166166
def test_bal_storage_reads(
167167
pre: Alloc,
168168
blockchain_test: BlockchainTestFiller,
@@ -200,7 +200,7 @@ def test_bal_storage_reads(
200200
)
201201

202202

203-
@pytest.mark.valid_from("Osaka")
203+
@pytest.mark.valid_from("Amsterdam")
204204
def test_bal_code_changes(
205205
pre: Alloc,
206206
blockchain_test: BlockchainTestFiller,

0 commit comments

Comments
 (0)