chore: unused arguments (#2166)

Co-authored-by: danceratopz <[email protected]>

Author: SamWilsn

docs/getting_started/code_standards.md

@@ -80,6 +80,7 @@ Code pushed to @ethereum/execution-spec-tests must fulfill the following checks
 - **Relative Imports**: Use relative imports within the same package
 - **Error Handling**: Use explicit exception types and meaningful error messages.
 - **Type Hints**: All functions should include type annotations.
+- **Unused Function Arguments**: When  unavoidable, use `del`, e.g., `del unused_var`, at function start to avoid flagging linter errors.
 - **Variable Naming**:
     - Use `snake_case` for variables, functions, and modules.
     - Use `PascalCase` for classes.

pyproject.toml

@@ -127,10 +127,13 @@ ethereum_test_forks = ["forks/contracts/*.bin"]
 line-length = 99
 
 [tool.ruff.lint]
-select = ["E", "F", "B", "W", "I", "A", "N", "D", "C"]
+select = ["E", "F", "B", "W", "I", "A", "N", "D", "C", "ARG001"]
 fixable = ["I", "B", "E", "F", "W", "D", "C"]
 ignore = ["D205", "D203", "D212", "D415", "C420", "C901"]
 
+[tool.ruff.lint.per-file-ignores]
+"tests/*" = ["ARG001"] # TODO: ethereum/execution-spec-tests#2188
+
 [tool.mypy]
 disable_error_code = ["import-untyped"]
 mypy_path = ["src", "$MYPY_CONFIG_FILE_DIR/stubs"]

src/cli/gen_index.py

@@ -53,15 +53,6 @@ def count_json_files_exclude_index(start_path: Path) -> int:
     required=True,
     help="The input directory",
 )
-@click.option(
-    "--disable-infer-format",
-    "-d",
-    "disable_infer_format",
-    is_flag=True,
-    default=False,
-    expose_value=True,
-    help="Don't try to guess the fixture format from the json file's path.",
-)
 @click.option(
     "--quiet",
     "-q",
@@ -80,23 +71,19 @@ def count_json_files_exclude_index(start_path: Path) -> int:
     expose_value=True,
     help="Force re-generation of the index file, even if it already exists.",
 )
-def generate_fixtures_index_cli(
-    input_dir: str, quiet_mode: bool, force_flag: bool, disable_infer_format: bool
-):
+def generate_fixtures_index_cli(input_dir: str, quiet_mode: bool, force_flag: bool):
     """CLI wrapper to an index of all the fixtures in the specified directory."""
     generate_fixtures_index(
         Path(input_dir),
         quiet_mode=quiet_mode,
         force_flag=force_flag,
-        disable_infer_format=disable_infer_format,
     )
 
 
 def generate_fixtures_index(
     input_path: Path,
     quiet_mode: bool = False,
     force_flag: bool = False,
-    disable_infer_format: bool = False,
 ):
     """
     Generate an index file (index.json) of all the fixtures in the specified

src/cli/gentest/tests/test_cli.py

@@ -106,6 +106,7 @@ def test_tx_type(pytester, tmp_path, monkeypatch, tx_type, transaction_hash, def
     tx = transactions_by_type[tx_type]
 
     def get_mock_context(self: StateTestProvider) -> dict:
+        del self
         return tx
 
     monkeypatch.setattr(StateTestProvider, "get_context", get_mock_context)

src/cli/pytest_commands/check_eip_versions.py

@@ -14,6 +14,8 @@
 @common_pytest_options
 def check_eip_versions(pytest_args: List[str], **kwargs) -> None:
     """Run pytest with the `spec_version_checker` plugin."""
+    del kwargs
+
     command = PytestCommand(
         config_file="pytest-check-eip-versions.ini",
         argument_processors=[HelpFlagsProcessor("check-eip-versions")],

src/cli/pytest_commands/checklist.py

@@ -41,6 +41,8 @@ def checklist(output: str, eip: tuple, **kwargs) -> None:
         uv run checklist --output ./my-checklists
 
     """
+    del kwargs
+
     # Add output directory to pytest args
     args = ["--checklist-output", output]
 

src/cli/pytest_commands/consume.py

@@ -36,7 +36,7 @@ def create_consume_command(
     )
 
 
-def get_command_logic_test_paths(command_name: str, is_hive: bool) -> List[Path]:
+def get_command_logic_test_paths(command_name: str) -> List[Path]:
     """Determine the command paths based on the command name and hive flag."""
     base_path = Path("pytest_plugins/consume")
     if command_name in ["engine", "rlp"]:
@@ -66,7 +66,7 @@ def consume_command(is_hive: bool = False) -> Callable[[Callable[..., Any]], cli
     def decorator(func: Callable[..., Any]) -> click.Command:
         command_name = func.__name__
         command_help = func.__doc__
-        command_logic_test_paths = get_command_logic_test_paths(command_name, is_hive)
+        command_logic_test_paths = get_command_logic_test_paths(command_name)
 
         @consume.command(
             name=command_name,
@@ -76,6 +76,8 @@ def decorator(func: Callable[..., Any]) -> click.Command:
         @common_pytest_options
         @functools.wraps(func)
         def command(pytest_args: List[str], **kwargs) -> None:
+            del kwargs
+
             consume_cmd = create_consume_command(
                 command_logic_test_paths=command_logic_test_paths,
                 is_hive=is_hive,
@@ -118,5 +120,7 @@ def sync() -> None:
 @common_pytest_options
 def cache(pytest_args: List[str], **kwargs) -> None:
     """Consume command to cache test fixtures."""
+    del kwargs
+
     cache_cmd = create_consume_command(command_logic_test_paths=[], is_hive=False)
     cache_cmd.execute(list(pytest_args))

src/cli/pytest_commands/fill.py

@@ -213,6 +213,8 @@ def create_executions(self, pytest_args: List[str]) -> List[PytestExecution]:
 @common_pytest_options
 def fill(pytest_args: List[str], **kwargs) -> None:
     """Entry point for the fill command."""
+    del kwargs
+
     command = FillCommand()
     command.execute(list(pytest_args))
 
@@ -225,6 +227,8 @@ def fill(pytest_args: List[str], **kwargs) -> None:
 @common_pytest_options
 def phil(pytest_args: List[str], **kwargs) -> None:
     """Friendly alias for the fill command."""
+    del kwargs
+
     command = PhilCommand()
     command.execute(list(pytest_args))
 

src/cli/show_pre_alloc_group_stats.py

@@ -100,7 +100,7 @@ def calculate_size_distribution(
     return group_distribution, test_distribution
 
 
-def analyze_pre_alloc_folder(folder: Path, verbose: int = 0) -> Dict:
+def analyze_pre_alloc_folder(folder: Path) -> Dict:
     """Analyze pre-allocation folder and return statistics."""
     pre_alloc_groups = PreAllocGroups.from_folder(folder, lazy_load=False)
 
@@ -480,7 +480,7 @@ def main(pre_alloc_folder: Path, verbose: int):
     console = Console()
 
     try:
-        stats = analyze_pre_alloc_folder(pre_alloc_folder, verbose=verbose)
+        stats = analyze_pre_alloc_folder(pre_alloc_folder)
         display_stats(stats, console, verbose=verbose)
     except FileNotFoundError:
         console.print(f"[red]Error: Folder not found: {pre_alloc_folder}[/red]")

src/cli/tests/test_pytest_execute_command.py

@@ -28,7 +28,7 @@ def test_execute_help_shows_subcommand_docstrings(runner):
     assert "Recover funds from test executions" in result.output
 
 
-def test_execute_subcommands_have_help_text(runner):
+def test_execute_subcommands_have_help_text():
     """Test that execute sub-commands have proper help text defined."""
     from ..pytest_commands.execute import hive, recover, remote