Skip to content

Commit 851f9f5

Browse files
chore(ci): update pr template (#1805)
Co-authored-by: danceratopz <[email protected]>
1 parent c97de26 commit 851f9f5

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,22 @@
11
## 🗒️ Description
22
<!-- Brief description of the changes introduced by this PR -->
3+
<!-- Don't submit this PR if it could expose a mainnet bug, see SECURITY.md in the repo root for details -->
34

4-
## 🔗 Related Issues
5-
<!-- Reference any related issues using the GitHub issue number (e.g., Fixes #123) -->
5+
## 🔗 Related Issues or PRs
6+
<!-- Reference any related issues using the GitHub issue number (e.g., Fixes #123). Default is N/A. -->
7+
N/A.
68

79
## ✅ Checklist
10+
<!-- Please check off all required items. For those that don't apply remove them accordingly. -->
811

9-
- [ ] All: Set appropriate labels for the changes.
10-
- [ ] All: Considered squashing commits to improve commit history.
11-
- [ ] All: Added an entry to [CHANGELOG.md](/ethereum/execution-spec-tests/blob/main/docs/CHANGELOG.md).
12+
- [ ] All: Ran fast `tox` checks to avoid unnecessary CI fails, see also [Code Standards](https://eest.ethereum.org/main/getting_started/code_standards/) and [Enabling Pre-commit Checks](https://eest.ethereum.org/main/dev/precommit/):
13+
```console
14+
uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
15+
```
16+
- [ ] All: PR title adheres to the [repo standard](https://eest.ethereum.org/main/getting_started/contributing/?h=contri#commit-messages-issue-and-pr-titles) - it will be used as the squash commit message and should start `type(scope):`.
17+
- [ ] All: Considered adding an entry to [CHANGELOG.md](/ethereum/execution-spec-tests/blob/main/docs/CHANGELOG.md).
1218
- [ ] All: Considered updating the online docs in the [./docs/](/ethereum/execution-spec-tests/blob/main/docs/) directory.
13-
- [ ] Tests: All converted JSON/YML tests from [ethereum/tests](/ethereum/tests)/[tests/static](/ethereum/execution-spec-tests/blob/main/tests/static) have been assigned @ported_from marker.
14-
- [ ] Tests: A PR with removal of converted JSON/YML blockchain tests from [ethereum/tests](/ethereum/tests) have been opened.
15-
- [ ] Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
19+
- [ ] All: Set appropriate labels for the changes (only maintainers can apply labels).
1620
- [ ] Tests: Ran `mkdocs serve` locally and verified the auto-generated docs for new tests in the [Test Case Reference](https://eest.ethereum.org/main/tests/) are correctly formatted.
1721
- [ ] Tests: For PRs implementing a missed test case, update the [post-mortem document](/ethereum/execution-spec-tests/blob/main/docs/writing_tests/post_mortems.md) to add an entry the list.
22+
- [ ] Ported Tests: All converted JSON/YML tests from [ethereum/tests](/ethereum/tests) or [tests/static](/ethereum/execution-spec-tests/blob/main/tests/static) have been assigned `@ported_from` marker.

0 commit comments

Comments
 (0)