feat(tests): extra BLS tests with invalid point coords (#2004)

* feat(tests): extra BLS tests with invalid point coords.

* chore(tests): remove redundancies.

Author: spencer-tb

tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1msm.py

@@ -9,7 +9,7 @@
 from ethereum_test_tools import Opcodes as Op
 
 from .conftest import G1_POINTS_NOT_IN_SUBGROUP, G1_POINTS_NOT_ON_CURVE
-from .helpers import vectors_from_file
+from .helpers import PointG1, vectors_from_file
 from .spec import Scalar, Spec, ref_spec_2537
 
 REFERENCE_SPEC_GIT_PATH = ref_spec_2537.git_path
@@ -180,6 +180,23 @@ def test_valid(
             bytes([0]) * 159,  # Just under minimum valid length
             id="input_too_short_by_1",
         ),
+        # Coordinates above modulus p cases.
+        pytest.param(
+            PointG1(Spec.P1.x + Spec.P, Spec.P1.y) + Scalar(1),
+            id="x_above_p_pos_0",
+        ),
+        pytest.param(
+            PointG1(Spec.P1.x, Spec.P1.y + Spec.P) + Scalar(1),
+            id="y_above_p_pos_0",
+        ),
+        pytest.param(
+            Spec.G1 + Scalar(1) + PointG1(Spec.P1.x + Spec.P, Spec.P1.y) + Scalar(0),
+            id="x_above_p_pos_1",
+        ),
+        pytest.param(
+            Spec.G1 + Scalar(1) + PointG1(Spec.P1.x, Spec.P1.y + Spec.P) + Scalar(0),
+            id="y_above_p_pos_1",
+        ),
     ],
     # Input length tests can be found in ./test_bls12_variable_length_input_contracts.py
 )

tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g2msm.py

@@ -9,7 +9,7 @@
 from ethereum_test_tools import Opcodes as Op
 
 from .conftest import G2_POINTS_NOT_IN_SUBGROUP, G2_POINTS_NOT_ON_CURVE
-from .helpers import vectors_from_file
+from .helpers import PointG2, vectors_from_file
 from .spec import Scalar, Spec, ref_spec_2537
 
 REFERENCE_SPEC_GIT_PATH = ref_spec_2537.git_path
@@ -178,6 +178,51 @@ def test_valid(
             bytes([0]) * 287,  # Just under minimum valid length
             id="input_too_short_by_1",
         ),
+        # Coordinates above modulus p cases.
+        pytest.param(
+            PointG2((Spec.P2.x[0] + Spec.P, Spec.P2.x[1]), Spec.P2.y) + Scalar(1),
+            id="x_c0_above_p_pos_0",
+        ),
+        pytest.param(
+            PointG2((Spec.P2.x[0], Spec.P2.x[1] + Spec.P), Spec.P2.y) + Scalar(1),
+            id="x_c1_above_p_pos_0",
+        ),
+        pytest.param(
+            PointG2(Spec.P2.x, (Spec.P2.y[0] + Spec.P, Spec.P2.y[1])) + Scalar(1),
+            id="y_c0_above_p_pos_0",
+        ),
+        pytest.param(
+            PointG2(Spec.P2.x, (Spec.P2.y[0], Spec.P2.y[1] + Spec.P)) + Scalar(1),
+            id="y_c1_above_p_pos_0",
+        ),
+        pytest.param(
+            Spec.G2
+            + Scalar(1)
+            + PointG2((Spec.P2.x[0] + Spec.P, Spec.P2.x[1]), Spec.P2.y)
+            + Scalar(0),
+            id="x_c0_above_p_pos_1",
+        ),
+        pytest.param(
+            Spec.G2
+            + Scalar(1)
+            + PointG2((Spec.P2.x[0], Spec.P2.x[1] + Spec.P), Spec.P2.y)
+            + Scalar(0),
+            id="x_c1_above_p_pos_1",
+        ),
+        pytest.param(
+            Spec.G2
+            + Scalar(1)
+            + PointG2(Spec.P2.x, (Spec.P2.y[0] + Spec.P, Spec.P2.y[1]))
+            + Scalar(0),
+            id="y_c0_above_p_pos_1",
+        ),
+        pytest.param(
+            Spec.G2
+            + Scalar(1)
+            + PointG2(Spec.P2.x, (Spec.P2.y[0], Spec.P2.y[1] + Spec.P))
+            + Scalar(0),
+            id="y_c1_above_p_pos_1",
+        ),
     ],
     # Input length tests can be found in ./test_bls12_variable_length_input_contracts.py
 )

tests/prague/eip2537_bls_12_381_precompiles/test_bls12_pairing.py

@@ -267,6 +267,31 @@ def test_valid_multi_inf(
             Spec.G1 + G2_POINTS_NOT_IN_SUBGROUP[1],
             id="g1_plus_rand_not_in_subgroup_g2_1",
         ),
+        # Coordinates above modulus p cases.
+        pytest.param(
+            PointG1(Spec.P1.x + Spec.P, Spec.P1.y) + Spec.INF_G2,
+            id="g1_x_above_p_with_inf_g2",
+        ),
+        pytest.param(
+            PointG1(Spec.P1.x, Spec.P1.y + Spec.P) + Spec.INF_G2,
+            id="g1_y_above_p_with_inf_g2",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2((Spec.P2.x[0] + Spec.P, Spec.P2.x[1]), Spec.P2.y),
+            id="inf_g1_with_g2_x_c0_above_p",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2((Spec.P2.x[0], Spec.P2.x[1] + Spec.P), Spec.P2.y),
+            id="inf_g1_with_g2_x_c1_above_p",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2(Spec.P2.x, (Spec.P2.y[0] + Spec.P, Spec.P2.y[1])),
+            id="inf_g1_with_g2_y_c0_above_p",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2(Spec.P2.x, (Spec.P2.y[0], Spec.P2.y[1] + Spec.P)),
+            id="inf_g1_with_g2_y_c1_above_p",
+        ),
     ],
 )
 @pytest.mark.parametrize("expected_output", [Spec.INVALID], ids=[""])