Skip to content

Commit af735a9

Browse files
committed
chore(consume): remove non-functional hive command
* Remove broken `consume hive` command and related code paths * Update help tests to exclude removed command
1 parent c11576e commit af735a9

File tree

3 files changed

+3
-13
lines changed

3 files changed

+3
-13
lines changed

docs/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ Users can select any of the artifacts depending on their testing needs for their
101101

102102
### 📋 Misc
103103

104+
- 🔀 Remove non-functional `consume hive` command. `consume rlp` and `consume engine` to be used instead instead. ([#2008](https://github.com/ethereum/execution-spec-tests/pull/2008)).
104105
- ✨ Add pypy3.11 support ([#1854](https://github.com/ethereum/execution-spec-tests/pull/1854)).
105106
- 🔀 Use only relative imports in `tests/` directory ([#1848](https://github.com/ethereum/execution-spec-tests/pull/1848)).
106107
- 🔀 Convert absolute imports to relative imports in `src/` directory for better code maintainability ([#1907](https://github.com/ethereum/execution-spec-tests/pull/1907)).

src/cli/pytest_commands/consume.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,7 @@ def create_consume_command(
3939
def get_command_logic_test_paths(command_name: str, is_hive: bool) -> List[Path]:
4040
"""Determine the command paths based on the command name and hive flag."""
4141
base_path = Path("pytest_plugins/consume")
42-
if command_name == "hive":
43-
commands = ["rlp", "engine"]
44-
command_logic_test_paths = [
45-
base_path / "simulators" / "simulator_logic" / f"test_via_{cmd}.py" for cmd in commands
46-
]
47-
elif command_name in ["engine", "rlp"]:
42+
if command_name in ["engine", "rlp"]:
4843
command_logic_test_paths = [
4944
base_path / "simulators" / "simulator_logic" / f"test_via_{command_name}.py"
5045
]
@@ -117,12 +112,6 @@ def sync() -> None:
117112
pass
118113

119114

120-
@consume_command(is_hive=True)
121-
def hive() -> None:
122-
"""Client consumes via all available hive methods (rlp, engine)."""
123-
pass
124-
125-
126115
@consume.command(
127116
context_settings={"ignore_unknown_options": True},
128117
)

src/pytest_plugins/help/tests/test_help.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def test_local_arguments_present_in_fill_help(pytester, help_flag):
4040
("direct", "--consume-help"),
4141
("rlp", "--consume-help"),
4242
("engine", "--consume-help"),
43-
("hive", "--consume-help"),
43+
("sync", "--consume-help"),
4444
],
4545
)
4646
def test_local_arguments_present_in_base_consume_help(pytester, help_flag, command):

0 commit comments

Comments
 (0)