Skip to content

Commit bf67cb7

Browse files
chore(consume): remove consume hive command (#2008)
Co-authored-by: danceratopz <[email protected]>
1 parent cfd8338 commit bf67cb7

File tree

3 files changed

+2
-13
lines changed

3 files changed

+2
-13
lines changed

docs/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ Users can select any of the artifacts depending on their testing needs for their
9393
- 🔀 Refactor consume simulator architecture to use explicit pytest plugin structure with forward-looking architecture ([#1801](https://github.com/ethereum/execution-spec-tests/pull/1801)).
9494
- 🔀 Add exponential retry logic to initial fcu within consume engine ([#1815](https://github.com/ethereum/execution-spec-tests/pull/1815)).
9595
- ✨ Add `consume sync` command to test client synchronization capabilities by having one client sync from another via Engine API and P2P networking ([#2007](https://github.com/ethereum/execution-spec-tests/pull/2007)).
96+
- 💥 Removed the `consume hive` command, this was a convenience command that ran `consume rlp` and `consume engine` in one pytest session; the individual commands should now be used instead ([#2008](https://github.com/ethereum/execution-spec-tests/pull/2008)).
9697

9798
#### `execute`
9899

src/cli/pytest_commands/consume.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,7 @@ def create_consume_command(
3939
def get_command_logic_test_paths(command_name: str, is_hive: bool) -> List[Path]:
4040
"""Determine the command paths based on the command name and hive flag."""
4141
base_path = Path("pytest_plugins/consume")
42-
if command_name == "hive":
43-
commands = ["rlp", "engine"]
44-
command_logic_test_paths = [
45-
base_path / "simulators" / "simulator_logic" / f"test_via_{cmd}.py" for cmd in commands
46-
]
47-
elif command_name in ["engine", "rlp"]:
42+
if command_name in ["engine", "rlp"]:
4843
command_logic_test_paths = [
4944
base_path / "simulators" / "simulator_logic" / f"test_via_{command_name}.py"
5045
]
@@ -117,12 +112,6 @@ def sync() -> None:
117112
pass
118113

119114

120-
@consume_command(is_hive=True)
121-
def hive() -> None:
122-
"""Client consumes via all available hive methods (rlp, engine)."""
123-
pass
124-
125-
126115
@consume.command(
127116
context_settings={"ignore_unknown_options": True},
128117
)

src/pytest_plugins/help/tests/test_help.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ def test_local_arguments_present_in_fill_help(pytester, help_flag):
4040
("direct", "--consume-help"),
4141
("rlp", "--consume-help"),
4242
("engine", "--consume-help"),
43-
("hive", "--consume-help"),
4443
],
4544
)
4645
def test_local_arguments_present_in_base_consume_help(pytester, help_flag, command):

0 commit comments

Comments
 (0)