refactor(all): Enforce all execution-specs mypy rules (#2281)

* refactor(pyproject): Enforce all execution-specs mypy rules

* refactor(base_types): Enforce all execution-specs mypy rules

* refactor(types): Enforce all execution-specs mypy rules

* refactor(vm): Enforce all execution-specs mypy rules

* refactor(forks): Enforce all execution-specs mypy rules

* refactor(tests/shanghai): Enforce all execution-specs mypy rules

* refactor(fixtures): Enforce all execution-specs mypy rules

* refactor(tests/benchmark): Enforce all execution-specs mypy rules

* refactor(tests/osaka): Enforce all execution-specs mypy rules

refactor(tests/osaka): More fixes

* refactor(tests/prague): Enforce all execution-specs mypy rules

refactor(tests/prague): More fixes

* refactor(tests/cancun): Enforce all execution-specs mypy rules

* refactor(tests/homestead): Enforce all execution-specs mypy rules

* refactor(tests/frontier): Enforce all execution-specs mypy rules

* refactor(tests/istanbul): Enforce all execution-specs mypy rules

* refactor(tests/constantinople): Enforce all execution-specs mypy rules

* refactor(tests/berlin): Enforce all execution-specs mypy rules

* refactor(tests/byzantium): Enforce all execution-specs mypy rules

* refactor(tests/paris): Enforce all execution-specs mypy rules

* refactor(tests/amsterdam): Enforce all execution-specs mypy rules

* refactor(tests/unscheduled): Enforce all execution-specs mypy rules

* fix linting issue

* refactor(src/ethereum_test_exceptions): Enforce all execution-specs mypy rules

* refactor(.github/scripts): Enforce all execution-specs mypy rules

* fix typing issue after rebase

* refactor(src/ethereum_test_tools): Enforce all execution-specs mypy rules

* refactor(src/config): Enforce all execution-specs mypy rules

* refactor(src/ethereum_test_checklists): Enforce all execution-specs mypy rules

* refactor(src/ethereum_test_rpc): Enforce all execution-specs mypy rules

* fix issue after rebase

* refactor(specs): Enforce all execution-specs mypy rules

* refactor(src/cli,src/ethereum_clis): Enforce all execution-specs mypy rule

refactor(clis): More fixes

* refactor(src/ethereum_test_execution): Enforce all execution-specs mypy rule

* refactor(plugins/forks): Enforce all execution-specs mypy rules

refactor(plugins/forks): More fixes

* refactor(plugins/logging): Enforce all execution-specs mypy rules

* refactor(src/pytest_plugins/solc): Enforce all execution-specs mypy rule

refactor(plugins/solc): More fixes

* refactor(src/pytest_plugins/help): Enforce all execution-specs mypy rule

* refactor(src/pytest_plugins/eels_resolver): Enforce all execution-specs mypy rule

refactor(plugins/eels_resolver): More fixes

* refactor(src/pytest_plugins/fix_package_test_path): Enforce all execution-specs mypy rule

* refactor(src/pytest_plugins/execute): Enforce all execution-specs mypy rule

refactor(plugins/execute): More fixes

* refactor(plugins/consume): Enforce all execution-specs mypy rules

* refactor(src/pytest_plugins/filler): Enforce all execution-specs mypy rule

refactor(plugins/filler): More fixes

* refactor(src/pytest_plugins/spec_version_checker): Enforce all execution-specs mypy rule

* refactor(src/pytest_plugins/pytest_hive): Enforce all execution-specs mypy rule

* refactor(plugins/shared): Enforce all execution-specs mypy rules

---------

Co-authored-by: LouisTsai <[email protected]>
Co-authored-by: fselmo <[email protected]>

Author: 3 people

.github/scripts/generate_eip_report.py

@@ -8,6 +8,7 @@
 import sys
 import textwrap
 from string import Template
+from typing import List, Tuple
 
 # Report template using textwrap.dedent for clean multiline strings
 REPORT_TEMPLATE = Template(
@@ -49,7 +50,7 @@
 )
 
 
-def extract_failures(output):
+def extract_failures(output: str) -> List[Tuple[str, str, str, str, str, str]]:
     """Extract failure information from the output using regex."""
     failures = []
 
@@ -88,7 +89,7 @@ def extract_failures(output):
     return failures
 
 
-def generate_summary_table(failures):
+def generate_summary_table(failures: List[Tuple[str, str, str, str, str, str]]) -> str:
     """Generate a markdown summary table from the failures."""
     rows = []
     for file_path, eip_num, _, eip_link, ref_version, latest_version in failures:
@@ -98,7 +99,7 @@ def generate_summary_table(failures):
     return "\n".join(rows)
 
 
-def main():
+def main() -> None:
     """Generate the report."""
     if len(sys.argv) < 2:
         print("Usage: uv run python generate_eip_report.py <input_file> [output_file]")

.github/scripts/get_release_props.py

@@ -17,7 +17,7 @@
 
 @click.command()
 @click.argument("release", required=True)
-def get_release_props(release):
+def get_release_props(release: str) -> None:
     """Extract the properties from the YAML file for a given release."""
     with open(RELEASE_PROPS_FILE) as f:
         data = yaml.safe_load(f)

pyproject.toml

@@ -190,9 +190,10 @@ exclude = [
     '^site/',
 ]
 plugins = ["pydantic.mypy"]
-# more rules
 namespace_packages = true
 strict_optional = true
+disallow_incomplete_defs = true
+disallow_untyped_defs = true
 strict_bytes = true
 warn_unused_ignores = true
 warn_unused_configs = true

src/cli/check_fixtures.py

@@ -23,7 +23,7 @@ def count_json_files_exclude_index(start_path: Path) -> int:
     return json_file_count
 
 
-def check_json(json_file_path: Path):
+def check_json(json_file_path: Path) -> None:
     """
     Check all fixtures in the specified json file:
     1. Load the json file into a pydantic model. This checks there are no
@@ -50,11 +50,15 @@ def check_json(json_file_path: Path):
             )
         if "hash" in fixture.info and fixture.info["hash"] != original_hash:
             info_hash = fixture.info["hash"]
+            info_hash_str = str(info_hash) if not isinstance(info_hash, str) else info_hash
             raise HashMismatchExceptionError(
                 original_hash,
-                fixture.info["hash"],
-                message=f"Fixture info['hash'] does not match calculated hash for {fixture_name}:"
-                f"'{info_hash}' != '{original_hash}'",
+                info_hash_str,
+                message=(
+                    f"Fixture info['hash'] does not match calculated "
+                    f"hash for {fixture_name}: '{info_hash}' != "
+                    f"'{original_hash}'"
+                ),
             )
 
 
@@ -86,9 +90,9 @@ def check_json(json_file_path: Path):
     expose_value=True,
     help="Stop and raise any exceptions encountered while checking fixtures.",
 )
-def check_fixtures(input_str: str, quiet_mode: bool, stop_on_error: bool):
+def check_fixtures(input_str: str, quiet_mode: bool, stop_on_error: bool) -> bool:
     """
-    Perform some checks on the fixtures contained in the specified directory.
+    Perform checks on fixtures in the specified directory.
     """
     input_path = Path(input_str)
     success = True

src/cli/compare_fixtures.py

@@ -65,7 +65,7 @@ def pop_all_by_hash(index: IndexFile, fixture_hash: HexNumber) -> List[TestCaseI
     return test_cases
 
 
-def remove_fixture_from_file(file: Path, test_case_id: str):
+def remove_fixture_from_file(file: Path, test_case_id: str) -> None:
     """Remove a single fixture by its ID from a generic fixture file."""
     try:
         # Load from json to a dict
@@ -78,7 +78,7 @@ def remove_fixture_from_file(file: Path, test_case_id: str):
         raise KeyError(f"Test case {test_case_id} not found in {file}") from None
 
 
-def batch_remove_fixtures_from_files(removals_by_file):
+def batch_remove_fixtures_from_files(removals_by_file: dict[Path, list[str]]) -> None:
     """Batch process file removals to minimize I/O."""
     for file_path, test_case_ids in removals_by_file.items():
         try:
@@ -93,10 +93,9 @@ def batch_remove_fixtures_from_files(removals_by_file):
             print(f"Error processing {file_path}: {e}")
 
 
-def rewrite_index(folder: Path, index: IndexFile, dry_run: bool):
+def rewrite_index(folder: Path, index: IndexFile, dry_run: bool) -> None:
     """
-    Rewrite the index to the correct index file, or if the test count was
-    reduced to zero, the entire directory is deleted.
+    Rewrite index to file, or if test count is zero, delete directory.
     """
     if len(index.test_cases) > 0:
         # Just rewrite the index
@@ -129,9 +128,9 @@ def main(
     patch: Path,
     dry_run: bool,
     abort_on_empty_patch: bool,
-):
+) -> None:
     """
-    Compare two fixture folders and remove duplicates based on fixture hashes.
+    Compare two folders and remove duplicates based on fixture hashes.
     """
     try:
         # Load indices

src/cli/diff_opcode_counts.py

@@ -128,8 +128,8 @@ def main(
     show_common: bool,
     show_missing: bool,
     remove_from_fixture_names: List[str],
-):
-    """Crawl two folders, compare and print the opcode count diffs."""
+) -> None:
+    """Crawl two folders, compare and print opcode count diffs."""
     print(f"Loading opcode counts from {base}...")
     opcode_counts1 = load_all_opcode_counts(base, remove_from_fixture_names)
     print(f"Found {len(opcode_counts1)} fixtures with opcode counts")

src/cli/eest/cli.py

@@ -9,8 +9,13 @@
 from .make.cli import make
 
 
-@click.group(context_settings={"help_option_names": ["-h", "--help"], "max_content_width": 120})
-def eest():
+@click.group(
+    context_settings={
+        "help_option_names": ["-h", "--help"],
+        "max_content_width": 120,
+    }
+)
+def eest() -> None:
     """`eest` is a CLI tool that helps with routine tasks."""
     pass
 

src/cli/eest/commands/clean.py

@@ -16,7 +16,7 @@
 )
 @click.option("--dry-run", is_flag=True, help="Simulate the cleanup without removing files.")
 @click.option("-v", "--verbose", is_flag=True, help="Show verbose output.")
-def clean(all_files: bool, dry_run: bool, verbose: bool):
+def clean(all_files: bool, dry_run: bool, verbose: bool) -> None:
     """
     Remove all generated files and directories from the repository.
 

src/cli/eest/commands/info.py

@@ -30,7 +30,7 @@ def get_uv_version() -> str:
 
 
 @click.command(name="info")
-def info():
+def info() -> None:
     """Display EEST and system information."""
     # Format headers
     title = click.style("EEST", fg="green", bold=True)

src/cli/eest/make/cli.py

@@ -17,7 +17,7 @@
 
 
 @click.group(short_help="Generate project files.")
-def make():
+def make() -> None:
     """Generate project files."""
     pass