feat(tests): add bls top bytes boundary edge cases (#2085)

spencer-tb · marioevz · web-flow · commit dd5efdd7938f · 2025-08-29T20:33:43.000+02:00
* feat(tests): add bls top bytes boundary edge cases.

* Use `MAX_FP_BIT_SET` constant and add more cases

---------

Co-authored-by: Mario Vega &lt;marioevz@gmail.com&gt;
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/spec.py b/tests/prague/eip2537_bls_12_381_precompiles/spec.py
@@ -135,6 +135,7 @@ class Spec:
     P = (X - 1) ** 2 * Q // 3 + X
     LEN_PER_PAIR = len(PointG1() + PointG2())
     MSM_MULTIPLIER = 1_000
+    MAX_FP_BIT_SET = 1 << (48 * 8)
     # fmt: off
     G1MSM_DISCOUNT_TABLE = [
         0,
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1add.py b/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1add.py
@@ -341,6 +341,14 @@ def test_valid(
             b"\xc0" + b"\x00" * 47 + b"\xc0" + b"\x00" * 47,
             id="comp_instead_of_uncomp",
         ),
+        pytest.param(
+            PointG1(Spec.P1.x | Spec.MAX_FP_BIT_SET, Spec.P1.y) + Spec.P1,
+            id="non_zero_byte_16_boundary_violation_x",
+        ),
+        pytest.param(
+            PointG1(Spec.P1.x, Spec.P1.y | Spec.MAX_FP_BIT_SET) + Spec.P1,
+            id="non_zero_byte_16_boundary_violation_y",
+        ),
         # Not on the curve cases using random generated points.
         pytest.param(
             G1_POINTS_NOT_ON_CURVE[0] + Spec.INF_G1,
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1mul.py b/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1mul.py
@@ -249,6 +249,14 @@ def test_valid(
             Scalar(1) + Scalar(1),
             id="two_scalars",
         ),
+        pytest.param(
+            PointG1(Spec.P1.x | Spec.MAX_FP_BIT_SET, Spec.P1.y) + Scalar(1),
+            id="non_zero_byte_16_boundary_violation_x",
+        ),
+        pytest.param(
+            PointG1(Spec.P1.x, Spec.P1.y | Spec.MAX_FP_BIT_SET) + Scalar(1),
+            id="non_zero_byte_16_boundary_violation_y",
+        ),
         # Not in the r-order subgroup test cases.
         pytest.param(
             Spec.P1_NOT_IN_SUBGROUP + Scalar(1),
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g2add.py b/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g2add.py
@@ -365,6 +365,22 @@ def test_valid(
             bytes(Spec.G2) + bytes(Spec.G2)[128:],
             id="mixed_g1_g2_points",
         ),
+        pytest.param(
+            PointG2((Spec.P2.x[0] | Spec.MAX_FP_BIT_SET, Spec.P2.x[1]), Spec.P2.y) + Spec.P2,
+            id="non_zero_byte_16_boundary_violation_x1",
+        ),
+        pytest.param(
+            PointG2((Spec.P2.x[0], Spec.P2.x[1] | Spec.MAX_FP_BIT_SET), Spec.P2.y) + Spec.P2,
+            id="non_zero_byte_16_boundary_violation_x2",
+        ),
+        pytest.param(
+            PointG2(Spec.P2.x, (Spec.P2.y[0] | Spec.MAX_FP_BIT_SET, Spec.P2.y[1])) + Spec.P2,
+            id="non_zero_byte_16_boundary_violation_y1",
+        ),
+        pytest.param(
+            PointG2(Spec.P2.x, (Spec.P2.y[0], Spec.P2.y[1] | Spec.MAX_FP_BIT_SET)) + Spec.P2,
+            id="non_zero_byte_16_boundary_violation_y2",
+        ),
         # Not on the curve cases using random generated points.
         pytest.param(
             G2_POINTS_NOT_ON_CURVE[0] + Spec.INF_G2,
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g2mul.py b/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g2mul.py
@@ -267,6 +267,22 @@ def test_valid(
             bytes(Spec.G2) + bytes(Scalar(0))[128:],
             id="mixed_g2_scalar_truncated",
         ),
+        pytest.param(
+            PointG2((Spec.P2.x[0] | Spec.MAX_FP_BIT_SET, Spec.P2.x[1]), Spec.P2.y) + Scalar(1),
+            id="non_zero_byte_16_boundary_violation_x1",
+        ),
+        pytest.param(
+            PointG2((Spec.P2.x[0], Spec.P2.x[1] | Spec.MAX_FP_BIT_SET), Spec.P2.y) + Scalar(1),
+            id="non_zero_byte_16_boundary_violation_x2",
+        ),
+        pytest.param(
+            PointG2(Spec.P2.x, (Spec.P2.y[0] | Spec.MAX_FP_BIT_SET, Spec.P2.y[1])) + Scalar(1),
+            id="non_zero_byte_16_boundary_violation_y1",
+        ),
+        pytest.param(
+            PointG2(Spec.P2.x, (Spec.P2.y[0], Spec.P2.y[1] | Spec.MAX_FP_BIT_SET)) + Scalar(1),
+            id="non_zero_byte_16_boundary_violation_y2",
+        ),
         # Not in the r-order subgroup test cases.
         pytest.param(
             Spec.P2_NOT_IN_SUBGROUP + Scalar(0),
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_map_fp2_to_g2.py b/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_map_fp2_to_g2.py
@@ -142,6 +142,14 @@ def test_isogeny_kernel_values(
         pytest.param(bytes(FP2((0, 0)))[:95], id="fp2_one_byte_short"),
         pytest.param(bytes([0xFF]) + bytes(FP2((0, 0)))[1:], id="fp2_invalid_first_byte"),
         pytest.param(Spec.INF_G2, id="g2_inf_input"),
+        pytest.param(
+            FP2(((Spec.P - 1) | Spec.MAX_FP_BIT_SET, Spec.P - 1)),
+            id="non_zero_byte_16_boundary_violation_c0",
+        ),
+        pytest.param(
+            FP2((Spec.P - 1, (Spec.P - 1) | Spec.MAX_FP_BIT_SET)),
+            id="non_zero_byte_16_boundary_violation_c1",
+        ),
     ],
 )
 @pytest.mark.parametrize("expected_output", [Spec.INVALID], ids=[""])
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_map_fp_to_g1.py b/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_map_fp_to_g1.py
@@ -121,6 +121,9 @@ def test_isogeny_kernel_values(
         pytest.param(bytes(FP(0))[:47], id="fp_one_byte_short"),
         pytest.param(bytes([0xFF]) + bytes(FP(0))[1:], id="fp_invalid_first_byte"),
         pytest.param(Spec.INF_G1, id="g1_inf_input"),
+        pytest.param(
+            FP((Spec.P - 1) | Spec.MAX_FP_BIT_SET), id="non_zero_byte_16_boundary_violation"
+        ),
     ],
 )
 @pytest.mark.parametrize("expected_output", [Spec.INVALID], ids=[""])
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_pairing.py b/tests/prague/eip2537_bls_12_381_precompiles/test_bls12_pairing.py
@@ -292,6 +292,31 @@ def test_valid_multi_inf(
             Spec.INF_G1 + PointG2(Spec.P2.x, (Spec.P2.y[0], Spec.P2.y[1] + Spec.P)),
             id="inf_g1_with_g2_y_c1_above_p",
         ),
+        # Non-zero byte 16 boundary violation test cases.
+        pytest.param(
+            PointG1(Spec.G1.x | Spec.MAX_FP_BIT_SET, Spec.G1.y) + Spec.INF_G2,
+            id="non_zero_byte_16_boundary_violation_g1_x",
+        ),
+        pytest.param(
+            PointG1(Spec.G1.x, Spec.G1.y | Spec.MAX_FP_BIT_SET) + Spec.INF_G2,
+            id="non_zero_byte_16_boundary_violation_g1_y",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2((Spec.G2.x[0] | Spec.MAX_FP_BIT_SET, Spec.G2.x[1]), Spec.G2.y),
+            id="non_zero_byte_16_boundary_violation_g1_x1",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2((Spec.G2.x[0], Spec.G2.x[1] | Spec.MAX_FP_BIT_SET), Spec.G2.y),
+            id="non_zero_byte_16_boundary_violation_g1_x2",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2(Spec.G2.x, (Spec.G2.y[0] | Spec.MAX_FP_BIT_SET, Spec.G2.y[1])),
+            id="non_zero_byte_16_boundary_violation_g1_y1",
+        ),
+        pytest.param(
+            Spec.INF_G1 + PointG2(Spec.G2.x, (Spec.G2.y[0], Spec.G2.y[1] | Spec.MAX_FP_BIT_SET)),
+            id="non_zero_byte_16_boundary_violation_g1_y2",
+        ),
     ],
 )
 @pytest.mark.parametrize("expected_output", [Spec.INVALID], ids=[""])
diff --git a/tests/prague/eip2537_bls_12_381_precompiles/vectors/fail-add_G1_bls.json b/tests/prague/eip2537_bls_12_381_precompiles/vectors/fail-add_G1_bls.json
@@ -28,5 +28,10 @@
     "Input": "1000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000008b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e100000000000000000000000000000000112b98340eee2777cc3c14163dea3ec97977ac3dc5c70da32e6e87578f44912e902ccef9efe28d4a78b8999dfbca942600000000000000000000000000000000186b28d92356c4dfec4b5201ad099dbdede3781f8998ddf929b4cd7756192185ca7b8f4ef7088f813270ac3d48868a21",
     "ExpectedError": "invalid field element top bytes",
     "Name": "bls_g1add_violate_top_bytes"
+  },
+  {
+    "Input": "0000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000108b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e10000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000008b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e1",
+    "ExpectedError": "invalid field element top bytes",
+    "Name": "bls_g1add_top16_bytes_boundary_violation"
   }
 ]

Original file line number	Diff line number	Diff line change
`@@ -28,5 +28,10 @@`
`28`	`28`	"Input": "1000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000008b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e100000000000000000000000000000000112b98340eee2777cc3c14163dea3ec97977ac3dc5c70da32e6e87578f44912e902ccef9efe28d4a78b8999dfbca942600000000000000000000000000000000186b28d92356c4dfec4b5201ad099dbdede3781f8998ddf929b4cd7756192185ca7b8f4ef7088f813270ac3d48868a21",
`29`	`29`	`"ExpectedError": "invalid field element top bytes",`
`30`	`30`	`"Name": "bls_g1add_violate_top_bytes"`
	`31`	`+ },`
	`32`	`+ {`
	`33`	+ "Input": "0000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000108b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e10000000000000000000000000000000017f1d3a73197d7942695638c4fa9ac0fc3688c4f9774b905a14e3a3f171bac586c55e83ff97a1aeffb3af00adb22c6bb0000000000000000000000000000000008b3f481e3aaa0f1a09e30ed741d8ae4fcf5e095d5d00af600db18cb2c04b3edd03cc744a2888ae40caa232946c5e7e1",
	`34`	`+ "ExpectedError": "invalid field element top bytes",`
	`35`	`+ "Name": "bls_g1add_top16_bytes_boundary_violation"`
`31`	`36`	`}`
`32`	`37`	`]`