fix(tests): EOF - Align EOFCREATE args with EXT*CALL (#1274)

Author: pdobacz

src/ethereum_test_vm/opcode.py

@@ -5092,12 +5092,12 @@ class Opcodes(Opcode, Enum):
         popped_stack_items=4,
         pushed_stack_items=1,
         data_portion_length=1,
-        kwargs=["value", "salt", "input_offset", "input_size"],
+        kwargs=["salt", "input_offset", "input_size", "value"],
     )
     """
     !!! Note: This opcode is under development
 
-    EOFCREATE[initcontainer_index] (value, salt, input_offset, input_size)
+    EOFCREATE[initcontainer_index] (salt, input_offset, input_size, value)
     ----
 
     Description

tests/osaka/eip7692_eof_v1/eip7620_eof_create/test_eofcreate.py

@@ -275,7 +275,7 @@ def test_calldata(state_test: StateTestFiller, pre: Alloc):
             sections=[
                 Section.Code(
                     code=Op.MSTORE(0, Op.PUSH32(calldata))
-                    + Op.SSTORE(slot_create_address, Op.EOFCREATE[0](0, 0, 0, calldata_size))
+                    + Op.SSTORE(slot_create_address, Op.EOFCREATE[0](input_size=calldata_size))
                     + Op.STOP,
                 ),
                 Section.Container(container=initcode_subcontainer),
@@ -497,7 +497,7 @@ def test_address_collision(
                 Section.Code(
                     code=Op.SSTORE(slot_create_address, Op.EOFCREATE[0](0, 0, 0, 0))
                     + Op.SSTORE(slot_create_address_2, Op.EOFCREATE[0](0, 0, 0, 0))
-                    + Op.SSTORE(slot_create_address_3, Op.EOFCREATE[0](0, 1, 0, 0))
+                    + Op.SSTORE(slot_create_address_3, Op.EOFCREATE[0](salt=1))
                     + Op.SSTORE(slot_code_worked, value_code_worked)
                     + Op.STOP,
                 ),
@@ -556,7 +556,9 @@ def test_eofcreate_revert_eof_returndata(
             sections=[
                 Section.Code(
                     code=Op.CALLDATACOPY(0, 0, Op.CALLDATASIZE)
-                    + Op.SSTORE(slot_create_address, Op.EOFCREATE[0](0, salt, 0, Op.CALLDATASIZE))
+                    + Op.SSTORE(
+                        slot_create_address, Op.EOFCREATE[0](salt=salt, input_size=Op.CALLDATASIZE)
+                    )
                     + Op.SSTORE(slot_returndata_size, Op.RETURNDATASIZE)
                     + Op.STOP,
                 ),
@@ -688,7 +690,7 @@ def test_eofcreate_context(
         sections=[
             Section.Code(
                 Op.SSTORE(slot_code_worked, value_code_worked)
-                + Op.EOFCREATE[0](eofcreate_value, 0, 0, 0)
+                + Op.EOFCREATE[0](value=eofcreate_value)
                 + Op.STOP
             ),
             Section.Container(initcode),

tests/osaka/eip7692_eof_v1/eip7620_eof_create/test_eofcreate_failures.py

@@ -291,7 +291,7 @@ def test_auxdata_size_failures(state_test: StateTestFiller, pre: Alloc, auxdata_
             sections=[
                 Section.Code(
                     code=Op.CALLDATACOPY(0, 0, Op.CALLDATASIZE)
-                    + Op.SSTORE(slot_create_address, Op.EOFCREATE[0](0, 0, 0, Op.CALLDATASIZE))
+                    + Op.SSTORE(slot_create_address, Op.EOFCREATE[0](input_size=Op.CALLDATASIZE))
                     + Op.SSTORE(slot_code_worked, value_code_worked)
                     + Op.STOP,
                 ),
@@ -347,7 +347,7 @@ def test_eofcreate_insufficient_stipend(
     initcode_container = Container(
         sections=[
             Section.Code(
-                code=Op.SSTORE(slot_create_address, Op.EOFCREATE[0](value, 0, 0, 0))
+                code=Op.SSTORE(slot_create_address, Op.EOFCREATE[0](value=value))
                 + Op.SSTORE(slot_code_worked, value_code_worked)
                 + Op.STOP,
             ),
@@ -451,7 +451,7 @@ def test_insufficient_gas_memory_expansion(
     initcode_container = Container(
         sections=[
             Section.Code(
-                code=Op.SSTORE(slot_create_address, Op.EOFCREATE[0](0, 0, 0, auxdata_size))
+                code=Op.SSTORE(slot_create_address, Op.EOFCREATE[0](input_size=auxdata_size))
                 + Op.SSTORE(slot_code_should_fail, slot_code_worked)
                 + Op.STOP,
             ),

tests/osaka/eip7692_eof_v1/eip7620_eof_create/test_gas.py

@@ -140,10 +140,10 @@ def test_eofcreate_gas(
         state_test,
         Environment(),
         pre,
-        setup_code=Op.PUSH1(mem_expansion_bytes)
+        setup_code=Op.PUSH32(value)
+        + Op.PUSH1(mem_expansion_bytes)
         + Op.PUSH0
-        + code_increment_counter
-        + Op.PUSH32(value),
+        + code_increment_counter,
         subject_code=Op.EOFCREATE[0],
         tear_down_code=Op.STOP,
         cold_gas=EOFCREATE_GAS