tests/static/state_tests/stEIP1559/lowGasPriceOldTypesFiller.yml failure to unexpected exception meessage

[marioevz]

After PR #1980, the only remaining failing static test, not only in Osaka but in all previous forks too, is tests/static/state_tests/stEIP1559/lowGasPriceOldTypesFiller.yml

E   ethereum_test_specs.helpers.UndefinedExecutionExceptionError: Exception mismatch on Transaction ({'index': 0, 'nonce': 1}):
E      What: Transaction exception mismatch!
E      Want: TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS
E       Got: "Failed transaction: InvalidBlock()"
E    No exception defined for error message got, please add it to ExecutionSpecsExceptionMapper

It requires a fix on the error message potentially.

cc @spencer-tb I remember there was a recent PR modifying exception messages, so this could potentially be one that we missed?

[spencer-tb]

A temporary solution is added to #1954. We will check clients pass the test with the expected error then update EELS afterwards accordingly. Cc-ing from discord.

@eels - how do you feel about returning:

raise InsufficientMaxFeePerGasError(
    tx.max_fee_per_gas, block_env.base_fee_per_gas
)

From London onwards here ?

Its so we can fill this test: #1981

It feels a bit counter intuitive but I think most clients will return this because EIP-1559 internally normalizes legacy transactions to treat gas price as max fee per gas.