Skip to content

🚧 wip(test): EIP-7928: Block-level Access Lists #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

🚧 wip(test): EIP-7928: Block-level Access Lists #1823

wants to merge 4 commits into from

Conversation

raxhvl
Copy link
Member

@raxhvl raxhvl commented Jul 1, 2025

🗒️ Description

🚧 wip tests for EIP-7928.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.

@raxhvl raxhvl added the scope:tests Scope: Changes EL client test cases in `./tests` label Jul 1, 2025
danceratopz
danceratopz reviewed Jul 1, 2025
View reviewed changes
@marioevz
Copy link
Member

marioevz commented Jul 1, 2025

It would be nice to have an update to https://github.com/ethereum/execution-spec-tests/blob/main/src/ethereum_test_fixtures/blockchain.py where we plan to include the BAL in the pydantic model to both the blockchain and blockchain-engine tests, to have a better idea on how this ends up in the fixture.

@marioevz
Copy link
Member

marioevz commented Jul 1, 2025

Another qs is whether the t8n should generate the BAL.

@raxhvl raxhvl mentioned this pull request Jul 2, 2025
Open
@raxhvl
Copy link
Member Author

raxhvl commented Jul 7, 2025

Another qs is whether the t8n should generate the BAL.

Yes t8n should generate BAL independently during execution verify against the from these tests.

@mirgee mirgee mentioned this pull request Aug 6, 2025
Open
5 tasks
@matkt matkt mentioned this pull request Aug 13, 2025
Open
@fselmo fselmo mentioned this pull request Aug 21, 2025
Open
8 tasks
@raxhvl
Copy link
Member Author

raxhvl commented Aug 26, 2025

Superseded by #2067

@raxhvl raxhvl closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz left review comments

@danceratopz danceratopz danceratopz left review comments

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raxhvl @marioevz @danceratopz