chore(tests): add modexp length mismatch functionality #2058
Conversation
spencer-tb
added
scope:tests
There was a problem hiding this comment.
This is still not fully consistent and I don't think you can reliably compute gas using this higher level structure. One reason is pointed out in the inline comment. Another reason is you can use raw_input= (and there are good reasons to do so) and then all the additional properties (e.g. length_base) are garbage. Same as the computed gas.
This precompile has ultimately complex input structure. If you want something reliable consider this: you can have reach set of constructors and/or constructor arguments for readability. But you should immediately build input bytes out of them. And the gas cost must be computed from bytes. EELS has it already so you can copy the code for start.
tests/osaka/eip7823_modexp_upper_bounds/test_modexp_upper_bounds.py
Outdated
Show resolved
Hide resolved
| @@ -86,6 +128,26 @@ def from_bytes(cls, input_data: Bytes | str) -> "ModExpInput": | |||
|
|
|||
| return cls(base=base, exponent=exponent, modulus=modulus, raw_input=input_data) | |||
|
|
|||
| @classmethod | |||
| def create_mismatch( | |||
There was a problem hiding this comment.
This feels a bit too much for me. I generally struggle with some data types in EEST which have a lot of interconnected options and flags.
This could be a normal constructor. And you can fix the properties directly in the constructor like:
length_base = declared_base_length if declared_base_length not None else len(base)
spencer-tb
force-pushed
the
modexp-length-override
branch
from
61c67db to
d30b8ec
Compare
|
Updated regarding the comments using the EELS like approach.. |
🗒️ Description
Aims to update the modexp helpers to allow for length mismatch tests.
Length mismatch tests can be added with the following, copied over and refactored from #2044.
🔗 Related Issues or PRs
Fixes #2043 (attemps to).
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.