eip7928: add SELFDESTRUCT OOG BAL test

Author: qu0b

tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py

@@ -373,6 +373,76 @@ def test_bal_self_destruct(
     )
 
 
+def test_bal_self_destruct_oog(
+    pre: Alloc,
+    blockchain_test: BlockchainTestFiller,
+) -> None:
+    """
+    Test that SELFDESTRUCT beneficiary is NOT included in BAL when OOG.
+
+    When SELFDESTRUCT runs out of gas, the operation fails and the beneficiary
+    address should NOT be added to the Block Access List.
+
+    This test:
+    1. Deploys a contract with SELFDESTRUCT bytecode
+    2. Calls the contract with limited gas so SELFDESTRUCT fails OOG
+    3. Verifies beneficiary is NOT in BAL (the CALL reverts, undoing BAL changes)
+
+    SELFDESTRUCT gas cost to cold new account: 5000 + 2600 + 25000 = 32600 gas
+    """
+    alice = pre.fund_eoa()
+
+    # Beneficiary address for SELFDESTRUCT
+    beneficiary = Address(0xBEEF)
+
+    # Contract: PUSH20 <beneficiary> SELFDESTRUCT
+    selfdestruct_code = Op.SELFDESTRUCT(beneficiary)
+    selfdestruct_contract = pre.deploy_contract(code=selfdestruct_code, balance=1000)
+
+    # Caller contract: CALL with limited gas to cause OOG on SELFDESTRUCT
+    # SELFDESTRUCT needs 32600 gas, we give it only 100
+    caller_code = (
+        Op.CALL(gas=100, address=selfdestruct_contract, value=0,
+                args_offset=0, args_size=0, ret_offset=0, ret_size=0)
+        + Op.STOP
+    )
+    caller_contract = pre.deploy_contract(code=caller_code)
+
+    tx = Transaction(
+        sender=alice,
+        to=caller_contract,
+        gas_limit=100_000,
+        gas_price=0xA,
+    )
+
+    # The inner CALL fails OOG, so SELFDESTRUCT doesn't complete.
+    # Beneficiary should NOT be in BAL.
+    block = Block(
+        txs=[tx],
+        expected_block_access_list=BlockAccessListExpectation(
+            account_expectations={
+                alice: BalAccountExpectation(
+                    nonce_changes=[BalNonceChange(tx_index=1, post_nonce=1)],
+                ),
+                caller_contract: BalAccountExpectation.empty(),
+                selfdestruct_contract: BalAccountExpectation.empty(),
+                # beneficiary should NOT appear - SELFDESTRUCT failed OOG
+            }
+        ),
+    )
+
+    blockchain_test(
+        pre=pre,
+        blocks=[block],
+        post={
+            alice: Account(nonce=1),
+            caller_contract: Account(code=caller_code),
+            # Contract still exists - SELFDESTRUCT failed
+            selfdestruct_contract: Account(balance=1000, code=selfdestruct_code),
+        },
+    )
+
+
 @pytest.mark.parametrize(
     "account_access_opcode",
     [

tests/amsterdam/eip7928_block_level_access_lists/test_cases.md

@@ -95,3 +95,4 @@
 | `test_selfdestruct_created_in_same_tx_with_revert` | Ensure BAL tracks selfdestruct with revert correctly (pre-Amsterdam test with BAL) | Contract created and selfdestructed in same tx with nested revert | BAL **MUST** track storage reads and balance changes for selfdestruct even with reverts | ✅ Completed |
 | `test_value_transfer_gas_calculation` | Ensure BAL correctly tracks OOG scenarios for CALL/CALLCODE/DELEGATECALL/STATICCALL (pre-Amsterdam test with BAL) | Nested calls with precise gas limits to test OOG behavior. For CALL with OOG: target account read for `is_account_alive` check. For CALLCODE/DELEGATECALL/STATICCALL with OOG: target account **NOT** read (OOG before state access) | For CALL: target in BAL even with OOG. For CALLCODE/DELEGATECALL/STATICCALL: target **NOT** in BAL when OOG (state access deferred until after gas check) | ✅ Completed |
 | `test_bal_cross_block_precompile_state_leak` | Ensure internal EVM state for precompile handling does not leak between blocks | Block 1: Alice calls RIPEMD-160 (0x03) with zero value (RIPEMD-160 must be pre-funded). Block 2: Bob's transaction triggers an exception (stack underflow). | BAL for Block 1 **MUST** include RIPEMD-160. BAL for Block 2 **MUST NOT** include RIPEMD-160 (never accessed in Block 2). Internal state from Parity Touch Bug (EIP-161) handling must be reset between blocks. | ✅ Completed |
+| `test_bal_self_destruct_oog` | Ensure BAL does not include SELFDESTRUCT beneficiary when operation fails due to OOG | Alice calls `Caller` contract which CALLs `SelfDestructContract` with limited gas (100). `SelfDestructContract` attempts SELFDESTRUCT to `Beneficiary`. SELFDESTRUCT requires 32600 gas (5000 base + 2600 cold + 25000 new account). | BAL **MUST** include Alice with `nonce_changes`, `Caller` with empty changes, `SelfDestructContract` with empty changes. BAL **MUST NOT** include `Beneficiary` (SELFDESTRUCT failed OOG, CALL reverted, BAL changes rolled back). Contract balance unchanged. | ✅ Completed |