force forks to deal with old headers

SamWilsn · SamWilsn · commit 5cbeb27d4889 · 2024-11-19T19:39:55.000-05:00
diff --git a/setup.cfg b/setup.cfg
@@ -116,7 +116,7 @@ install_requires =
     typing_extensions>=4
     py_ecc @ git+https://github.com/petertdavies/py_ecc.git@127184f4c57b1812da959586d0fe8f43bb1a2389
     ethereum-types>=0.2.1,<0.3
-    ethereum-rlp>=0.1.1,<0.2
+    ethereum-rlp>=0.1.2,<0.2
 
 [options.package_data]
 ethereum =
diff --git a/src/ethereum/arrow_glacier/blocks.py b/src/ethereum/arrow_glacier/blocks.py
@@ -64,7 +64,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Union[Bytes, LegacyTransaction], ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/arrow_glacier/fork.py b/src/ethereum/arrow_glacier/fork.py
@@ -537,7 +537,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Union[LegacyTransaction, Bytes], ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -728,7 +728,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/berlin/blocks.py b/src/ethereum/berlin/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Union[Bytes, LegacyTransaction], ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/berlin/fork.py b/src/ethereum/berlin/fork.py
@@ -421,7 +421,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Union[LegacyTransaction, Bytes], ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -607,7 +607,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/byzantium/blocks.py b/src/ethereum/byzantium/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/byzantium/fork.py b/src/ethereum/byzantium/fork.py
@@ -414,7 +414,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -597,7 +597,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/cancun/blocks.py b/src/ethereum/cancun/blocks.py
@@ -81,7 +81,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Union[Bytes, LegacyTransaction], ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
     withdrawals: Tuple[Withdrawal, ...]
 
 
diff --git a/src/ethereum/constantinople/blocks.py b/src/ethereum/constantinople/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/constantinople/fork.py b/src/ethereum/constantinople/fork.py
@@ -414,7 +414,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -597,7 +597,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/dao_fork/blocks.py b/src/ethereum/dao_fork/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/dao_fork/fork.py b/src/ethereum/dao_fork/fork.py
@@ -423,7 +423,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> ApplyBodyOutput:
     """
     Executes a block.
@@ -603,7 +603,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/frontier/blocks.py b/src/ethereum/frontier/blocks.py
@@ -11,6 +11,7 @@
 from dataclasses import dataclass
 from typing import Tuple
 
+from ethereum_rlp import rlp
 from ethereum_types.bytes import Bytes, Bytes8, Bytes32
 from ethereum_types.frozen import slotted_freezable
 from ethereum_types.numeric import U256, Uint
@@ -52,6 +53,15 @@ class Header:
 """
 
 
+def decode_header(raw_header: rlp.Simple) -> AnyHeader:
+    """
+    Convert `raw_header` from raw sequences and bytes to a structured block
+    header.
+    """
+    # Because frontier is the first fork, we know what type the header is.
+    return rlp.deserialize_to(Header, raw_header)
+
+
 @slotted_freezable
 @dataclass
 class Block:
@@ -61,7 +71,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Block
diff --git a/src/ethereum/gray_glacier/blocks.py b/src/ethereum/gray_glacier/blocks.py
@@ -64,7 +64,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Union[Bytes, LegacyTransaction], ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/gray_glacier/fork.py b/src/ethereum/gray_glacier/fork.py
@@ -537,7 +537,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Union[LegacyTransaction, Bytes], ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -728,7 +728,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/homestead/blocks.py b/src/ethereum/homestead/blocks.py
@@ -11,11 +11,13 @@
 from dataclasses import dataclass
 from typing import Tuple, Union
 
+from ethereum_rlp import rlp
 from ethereum_types.bytes import Bytes, Bytes8, Bytes32
 from ethereum_types.frozen import slotted_freezable
 from ethereum_types.numeric import U256, Uint
 from typing_extensions import TypeAlias
 
+from ethereum.exceptions import InvalidBlock
 from ethereum.frontier import blocks as previous_blocks
 
 from ..crypto.hash import Hash32
diff --git a/src/ethereum/homestead/fork.py b/src/ethereum/homestead/fork.py
@@ -405,7 +405,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> ApplyBodyOutput:
     """
     Executes a block.
@@ -585,7 +585,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/istanbul/blocks.py b/src/ethereum/istanbul/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/istanbul/fork.py b/src/ethereum/istanbul/fork.py
@@ -414,7 +414,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -598,7 +598,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/london/blocks.py b/src/ethereum/london/blocks.py
@@ -64,7 +64,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Union[Bytes, LegacyTransaction], ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/london/fork.py b/src/ethereum/london/fork.py
@@ -537,7 +537,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Union[LegacyTransaction, Bytes], ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -728,7 +728,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/muir_glacier/blocks.py b/src/ethereum/muir_glacier/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/muir_glacier/fork.py b/src/ethereum/muir_glacier/fork.py
@@ -414,7 +414,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -598,7 +598,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/paris/blocks.py b/src/ethereum/paris/blocks.py
@@ -64,7 +64,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Union[Bytes, LegacyTransaction], ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/shanghai/blocks.py b/src/ethereum/shanghai/blocks.py
@@ -78,7 +78,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Union[Bytes, LegacyTransaction], ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
     withdrawals: Tuple[Withdrawal, ...]
 
 
diff --git a/src/ethereum/spurious_dragon/blocks.py b/src/ethereum/spurious_dragon/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/spurious_dragon/fork.py b/src/ethereum/spurious_dragon/fork.py
@@ -410,7 +410,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
     chain_id: U64,
 ) -> ApplyBodyOutput:
     """
@@ -593,7 +593,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum/tangerine_whistle/blocks.py b/src/ethereum/tangerine_whistle/blocks.py
@@ -63,7 +63,7 @@ class Block:
 
     header: Header
     transactions: Tuple[Transaction, ...]
-    ommers: Tuple[Header, ...]
+    ommers: Tuple[AnyHeader, ...]
 
 
 AnyBlock: TypeAlias = Union[previous_blocks.AnyBlock, Block]
diff --git a/src/ethereum/tangerine_whistle/fork.py b/src/ethereum/tangerine_whistle/fork.py
@@ -405,7 +405,7 @@ def apply_body(
     block_time: U256,
     block_difficulty: Uint,
     transactions: Tuple[Transaction, ...],
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> ApplyBodyOutput:
     """
     Executes a block.
@@ -585,7 +585,7 @@ def pay_rewards(
     state: State,
     block_number: Uint,
     coinbase: Address,
-    ommers: Tuple[Header, ...],
+    ommers: Tuple[AnyHeader, ...],
 ) -> None:
     """
     Pay rewards to the block miner as well as the ommers miners.
diff --git a/src/ethereum_spec_tools/evm_tools/loaders/fork_loader.py b/src/ethereum_spec_tools/evm_tools/loaders/fork_loader.py
diff --git a/tests/helpers/load_state_tests.py b/tests/helpers/load_state_tests.py
diff --git a/tests/homestead/test_rlp.py b/tests/homestead/test_rlp.py
