Skip to content

Commit c60a67b

Browse files
Carsons-EelsSamWilsn
authored andcommitted
Update codecov
- Exclude *glacier & DAO forks from coverage - Add codecov badge to README
1 parent 42382b5 commit c60a67b

File tree

7 files changed

+18
-6
lines changed

7 files changed

+18
-6
lines changed

EIP_AUTHORS_MANUAL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This document outlines the process of specifying and testing EIPs for the Ethere
66
| ------------------ | ----------- | ------- |
77
| _Pre‑Draft_ | Prospective EIP author conceives of an idea for an improvement to Ethereum, and discusses with the community. | <ul><li>Vague Consensus on [Ethereum Magicians][0]</li></ul> |
88
| **Draft** | <p>EIP author writes a technical human-language document describing the improvement, initially in broad strokes and becoming more specific over time.</p><p>Concurrently, they develop a Python reference implementation to make the EIP executable and identify any immediate/obvious implementation issues. For example, the EIP may not be compatible with some detail of the current Ethereum Virtual Machine.</p><p>Finally for this stage, the author begins to write test schemes for the EIP. Having the reference implementation should help identify the various logical flows to test and thus feed into more robust testing. Once the test schemes are written, the reference implementation can then be used to fill the tests and generate the test vectors.</p> | <ul><li>Complete (but not final) document in [EIPs Repository][1]</li><li>Reference Implementation in [EELS][2]</li><li>Initial Tests in [EEST][3]</li></ul> |
9-
| **Review** | <p>The broader Ethereum community discusses and provides input on the proposal.</p><p>Although the feedback from the community can be sought at all lifecycle stages, having a reference implementation and tests act as a good bridge between research and client implemtation. It also helps core developers (who have limited time and resources) to understand the EIP better and provide more informed feedback.</p> | <ul><li>Complete &amp; final document in the [EIPs Repository][1]</li><li>Comprehensive tests in [EEST][3]</li></ul>
9+
| **Review** | <p>The broader Ethereum community discusses and provides input on the proposal.</p><p>Although the feedback from the community can be sought at all lifecycle stages, having a reference implementation and tests act as a good bridge between research and client implementation. It also helps core developers (who have limited time and resources) to understand the EIP better and provide more informed feedback.</p> | <ul><li>Complete &amp; final document in the [EIPs Repository][1]</li><li>Comprehensive tests in [EEST][3]</li></ul>
1010
| **Last&nbsp;Call** | Usually after being nominated for inclusion in a fork, the EIP author signals that the proposal is effectively done and begins the last period for comments/discussion. | <ul><li>Complete reference implementation in [EELS][2]</li><li>Complete tests in [EEST][3]</li><li>Immutable proposal in [EIPs Repository][1]</li></ul> |
1111
| **Final** | The proposal is now immutable (cannot be changed) and exists for reference. | <ul><li>Mainnet client implementations</li></ul> |
1212

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Ethereum Execution Client Specifications
22

33
[![GitPOAP Badge](https://public-api.gitpoap.io/v1/repo/ethereum/execution-specs/badge)](https://www.gitpoap.io/gh/ethereum/execution-specs)
4+
[![codecov](https://codecov.io/gh/ethereum/execution-specs/graph/badge.svg?token=0LQZO56RTM)](https://codecov.io/gh/ethereum/execution-specs)
45

56
## Description
67

lists/evm/proposed-opcodes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
All Proposed Opcodes
22
--------------------
33

4-
All EIP propsoed opcodes that have not shipped. This includes all
4+
All EIP proposed opcodes that have not shipped. This includes all
55
unshipped EIPs, even withdrawn and non-viable proposals.
66

77
| EIP | Opcode | Name | Description |

lists/signature-types/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Reserved or Tentative.
1212

1313
| Prefix byte | Specs or Purpose |
1414
|-------------|------------------|
15-
| 0x00 | Reserved: indicates legacy (untyped) trancactions |
15+
| 0x00 | Reserved: indicates legacy (untyped) transactions |
1616
| 0x01 | Reserved: [EIP-2930](https://eips.ethereum.org/EIPS/eip-2930) *(available in Berlin)* |
1717
| 0x02 | Reserved: [EIP-1559](https://eips.ethereum.org/EIPS/eip-1559) *(available in London)* |
1818
| 0x03 | Reserved: [EIP-4844](https://eips.ethereum.org/EIPS/eip-4844) *(available in Cancun)* |
@@ -49,7 +49,7 @@ since a valid RLP-encoded transaction could not begin with it (prior to
4949
[EIP-2718](https://eips.ethereum.org/EIPS/eip-2718)) and represents the
5050
Bitcoin varint length of the string `"Ethereum signed Message:\n"`.
5151

52-
It was carried over from the technique Bitcon used to sign personal messages
52+
It was carried over from the technique Bitcoin used to sign personal messages
5353
(which uses `"\18Bitcoin signed message:\n"`) but was extended with
5454
[EIP-191](https://eips.ethereum.org/EIPS/eip-191), which effectively
5555
retconned signed personal messages into a scheme that is extensible,

network-upgrades/mainnet-upgrades/muir-glacier.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Ethereum achieves a consistent block time due to its' difficulty retargeting alg
2020

2121
The primary problem with the Ice Age is that it is included in the complex mechanism that targets block times, which is an entirely separate in purpose. What is worse is due to being intwined with that algorithm, it is very difficult to simulate or predict its effect on the network. To predict the impact of the ice age, you must both make assumptions about the difficulty of main-net in the future, and predict the effect of changes in difficulty to the impact on the ice age and thus block-times.
2222

23-
This fork will push back the Iceage as far as far as is reasonable and will give us time to update the Iceage to no longer have these design problems. There are two solutions to consider within that time frame.
23+
This fork will push back the Iceage as far as is reasonable and will give us time to update the Iceage to no longer have these design problems. There are two solutions to consider within that time frame.
2424

2525
- Update the mechanism so that behavior is predictable.
2626
- Remove the Iceage entirely

pyproject.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ markers = [
1717
"evm_tools: marks tests as evm_tools (deselect with '-m \"not evm_tools\"')",
1818
]
1919

20+
[tool.coverage.run]
21+
omit = [
22+
"*/ethereum/*_glacier/*",
23+
"*/ethereum/dao_fork/*",
24+
]
25+
2026
[tool.docc]
2127
context = [
2228
"docc.references.context",

tox.ini

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ commands =
2222
pytest \
2323
-m "not slow" \
2424
-n auto --maxprocesses 5 \
25-
--cov=ethereum --cov-report=term --cov-report "xml:{toxworkdir}/coverage.xml" \
25+
--cov-config=pyproject.toml \
26+
--cov=ethereum \
27+
--cov-report=term \
28+
--cov-report "xml:{toxworkdir}/coverage.xml" \
29+
--no-cov-on-fail \
30+
--cov-branch \
2631
--ignore-glob='tests/fixtures/*' \
2732
--basetemp="{temp_dir}/pytest"
2833

0 commit comments

Comments
 (0)