Skip to content

fix(fill): don't split slow tests into separate pre-alloc groups #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danceratopz wants to merge 1 commit into
base: forks/osaka
Choose a base branch
from
Draft

fix(fill): don't split slow tests into separate pre-alloc groups #1819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions packages/testing/src/execution_testing/cli/pytest_commands/plugins/filler/filler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,33 +1547,6 @@ def pytest_collection_modifyitems(

markers = list(item.iter_markers())

# Automatically apply pre_alloc_group marker to slow tests that are not
# benchmark tests
has_slow_marker = any(marker.name == "slow" for marker in markers)
has_benchmark_marker = any(
marker.name == "benchmark" for marker in markers
)
has_pre_alloc_group_marker = any(
marker.name == "pre_alloc_group" for marker in markers
)

if (
has_slow_marker
and not has_benchmark_marker
and not has_pre_alloc_group_marker
):
# Add pre_alloc_group marker to isolate slow non-benchmark tests
pre_alloc_marker = pytest.mark.pre_alloc_group(
"separate",
reason=(
"Non-benchmark tests marked as slow should be generated "
"with their own pre-alloc-group"
),
)
item.add_marker(pre_alloc_marker)
# Re-collect markers after adding the new one
markers = list(item.iter_markers())

# Both the fixture format itself and the spec filling it have a chance
# to veto the filling of a specific format.
if fixture_format.discard_fixture_format_by_marks(fork, markers):
Expand Down
Loading