From 4852cfe2ff3090862a873399ab653dc571b7c0c6 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 4 Dec 2025 19:43:07 +0000 Subject: [PATCH 1/8] enhance(ci): Add EIP Tracker Issue Template --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 77 +++++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/eip-tracker.yaml diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml new file mode 100644 index 0000000000..a13cd49f70 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -0,0 +1,77 @@ +name: "EIP Implementation Tracker" +description: "Track specification and testing progress for an EIP" +title: "EIP ${{ form.eip_number }} Progress Tracker" +labels: + - A-spec-specs + - A-spec-tests + - C-eip + - C-test + +body: + - type: input + id: eip_number + attributes: + label: "EIP Number" + description: "Enter the EIP number (digits only)." + placeholder: "e.g., 8024" + validations: + required: true + + - type: input + id: eip_title + attributes: + label: "EIP Title" + description: "Copy the title from the EIP." + placeholder: "e.g., Backwards compatible SWAPN, DUPN, EXCHANGE" + validations: + required: true + + - type: dropdown + id: fork + attributes: + label: "Fork" + description: | + Specify the target fork **only if the EIP has reached the CFI stage**. + More info: https://eips.ethereum.org/EIPS/eip-7723#considered-for-inclusion + options: + - TBD + - amsterdam + - bogota + validations: + required: true + + - type: markdown + attributes: + value: | + ## EIP ${{ form.eip_number }}: ${{ form.eip_title }} + + **Link:** https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }} + + ## Target Fork + + Fork **${{ form.fork }}** + + - [ ] Add issue to fork milestone (if applicable). + + ## Ownership + + Owner(s): **TBD** + + ## Specification + Testing Status + + - [ ] Testing complexity assessed and documented. + - [ ] Specification implementation merged to `eips/${{ form.fork }}/eip-${{ form.eip_number }}`. + - [ ] Specification updates merged to the corresponding `forks/${{ form.fork }}` branch. + - [ ] Required testing framework modifications implemented. + - [ ] Test suite implemented. + - [ ] Full code coverage for all changes. + - [ ] Testing checklist complete + (https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md). + - [ ] No regressions or failures in tests from prior forks (including static tests). + - [ ] Hardening session completed. + - [ ] Benchmarking performed and results documented. + + ## Process Status + + - [ ] Client implementation prototypes done. + - [ ] EIP included in a devnet. \ No newline at end of file From 75b7ae0ab9f916a755bcda4180c43f057a3867e6 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Thu, 4 Dec 2025 19:54:47 +0000 Subject: [PATCH 2/8] Add note and paraphrase. --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index a13cd49f70..4de1b9a033 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -57,6 +57,8 @@ body: Owner(s): **TBD** + **Important note:** A specifications specialist and a testing specialist should ideally share ownership of the EIP. + ## Specification + Testing Status - [ ] Testing complexity assessed and documented. @@ -73,5 +75,5 @@ body: ## Process Status - - [ ] Client implementation prototypes done. + - [ ] Hive tests passing on all implementations. - [ ] EIP included in a devnet. \ No newline at end of file From abf60550c8f56f05ee1c1b977eca0b0f60438fb3 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:14:20 +0100 Subject: [PATCH 3/8] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 4de1b9a033..4ccb8fb1cf 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -57,7 +57,8 @@ body: Owner(s): **TBD** - **Important note:** A specifications specialist and a testing specialist should ideally share ownership of the EIP. + [!IMPORTANT] + A specifications specialist and a testing specialist should ideally share ownership of the EIP. ## Specification + Testing Status From 691545c4ae10ce3a395d7a8c5adf5c79b52ce214 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:26:28 +0100 Subject: [PATCH 4/8] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 4ccb8fb1cf..2c5983d12d 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -77,4 +77,5 @@ body: ## Process Status - [ ] Hive tests passing on all implementations. - - [ ] EIP included in a devnet. \ No newline at end of file + - [ ] EIP included in a devnet. + \ No newline at end of file From 000279d5c4aa6908c9b0f53a06456af7a358da81 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:29:04 +0100 Subject: [PATCH 5/8] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: Carson --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 2c5983d12d..81b06a709c 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -68,8 +68,8 @@ body: - [ ] Required testing framework modifications implemented. - [ ] Test suite implemented. - [ ] Full code coverage for all changes. - - [ ] Testing checklist complete - (https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md). + - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete + . - [ ] No regressions or failures in tests from prior forks (including static tests). - [ ] Hardening session completed. - [ ] Benchmarking performed and results documented. From 1d0d104277ef0c8895fa72393b36dcc742f5c5e3 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:29:40 +0100 Subject: [PATCH 6/8] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml Co-authored-by: spencer --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 81b06a709c..480c5b36d0 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -43,9 +43,7 @@ body: - type: markdown attributes: value: | - ## EIP ${{ form.eip_number }}: ${{ form.eip_title }} - - **Link:** https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }} + ## [EIP-${{ form.eip_number }}](https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }}) ## Target Fork From 7d28961b70e535c35703981e2d1591bc4693b2a0 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 15:27:38 +0000 Subject: [PATCH 7/8] Review feedback --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index 480c5b36d0..ed79a1f68f 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -45,34 +45,34 @@ body: value: | ## [EIP-${{ form.eip_number }}](https://eips.ethereum.org/EIPS/eip-${{ form.eip_number }}) - ## Target Fork + ### Target Fork Fork **${{ form.fork }}** - - [ ] Add issue to fork milestone (if applicable). - - ## Ownership + ### Instructions - Owner(s): **TBD** + - [ ] Assign issue to EIP specification and testing owner(s). + + > [!IMPORTANT] + > A specifications specialist and a testing specialist should ideally share ownership of the EIP. - [!IMPORTANT] - A specifications specialist and a testing specialist should ideally share ownership of the EIP. + - [ ] Add the issue to the target fork milestone if applicable (i.e., the EIP is at least in the (CFI stage)[https://eips.ethereum.org/EIPS/eip-7723#considered-for-inclusion]). - ## Specification + Testing Status + ### Specification + Testing Status - [ ] Testing complexity assessed and documented. - - [ ] Specification implementation merged to `eips/${{ form.fork }}/eip-${{ form.eip_number }}`. + - [ ] Specification implementation merged to `eips/${{ form.fork }}/eip-${{ form.eip_number }}` *(skip if the fork branch merge below is already complete)*. - [ ] Specification updates merged to the corresponding `forks/${{ form.fork }}` branch. + - [ ] EIP updates proposed in case of architectural choices surfaced during implementation. - [ ] Required testing framework modifications implemented. - [ ] Test suite implemented. - [ ] Full code coverage for all changes. - - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete - . + - [ ] [Testing checklist](https://github.com/ethereum/execution-specs/blob/HEAD/docs/writing_tests/checklist_templates/eip_testing_checklist_template.md) complete. - [ ] No regressions or failures in tests from prior forks (including static tests). - [ ] Hardening session completed. - [ ] Benchmarking performed and results documented. - ## Process Status + ### Process Status - [ ] Hive tests passing on all implementations. - [ ] EIP included in a devnet. From c19ad02cc8d0ad44da1e949d60a64b03adfc4732 Mon Sep 17 00:00:00 2001 From: Mario Vega Date: Fri, 5 Dec 2025 16:57:18 +0100 Subject: [PATCH 8/8] Update .github/ISSUE_TEMPLATE/eip-tracker.yaml --- .github/ISSUE_TEMPLATE/eip-tracker.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/eip-tracker.yaml b/.github/ISSUE_TEMPLATE/eip-tracker.yaml index ed79a1f68f..9afa24e9ca 100644 --- a/.github/ISSUE_TEMPLATE/eip-tracker.yaml +++ b/.github/ISSUE_TEMPLATE/eip-tracker.yaml @@ -71,6 +71,8 @@ body: - [ ] No regressions or failures in tests from prior forks (including static tests). - [ ] Hardening session completed. - [ ] Benchmarking performed and results documented. + - [ ] Ran tests using `execute` to ensure compatibility, and marked specific tests to be skipped when they cannot be executed on live networks. + - [ ] Added Mainnet-marked tests ([example test](https://github.com/ethereum/execution-specs/blob/2a6f9ee98ba7c0d04c7d523a0ea0ee8a98a5c418/tests/osaka/eip7939_count_leading_zeros/test_eip_mainnet.py)). ### Process Status