Skip to content

Commit 02766d3

Browse files
authored
internal/flags: add missing flag types for auto-env-var generation (#28692)
Certain flags, such as `--rpc.txfeecap` currently do not have an env-var auto-generated for them. This change adds three missing cli flag types to the auto env-var helper function to fix this.
1 parent 5b22a47 commit 02766d3

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

internal/flags/helpers.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func MigrateGlobalFlags(ctx *cli.Context) {
105105
func doMigrateFlags(ctx *cli.Context) {
106106
// Figure out if there are any aliases of commands. If there are, we want
107107
// to ignore them when iterating over the flags.
108-
var aliases = make(map[string]bool)
108+
aliases := make(map[string]bool)
109109
for _, fl := range ctx.Command.Flags {
110110
for _, alias := range fl.Names()[1:] {
111111
aliases[alias] = true
@@ -239,15 +239,24 @@ func AutoEnvVars(flags []cli.Flag, prefix string) {
239239
case *cli.StringFlag:
240240
flag.EnvVars = append(flag.EnvVars, envvar)
241241

242+
case *cli.StringSliceFlag:
243+
flag.EnvVars = append(flag.EnvVars, envvar)
244+
242245
case *cli.BoolFlag:
243246
flag.EnvVars = append(flag.EnvVars, envvar)
244247

245248
case *cli.IntFlag:
246249
flag.EnvVars = append(flag.EnvVars, envvar)
247250

251+
case *cli.Int64Flag:
252+
flag.EnvVars = append(flag.EnvVars, envvar)
253+
248254
case *cli.Uint64Flag:
249255
flag.EnvVars = append(flag.EnvVars, envvar)
250256

257+
case *cli.Float64Flag:
258+
flag.EnvVars = append(flag.EnvVars, envvar)
259+
251260
case *cli.DurationFlag:
252261
flag.EnvVars = append(flag.EnvVars, envvar)
253262

0 commit comments

Comments
 (0)