Skip to content

Commit 03b8c68

Browse files
committed
Topics => Topic. Closes #343
1 parent fdecc11 commit 03b8c68

File tree

3 files changed

+7
-22
lines changed

3 files changed

+7
-22
lines changed

rpc/args.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ type WhisperMessageArgs struct {
289289
Payload string
290290
To string
291291
From string
292-
Topics []string
292+
Topic []string
293293
Priority uint32
294294
Ttl uint32
295295
}

rpc/message.go

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -231,21 +231,6 @@ func (req *RpcRequest) ToFilterStringArgs() (string, error) {
231231
return args, nil
232232
}
233233

234-
func (req *RpcRequest) ToFilterChangedArgs() (int, error) {
235-
if len(req.Params) < 1 {
236-
return 0, NewErrorResponse(ErrorArguments)
237-
}
238-
239-
var id int
240-
r := bytes.NewReader(req.Params[0])
241-
err := json.NewDecoder(r).Decode(&id)
242-
if err != nil {
243-
return 0, NewErrorResponse(ErrorDecodeArgs)
244-
}
245-
rpclogger.DebugDetailf("%T %v", id, id)
246-
return id, nil
247-
}
248-
249234
func (req *RpcRequest) ToDbPutArgs() (*DbArgs, error) {
250235
if len(req.Params) < 3 {
251236
return nil, NewErrorResponse(ErrorArguments)
@@ -301,7 +286,7 @@ func (req *RpcRequest) ToWhisperFilterArgs() (*xeth.Options, error) {
301286
return &args, nil
302287
}
303288

304-
func (req *RpcRequest) ToWhisperIdArgs() (int, error) {
289+
func (req *RpcRequest) ToIdArgs() (int, error) {
305290
if len(req.Params) < 1 {
306291
return 0, NewErrorResponse(ErrorArguments)
307292
}

rpc/packages.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ func (self *EthereumApi) MessagesChanged(id int, reply *interface{}) error {
349349
}
350350

351351
func (p *EthereumApi) WhisperPost(args *WhisperMessageArgs, reply *interface{}) error {
352-
err := p.xeth.Whisper().Post(args.Payload, args.To, args.From, args.Topics, args.Priority, args.Ttl)
352+
err := p.xeth.Whisper().Post(args.Payload, args.To, args.From, args.Topic, args.Priority, args.Ttl)
353353
if err != nil {
354354
return err
355355
}
@@ -445,13 +445,13 @@ func (p *EthereumApi) GetRequestReply(req *RpcRequest, reply *interface{}) error
445445
}
446446
return p.NewFilterString(args, reply)
447447
case "eth_changed":
448-
args, err := req.ToFilterChangedArgs()
448+
args, err := req.ToIdArgs()
449449
if err != nil {
450450
return err
451451
}
452452
return p.FilterChanged(args, reply)
453453
case "eth_filterLogs":
454-
args, err := req.ToFilterChangedArgs()
454+
args, err := req.ToIdArgs()
455455
if err != nil {
456456
return err
457457
}
@@ -504,7 +504,7 @@ func (p *EthereumApi) GetRequestReply(req *RpcRequest, reply *interface{}) error
504504
}
505505
return p.NewWhisperFilter(args, reply)
506506
case "shh_changed":
507-
args, err := req.ToWhisperIdArgs()
507+
args, err := req.ToIdArgs()
508508
if err != nil {
509509
return err
510510
}
@@ -522,7 +522,7 @@ func (p *EthereumApi) GetRequestReply(req *RpcRequest, reply *interface{}) error
522522
}
523523
return p.HasWhisperIdentity(args, reply)
524524
case "shh_getMessages":
525-
args, err := req.ToWhisperIdArgs()
525+
args, err := req.ToIdArgs()
526526
if err != nil {
527527
return err
528528
}

0 commit comments

Comments
 (0)