core/txpool/blobpool: avoid possible zero index panic (#30430)

mask-pp · holiman · web-flow · commit 0dd7e82c0aef · 2024-09-14T15:45:52.000+02:00
This situation(`len(txs) == 0`) rarely occurs, but if it does, it will
panic.

---------

Co-authored-by: Martin HS &lt;martin@swende.se&gt;
diff --git a/core/txpool/blobpool/blobpool.go b/core/txpool/blobpool/blobpool.go
@@ -566,7 +566,7 @@ func (p *BlobPool) recheck(addr common.Address, inclusions map[common.Hash]uint6
 			ids    []uint64
 			nonces []uint64
 		)
-		for txs[0].nonce < next {
+		for len(txs) > 0 && txs[0].nonce < next {
 			ids = append(ids, txs[0].id)
 			nonces = append(nonces, txs[0].nonce)
 

Original file line number	Diff line number	Diff line change
`@@ -566,7 +566,7 @@ func (p *BlobPool) recheck(addr common.Address, inclusions map[common.Hash]uint6`
`566`	`566`	`ids []uint64`
`567`	`567`	`nonces []uint64`
`568`	`568`	`)`
`569`		`- for txs[0].nonce < next {`
	`569`	`+ for len(txs) > 0 && txs[0].nonce < next {`
`570`	`570`	`ids = append(ids, txs[0].id)`
`571`	`571`	`nonces = append(nonces, txs[0].nonce)`
`572`	`572`