[release 1.4.5] eth: fixed regression in eth_signTransaction fixes #2578

obscuren · obscuren · commit 0f6e3e873ab3 · 2016-05-24T09:33:10.000+02:00
Sign transaction returned the unsigned transaction rather than the signed one. (cherry picked from commit 4b1a7d3)
diff --git a/eth/api.go b/eth/api.go
@@ -1408,7 +1408,7 @@ func (s *PublicTransactionPoolAPI) SignTransaction(args SignTransactionArgs) (*S
 		return nil, err
 	}
 
-	return &SignTransactionResult{"0x" + common.Bytes2Hex(data), newTx(tx)}, nil
+	return &SignTransactionResult{"0x" + common.Bytes2Hex(data), newTx(signedTx)}, nil
 }
 
 // PendingTransactions returns the transactions that are in the transaction pool and have a from address that is one of

Original file line number	Diff line number	Diff line change
`@@ -1408,7 +1408,7 @@ func (s PublicTransactionPoolAPI) SignTransaction(args SignTransactionArgs) (S`
`1408`	`1408`	`return nil, err`
`1409`	`1409`	`}`
`1410`	`1410`
`1411`		`- return &SignTransactionResult{"0x" + common.Bytes2Hex(data), newTx(tx)}, nil`
	`1411`	`+ return &SignTransactionResult{"0x" + common.Bytes2Hex(data), newTx(signedTx)}, nil`
`1412`	`1412`	`}`
`1413`	`1413`
`1414`	`1414`	`// PendingTransactions returns the transactions that are in the transaction pool and have a from address that is one of`