cmd/utils: add comment about overriding network id

lightclient · fjl · commit 131fc2145888 · 2025-11-28T15:11:25.000+01:00
diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go
@@ -1917,6 +1917,9 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
 		}
 	}
 	if ctx.IsSet(NetworkIdFlag.Name) {
+		// Typically it's best to automatically set the network id to the chain id,
+		// by not passing the network id flag at all. Emit a warning when set
+		// explicitly in case overriding the network id is not the user's intention.
 		id := ctx.Uint64(NetworkIdFlag.Name)
 		log.Warn("Setting network id with flag", "id", id)
 		cfg.NetworkId = id

Original file line number	Diff line number	Diff line change
`@@ -1917,6 +1917,9 @@ func SetEthConfig(ctx cli.Context, stack node.Node, cfg *ethconfig.Config) {`
`1917`	`1917`	`}`
`1918`	`1918`	`}`
`1919`	`1919`	`if ctx.IsSet(NetworkIdFlag.Name) {`
	`1920`	`+ // Typically it's best to automatically set the network id to the chain id,`
	`1921`	`+ // by not passing the network id flag at all. Emit a warning when set`
	`1922`	`+ // explicitly in case overriding the network id is not the user's intention.`
`1920`	`1923`	`id := ctx.Uint64(NetworkIdFlag.Name)`
`1921`	`1924`	`log.Warn("Setting network id with flag", "id", id)`
`1922`	`1925`	`cfg.NetworkId = id`