internal/ethapi: remove double map-clone (#30803)

hyunsooda · web-flow · commit 19fa71b917df · 2024-11-25T13:33:28.000+01:00
Similar to #30788
diff --git a/internal/ethapi/simulate.go b/internal/ethapi/simulate.go
@@ -21,7 +21,6 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"maps"
 	"math/big"
 	"time"
 
@@ -186,7 +185,7 @@ func (sim *simulator) processBlock(ctx context.Context, block *simBlock, header,
 			Tracer:    tracer.Hooks(),
 		}
 	)
-	var tracingStateDB = vm.StateDB(sim.state)
+	tracingStateDB := vm.StateDB(sim.state)
 	if hooks := tracer.Hooks(); hooks != nil {
 		tracingStateDB = state.NewHookedState(sim.state, hooks)
 	}
@@ -289,7 +288,7 @@ func (sim *simulator) activePrecompiles(base *types.Header) vm.PrecompiledContra
 		isMerge = (base.Difficulty.Sign() == 0)
 		rules   = sim.chainConfig.Rules(base.Number, isMerge, base.Time)
 	)
-	return maps.Clone(vm.ActivePrecompiledContracts(rules))
+	return vm.ActivePrecompiledContracts(rules)
 }
 
 // sanitizeChain checks the chain integrity. Specifically it checks that

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@ import (`
`21`	`21`	`"encoding/json"`
`22`	`22`	`"errors"`
`23`	`23`	`"fmt"`
`24`		`- "maps"`
`25`	`24`	`"math/big"`
`26`	`25`	`"time"`
`27`	`26`
`@@ -186,7 +185,7 @@ func (sim simulator) processBlock(ctx context.Context, block simBlock, header,`
`186`	`185`	`Tracer: tracer.Hooks(),`
`187`	`186`	`}`
`188`	`187`	`)`
`189`		`- var tracingStateDB = vm.StateDB(sim.state)`
	`188`	`+ tracingStateDB := vm.StateDB(sim.state)`
`190`	`189`	`if hooks := tracer.Hooks(); hooks != nil {`
`191`	`190`	`tracingStateDB = state.NewHookedState(sim.state, hooks)`
`192`	`191`	`}`
`@@ -289,7 +288,7 @@ func (sim simulator) activePrecompiles(base types.Header) vm.PrecompiledContra`
`289`	`288`	`isMerge = (base.Difficulty.Sign() == 0)`
`290`	`289`	`rules = sim.chainConfig.Rules(base.Number, isMerge, base.Time)`
`291`	`290`	`)`
`292`		`- return maps.Clone(vm.ActivePrecompiledContracts(rules))`
	`291`	`+ return vm.ActivePrecompiledContracts(rules)`
`293`	`292`	`}`
`294`	`293`
`295`	`294`	`// sanitizeChain checks the chain integrity. Specifically it checks that`