internal/ethapi: correctly calculate effective gas price (#28130)

cam-schultz · web-flow · commit 217719347dd2 · 2023-09-17T17:00:04.000+03:00
correctly calculate effective gas price
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -1520,8 +1520,8 @@ func newRPCTransaction(tx *types.Transaction, blockHash common.Hash, blockNumber
 func effectiveGasPrice(tx *types.Transaction, baseFee *big.Int) *big.Int {
 	fee := tx.GasTipCap()
 	fee = fee.Add(fee, baseFee)
-	if tx.GasTipCapIntCmp(fee) < 0 {
-		return tx.GasTipCap()
+	if tx.GasFeeCapIntCmp(fee) < 0 {
+		return tx.GasFeeCap()
 	}
 	return fee
 }

Original file line number	Diff line number	Diff line change
`@@ -1520,8 +1520,8 @@ func newRPCTransaction(tx *types.Transaction, blockHash common.Hash, blockNumber`
`1520`	`1520`	`func effectiveGasPrice(tx types.Transaction, baseFee big.Int) *big.Int {`
`1521`	`1521`	`fee := tx.GasTipCap()`
`1522`	`1522`	`fee = fee.Add(fee, baseFee)`
`1523`		`- if tx.GasTipCapIntCmp(fee) < 0 {`
`1524`		`- return tx.GasTipCap()`
	`1523`	`+ if tx.GasFeeCapIntCmp(fee) < 0 {`
	`1524`	`+ return tx.GasFeeCap()`
`1525`	`1525`	`}`
`1526`	`1526`	`return fee`
`1527`	`1527`	`}`