tests: fix test panic (#30741)

rjl493456442 · holiman · commit 243feea41705 · 2024-11-19T14:50:11.000+01:00
Fix panic in tests
diff --git a/tests/state_test_util.go b/tests/state_test_util.go
@@ -308,6 +308,7 @@ func (t *StateTest) RunNoVerify(subtest StateSubtest, vmconfig vm.Config, snapsh
 		if tracer := evm.Config.Tracer; tracer != nil && tracer.OnTxEnd != nil {
 			evm.Config.Tracer.OnTxEnd(nil, err)
 		}
+		return st, common.Hash{}, 0, err
 	}
 	// Add 0-value mining reward. This only makes a difference in the cases
 	// where
@@ -322,7 +323,7 @@ func (t *StateTest) RunNoVerify(subtest StateSubtest, vmconfig vm.Config, snapsh
 		receipt := &types.Receipt{GasUsed: vmRet.UsedGas}
 		tracer.OnTxEnd(receipt, nil)
 	}
-	return st, root, vmRet.UsedGas, err
+	return st, root, vmRet.UsedGas, nil
 }
 
 func (t *StateTest) gasLimit(subtest StateSubtest) uint64 {

Original file line number	Diff line number	Diff line change
`@@ -308,6 +308,7 @@ func (t *StateTest) RunNoVerify(subtest StateSubtest, vmconfig vm.Config, snapsh`
`308`	`308`	`if tracer := evm.Config.Tracer; tracer != nil && tracer.OnTxEnd != nil {`
`309`	`309`	`evm.Config.Tracer.OnTxEnd(nil, err)`
`310`	`310`	`}`
	`311`	`+ return st, common.Hash{}, 0, err`
`311`	`312`	`}`
`312`	`313`	`// Add 0-value mining reward. This only makes a difference in the cases`
`313`	`314`	`// where`
`@@ -322,7 +323,7 @@ func (t *StateTest) RunNoVerify(subtest StateSubtest, vmconfig vm.Config, snapsh`
`322`	`323`	`receipt := &types.Receipt{GasUsed: vmRet.UsedGas}`
`323`	`324`	`tracer.OnTxEnd(receipt, nil)`
`324`	`325`	`}`
`325`		`- return st, root, vmRet.UsedGas, err`
	`326`	`+ return st, root, vmRet.UsedGas, nil`
`326`	`327`	`}`
`327`	`328`
`328`	`329`	`func (t *StateTest) gasLimit(subtest StateSubtest) uint64 {`