Skip to content

Commit 3ebb143

Browse files
authored
eth: using testing.B.Loop (#32657)
before: go test -run=^$ -bench=. ./eth/... 827.57s user 23.80s system 361% cpu 3:55.49 total after: go test -run=^$ -bench=. ./eth/... 281.62s user 13.62s system 245% cpu 2:00.49 total
1 parent d41dc92 commit 3ebb143

File tree

5 files changed

+6
-13
lines changed

5 files changed

+6
-13
lines changed

eth/filters/filter_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,8 @@ func benchmarkFilters(b *testing.B, history uint64, noHistory bool) {
109109
backend.startFilterMaps(history, noHistory, filtermaps.DefaultParams)
110110
defer backend.stopFilterMaps()
111111

112-
b.ResetTimer()
113-
114112
filter := sys.NewRangeFilter(0, int64(rpc.LatestBlockNumber), []common.Address{addr1, addr2, addr3, addr4}, nil)
115-
116-
for i := 0; i < b.N; i++ {
113+
for b.Loop() {
117114
filter.begin = 0
118115
logs, _ := filter.Logs(context.Background())
119116
if len(logs) != 4 {

eth/protocols/snap/sync_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,13 @@ func BenchmarkHashing(b *testing.B) {
106106
}
107107
b.Run("old", func(b *testing.B) {
108108
b.ReportAllocs()
109-
for i := 0; i < b.N; i++ {
109+
for b.Loop() {
110110
old()
111111
}
112112
})
113113
b.Run("new", func(b *testing.B) {
114114
b.ReportAllocs()
115-
for i := 0; i < b.N; i++ {
115+
for b.Loop() {
116116
new()
117117
}
118118
})

eth/tracers/internal/tracetest/calltrace_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,11 +211,9 @@ func benchTracer(tracerName string, test *callTracerTest, b *testing.B) {
211211
defer state.Close()
212212

213213
b.ReportAllocs()
214-
b.ResetTimer()
215214

216215
evm := vm.NewEVM(context, state.StateDB, test.Genesis.Config, vm.Config{})
217-
218-
for i := 0; i < b.N; i++ {
216+
for b.Loop() {
219217
snap := state.StateDB.Snapshot()
220218
tracer, err := tracers.DefaultDirectory.New(tracerName, new(tracers.Context), nil, test.Genesis.Config)
221219
if err != nil {

eth/tracers/internal/tracetest/flat_calltrace_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ func BenchmarkFlatCallTracer(b *testing.B) {
201201
for _, file := range files {
202202
filename := strings.TrimPrefix(file, "testdata/call_tracer_flat/")
203203
b.Run(camel(strings.TrimSuffix(filename, ".json")), func(b *testing.B) {
204-
for n := 0; n < b.N; n++ {
204+
for b.Loop() {
205205
err := flatCallTracerTestRunner("flatCallTracer", filename, "call_tracer_flat", b)
206206
if err != nil {
207207
b.Fatal(err)

eth/tracers/tracers_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,8 @@ func BenchmarkTransactionTraceV2(b *testing.B) {
8484
if err != nil {
8585
b.Fatalf("failed to prepare transaction for tracing: %v", err)
8686
}
87-
b.ResetTimer()
8887
b.ReportAllocs()
89-
90-
for i := 0; i < b.N; i++ {
88+
for b.Loop() {
9189
tracer := logger.NewStructLogger(&logger.Config{}).Hooks()
9290
tracer.OnTxStart(evm.GetVMContext(), tx, msg.From)
9391
evm.Config.Tracer = tracer

0 commit comments

Comments
 (0)