core/txpool/blobpool: fix rlp decoding flaw during offload (#28027)

lightclient · web-flow · commit 41ee96fdfee5 · 2023-08-30T03:28:03.000-04:00
diff --git a/core/txpool/blobpool/blobpool.go b/core/txpool/blobpool/blobpool.go
@@ -714,7 +714,7 @@ func (p *BlobPool) offload(addr common.Address, nonce uint64, id uint64, inclusi
 		return
 	}
 	var tx types.Transaction
-	if err = rlp.DecodeBytes(data, tx); err != nil {
+	if err = rlp.DecodeBytes(data, &tx); err != nil {
 		log.Error("Blobs corrupted for included transaction", "from", addr, "nonce", nonce, "id", id, "err", err)
 		return
 	}

Original file line number	Diff line number	Diff line change
`@@ -714,7 +714,7 @@ func (p *BlobPool) offload(addr common.Address, nonce uint64, id uint64, inclusi`
`714`	`714`	`return`
`715`	`715`	`}`
`716`	`716`	`var tx types.Transaction`
`717`		`- if err = rlp.DecodeBytes(data, tx); err != nil {`
	`717`	`+ if err = rlp.DecodeBytes(data, &tx); err != nil {`
`718`	`718`	`log.Error("Blobs corrupted for included transaction", "from", addr, "nonce", nonce, "id", id, "err", err)`
`719`	`719`	`return`
`720`	`720`	`}`