Skip to content

Commit 444fc89

Browse files
authored
Merge pull request #3524 from karalabe/mobile-signwith-swift-fixup
mobile: rename passphrase signing method to avoid Swift rewrite
2 parents e0fde02 + b56aee3 commit 444fc89

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

mobile/accounts.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,10 @@ func (am *AccountManager) Sign(address *Address, hash []byte) (signature []byte,
115115
return am.manager.Sign(address.address, hash)
116116
}
117117

118-
// SignWithPassphrase signs hash if the private key matching the given address
119-
// can be decrypted with the given passphrase. The produced signature is in the
118+
// SignPassphrase signs hash if the private key matching the given address can
119+
// be decrypted with the given passphrase. The produced signature is in the
120120
// [R || S || V] format where V is 0 or 1.
121-
func (am *AccountManager) SignWithPassphrase(account *Account, passphrase string, hash []byte) (signature []byte, _ error) {
121+
func (am *AccountManager) SignPassphrase(account *Account, passphrase string, hash []byte) (signature []byte, _ error) {
122122
return am.manager.SignWithPassphrase(account.account, passphrase, hash)
123123
}
124124

mobile/android_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public class AndroidTest extends InstrumentationTestCase {
6969
Hash txHash = new Hash("0x0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef");
7070
7171
// Sign a transaction with a single authorization
72-
byte[] signature = am.signWithPassphrase(signer, "Signer password", txHash.getBytes());
72+
byte[] signature = am.signPassphrase(signer, "Signer password", txHash.getBytes());
7373
7474
// Sign a transaction with multiple manually cancelled authorizations
7575
am.unlock(signer, "Signer password");

0 commit comments

Comments
 (0)