core/state: check err for iter.Error in fastDeleteStorage (#28122)

Darioush Jalali · web-flow · commit 48fdb79de5a3 · 2023-09-15T14:09:07.000+08:00
core/state: check err for iter.Error
diff --git a/core/state/statedb.go b/core/state/statedb.go
@@ -973,7 +973,7 @@ func (s *StateDB) fastDeleteStorage(addrHash common.Hash, root common.Hash) (boo
 			return true, size, nil, nil, nil
 		}
 		slot := common.CopyBytes(iter.Slot())
-		if iter.Error() != nil { // error might occur after Slot function
+		if err := iter.Error(); err != nil { // error might occur after Slot function
 			return false, 0, nil, nil, err
 		}
 		size += common.StorageSize(common.HashLength + len(slot))
@@ -983,7 +983,7 @@ func (s *StateDB) fastDeleteStorage(addrHash common.Hash, root common.Hash) (boo
 			return false, 0, nil, nil, err
 		}
 	}
-	if iter.Error() != nil { // error might occur during iteration
+	if err := iter.Error(); err != nil { // error might occur during iteration
 		return false, 0, nil, nil, err
 	}
 	if stack.Hash() != root {

Original file line number	Diff line number	Diff line change
`@@ -973,7 +973,7 @@ func (s *StateDB) fastDeleteStorage(addrHash common.Hash, root common.Hash) (boo`
`973`	`973`	`return true, size, nil, nil, nil`
`974`	`974`	`}`
`975`	`975`	`slot := common.CopyBytes(iter.Slot())`
`976`		`- if iter.Error() != nil { // error might occur after Slot function`
	`976`	`+ if err := iter.Error(); err != nil { // error might occur after Slot function`
`977`	`977`	`return false, 0, nil, nil, err`
`978`	`978`	`}`
`979`	`979`	`size += common.StorageSize(common.HashLength + len(slot))`
`@@ -983,7 +983,7 @@ func (s *StateDB) fastDeleteStorage(addrHash common.Hash, root common.Hash) (boo`
`983`	`983`	`return false, 0, nil, nil, err`
`984`	`984`	`}`
`985`	`985`	`}`
`986`		`- if iter.Error() != nil { // error might occur during iteration`
	`986`	`+ if err := iter.Error(); err != nil { // error might occur during iteration`
`987`	`987`	`return false, 0, nil, nil, err`
`988`	`988`	`}`
`989`	`989`	`if stack.Hash() != root {`