cmd/utils: flags should not be setted to true directly

cuiweixie · cuiweixie · commit 5185053537a1 · 2025-12-02T10:19:32.000+08:00
diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go
@@ -1368,7 +1368,7 @@ func SetP2PConfig(ctx *cli.Context, cfg *p2p.Config) {
 		cfg.MaxPendingPeers = ctx.Int(MaxPendingPeersFlag.Name)
 	}
 	if ctx.IsSet(NoDiscoverFlag.Name) {
-		cfg.NoDiscovery = true
+		cfg.NoDiscovery = ctx.Bool(NoDiscoverFlag.Name)
 	}
 
 	flags.CheckExclusive(ctx, DiscoveryV4Flag, NoDiscoverFlag)
@@ -1718,7 +1718,7 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
 		cfg.LogHistory = ctx.Uint64(LogHistoryFlag.Name)
 	}
 	if ctx.IsSet(LogNoHistoryFlag.Name) {
-		cfg.LogNoHistory = true
+		cfg.LogNoHistory = ctx.Bool(LogNoHistoryFlag.Name)
 	}
 	if ctx.IsSet(LogExportCheckpointsFlag.Name) {
 		cfg.LogExportCheckpoints = ctx.String(LogExportCheckpointsFlag.Name)

Original file line number	Diff line number	Diff line change
`@@ -1368,7 +1368,7 @@ func SetP2PConfig(ctx cli.Context, cfg p2p.Config) {`
`1368`	`1368`	`cfg.MaxPendingPeers = ctx.Int(MaxPendingPeersFlag.Name)`
`1369`	`1369`	`}`
`1370`	`1370`	`if ctx.IsSet(NoDiscoverFlag.Name) {`
`1371`		`- cfg.NoDiscovery = true`
	`1371`	`+ cfg.NoDiscovery = ctx.Bool(NoDiscoverFlag.Name)`
`1372`	`1372`	`}`
`1373`	`1373`
`1374`	`1374`	`flags.CheckExclusive(ctx, DiscoveryV4Flag, NoDiscoverFlag)`
`@@ -1718,7 +1718,7 @@ func SetEthConfig(ctx cli.Context, stack node.Node, cfg *ethconfig.Config) {`
`1718`	`1718`	`cfg.LogHistory = ctx.Uint64(LogHistoryFlag.Name)`
`1719`	`1719`	`}`
`1720`	`1720`	`if ctx.IsSet(LogNoHistoryFlag.Name) {`
`1721`		`- cfg.LogNoHistory = true`
	`1721`	`+ cfg.LogNoHistory = ctx.Bool(LogNoHistoryFlag.Name)`
`1722`	`1722`	`}`
`1723`	`1723`	`if ctx.IsSet(LogExportCheckpointsFlag.Name) {`
`1724`	`1724`	`cfg.LogExportCheckpoints = ctx.String(LogExportCheckpointsFlag.Name)`