Skip to content

Commit 581c028

Browse files
authored
les: cosmetic rewrite of the arm64 float bug workaround (#21960)
* les: revert arm float bug workaround to check go 1.15 * add traces to reproduce outside travis * simpler workaround
1 parent 15339cf commit 581c028

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

les/utils/expiredvalue.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,9 @@ func (e *ExpiredValue) Add(amount int64, logOffset Fixed64) int64 {
8888
if base >= 0 || uint64(-base) <= e.Base {
8989
// This is a temporary fix to circumvent a golang
9090
// uint conversion issue on arm64, which needs to
91-
// be investigated further. FIXME
92-
e.Base = uint64(int64(e.Base) + int64(base))
91+
// be investigated further. More details at:
92+
// https://github.com/golang/go/issues/43047
93+
e.Base += uint64(int64(base))
9394
return amount
9495
}
9596
net := int64(-float64(e.Base) / factor)

0 commit comments

Comments
 (0)