ethapi: deref gasUsed pointer in eth_simulate log (#33192)

davidjsonn · web-flow · commit 5e6f7374deaa · 2025-11-15T07:04:21.000-07:00
Show the actual gas used in the block limit error so RPC clients see
useful numbers.
diff --git a/internal/ethapi/simulate.go b/internal/ethapi/simulate.go
@@ -377,7 +377,7 @@ func (sim *simulator) sanitizeCall(call *TransactionArgs, state vm.StateDB, head
 		call.Gas = (*hexutil.Uint64)(&remaining)
 	}
 	if *gasUsed+uint64(*call.Gas) > blockContext.GasLimit {
-		return &blockGasLimitReachedError{fmt.Sprintf("block gas limit reached: %d >= %d", gasUsed, blockContext.GasLimit)}
+		return &blockGasLimitReachedError{fmt.Sprintf("block gas limit reached: %d >= %d", *gasUsed, blockContext.GasLimit)}
 	}
 	if err := call.CallDefaults(sim.gp.Gas(), header.BaseFee, sim.chainConfig.ChainID); err != nil {
 		return err

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ func (sim simulator) sanitizeCall(call TransactionArgs, state vm.StateDB, head`
`377`	`377`	`call.Gas = (*hexutil.Uint64)(&remaining)`
`378`	`378`	`}`
`379`	`379`	`if gasUsed+uint64(call.Gas) > blockContext.GasLimit {`
`380`		`- return &blockGasLimitReachedError{fmt.Sprintf("block gas limit reached: %d >= %d", gasUsed, blockContext.GasLimit)}`
	`380`	`+ return &blockGasLimitReachedError{fmt.Sprintf("block gas limit reached: %d >= %d", *gasUsed, blockContext.GasLimit)}`
`381`	`381`	`}`
`382`	`382`	`if err := call.CallDefaults(sim.gp.Gas(), header.BaseFee, sim.chainConfig.ChainID); err != nil {`
`383`	`383`	`return err`