cmd/geth: decent error message if metrics are disabled

karalabe · obscuren · commit 5f3792c2a750 · 2015-06-30T00:57:55.000+02:00
diff --git a/cmd/geth/monitorcmd.go b/cmd/geth/monitorcmd.go
@@ -79,7 +79,7 @@ func monitor(ctx *cli.Context) {
 		if len(list) > 0 {
 			utils.Fatalf("No metrics specified.\n\nAvailable:\n - %s", strings.Join(list, "\n - "))
 		} else {
-			utils.Fatalf("No metrics specified.\n\nNo metrics collected (--metrics)\n")
+			utils.Fatalf("No metrics collected by geth (--%s).\n", utils.MetricsEnabledFlag.Name)
 		}
 	}
 	sort.Strings(monitored)
diff --git a/core/chain_manager.go b/core/chain_manager.go
@@ -23,7 +23,6 @@ import (
 	"github.com/ethereum/go-ethereum/pow"
 	"github.com/ethereum/go-ethereum/rlp"
 	"github.com/hashicorp/golang-lru"
-	"github.com/rcrowley/go-metrics"
 	"github.com/syndtr/goleveldb/leveldb"
 )
 

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ func monitor(ctx *cli.Context) {`
`79`	`79`	`if len(list) > 0 {`
`80`	`80`	`utils.Fatalf("No metrics specified.\n\nAvailable:\n - %s", strings.Join(list, "\n - "))`
`81`	`81`	`} else {`
`82`		`- utils.Fatalf("No metrics specified.\n\nNo metrics collected (--metrics)\n")`
	`82`	`+ utils.Fatalf("No metrics collected by geth (--%s).\n", utils.MetricsEnabledFlag.Name)`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`	`sort.Strings(monitored)`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ import (`
`23`	`23`	`"github.com/ethereum/go-ethereum/pow"`
`24`	`24`	`"github.com/ethereum/go-ethereum/rlp"`
`25`	`25`	`"github.com/hashicorp/golang-lru"`
`26`		`- "github.com/rcrowley/go-metrics"`
`27`	`26`	`"github.com/syndtr/goleveldb/leveldb"`
`28`	`27`	`)`
`29`	`28`